Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 19:17:59 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "J. R. Okajima" <hooanon05g@gmail.com>
CC:     Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on
 kmap_local_page()
Message-ID: <YzuX175G/5ucUlpC@iweiny-mobl>
References: <YzN+ZYLjK6HI1P1C@ZenIV>
 <YzSSl1ItVlARDvG3@ZenIV>
 <YzpcXU2WO8e22Cmi@iweiny-desk3>
 <7714.1664794108@jrobl>
 <Yzs4mL3zrrC0/vN+@iweiny-mobl>
 <YztfvaAFOe2kGvDz@ZenIV>
 <4011.1664837894@jrobl>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4011.1664837894@jrobl>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LNvzXAmOFP8AdyoMauTyn8vOPmG75M4sIwAN8K6W1H6nxULJHuAkc9wgZKCr?=
 =?us-ascii?Q?L9eCUo4rbZgxvDRCx4tEGf6GJy/Urv5CUlGnTl+UBmxeK4hx0s8YmB8G5lFh?=
 =?us-ascii?Q?8tXWRbZI5dyIqTMYrD0b83MaYMHyWK4u2H81/lBfdSVetbleW9imwqw/Gd1h?=
 =?us-ascii?Q?YZE04cH9a/aDIlbNFukMtTo59qw0EPfgKiw2ykBywNtp4M/DSgQiv+rTeLNS?=
 =?us-ascii?Q?hIkBfG9TKdSR0HLL+2Xs1qva+V9jbEVeG7KAXFWJVkHxai96O1LaBTpmw1IC?=
 =?us-ascii?Q?a27fmdGEjUVARM6EdxzDrkfxqlB6yz96yoPfR+tlXJekXiPz8lv9CpyxcJwT?=
 =?us-ascii?Q?3UeIR2j0h9U4MFNccDBfUzMfG5bFpKAZyHIMqq8YiZh6/kau9apZPgn+dNT0?=
 =?us-ascii?Q?WWvHb5kRf+eLuQtEX81MpSTkTeMItX+UZiRliyx4IlcE7R5rEIpbRrwUcXXz?=
 =?us-ascii?Q?E9SDdPPTf7xaA8eK7I3ENChjJwKsZBAP4KAlv/ao4yModqe57m+CNnJ7+ahb?=
 =?us-ascii?Q?84epBY+hJzxwV6ghDfYpdVF9ZJtaQOoM/wkiLQVwqmT5VoCasQPNdz1QAGfq?=
 =?us-ascii?Q?OvaylDHm2VoDJOdhNuWoyIsAwpbZ79OdRCqmeCu9Isseo53LYWt6FdkkSzYV?=
 =?us-ascii?Q?soT57ajmjzfFTIjvu0ZY9V5YlGMdQrwgXd6EBap4ajkBoQvsjyA9mmj0ZLcH?=
 =?us-ascii?Q?aNvbIkA2f4mtUBgEE4j1XqKdLfm7+EgTYOrXTP4+5i/+PDfuGPKeuTon/Mhm?=
 =?us-ascii?Q?+gPduJIjf8Z+CoO/Kfqtd2SoI9JpR/mZlAvVeptxm1lD5iJMUkH8Q+If9wiy?=
 =?us-ascii?Q?ZiO+ou23OPNPTKeSJjRPSyyTXTeuhlAgex0KZ7Du2Ecb/k1uiLZRN3lhnQnw?=
 =?us-ascii?Q?SS1wGvnhA+sQu9H4LPVKon9W4c5xHylyA9n8b42rXvpEI+Fq9X3khHapBazv?=
 =?us-ascii?Q?quDe/dpz23YhRy+bn1LXDkl7pSFWCQ5t7Kqm/H2lalsXTdS70hK08ejfle50?=
 =?us-ascii?Q?oLIJ9VJCzQkZ5JR8lMSoqqWLc2tG90iIuM1xsPCRiaMlcpP/DDART4O/BjoL?=
 =?us-ascii?Q?FDH3GrySnhG60NcByxDmzJm+T4xJHAju8aFegAdFOqNz1MCYoud7+gG081rL?=
 =?us-ascii?Q?MBz9Xmbf1UNvjv0hBaWmIchCAmzcJu0p/L3tCw4wCQeVsLdrTtoJ5IdClKjc?=
 =?us-ascii?Q?45s/Nv9GiXSI9zM2HrKduY86fGR/69yjCaDuNiaQb/z3lwkf09r96r37YHww?=
 =?us-ascii?Q?G3lvimwsLf9LnG0e7MBN7UbCyrD7nQmGE7lJ4IT+BIKL1N6e6rg7CYdqS2MA?=
 =?us-ascii?Q?PkWiU+BJlrtCMLNt5NcyfdgBHWTZ80zeX9dt7rneQY32zwlm2PuXbFR7BH/H?=
 =?us-ascii?Q?0UpX94dE7qUdshXY6QLodPnDiuvkRcFYSKahA7imGhY4ez8e/fj3w6XP8UWK?=
 =?us-ascii?Q?AHgsSzBuaLjc8LJLrFJtUeG1FkHubvjD2qsi5lRzANqV3vO50Vj3SbWC9i2h?=
 =?us-ascii?Q?s/vGGYQ41umjSRoLPOB5NvPc17WCKI7VFWEThJRQSsc7ZWNeqokEd9Jby4Ua?=
 =?us-ascii?Q?qIDecNHLT8mEnSSvEmW2YDXDULybHQXohjBg8R8ILe672Rb8QSKL7BW2aSbI?=
 =?us-ascii?Q?rtTp9xwU3KLW+u3lQUQ24d83zmlyD5FEQO7q31ejfDU7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a8715a3-10cf-4d81-fbc2-08daa5aeab1c
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 02:18:04.1135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JWgH0xs7yB4gmg69R6RaMBJcUBBPTd1WTveezzBZD2i8Xh2NaSorh54J3QVJfifZyxhANbuCk2hKf9EelpT5PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6006
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 04, 2022 at 07:58:14AM +0900, J. R. Okajima wrote:
> Al Viro:
> > Argh....  Try this:
> >
> > fix coredump breakage caused by badly tested "[coredump] don't use __kernel_write() on kmap_local_page()"
> 
> Thanx, it passed my local test.

My mess up too.  I thought I had tested this when I had tested the
kmap_to_page() fix.

:-(

This works for me too now that I have my git trees straight.

Sorry.
Ira

> 
> 
> > * fix for problem that occurs on rather uncommon setups (and hadn't
> > been observed in the wild) sent very late in the cycle.
> 
> If the commit was merged in RC versions, I guess someone found the
> problem earlier.
> 
> 
> J. R. Okajima