Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp71006rwb; Tue, 4 Oct 2022 00:21:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM75JEqqtl2ApCrCRTxoeaNrIi4O2XxZXgz7N8c06miaCoLH1i9smS3eucAUA6lUHQi0OOXt X-Received: by 2002:a17:907:3ea7:b0:782:fe85:a2e with SMTP id hs39-20020a1709073ea700b00782fe850a2emr17870603ejc.550.1664868095815; Tue, 04 Oct 2022 00:21:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664868095; cv=none; d=google.com; s=arc-20160816; b=0PyqlRKtMrq9jr8c9BysMGJS+pWwvweK7R5XqCs5Fpq/9rKbnoO6NqcoZ5v2ITH77X lOzJ+eAXDY9CWnbA8VSn/CAQpbJmSFYSOpzhL2vLNDpjs1l4l+wF2UMEKYsbQCWLDWOI IXvFFYdfpLW+KBs6K3ibZBhaKQTLB8MRpxXKHguga5eajqdoCZYDilKIO7K0WeroZaSw HyBFUWeLwaLYuCEHh189inLWKo4AXJBSsZldaM1SJPBQeDjxBOrKyMS8McnWQBsTHKZ4 kKoghNHKl6MbdcFYKRMb70oMMspNdgPMvGQbkX364WB23Eyu46CE+b8ju8x9oDMJ2rF1 m8qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jAEhfX51bk79HNZmAskhx8y8O249VqSQLorGUrCt9VI=; b=gMzr4ntdCZh26/z8sX/w9bSb3kxFUOrfL1xUcaThq+1fMf7kV6A6qL0nbAjZh5LSvu YfzjEinpIl4EfpUUKBEiDbO3OmJKP4DEx4odzuSojzMNgRDnA4eGpLmn5qTfwPOj6tL7 pRZCPLzUcoDn5ZvMo9ewg0zdadhG2Cp8N37M9p7qWN0eOTgSWiBeMq4O002ng/Y4HhM3 1XOagyAgp/8XKR6FhRwsXSVP93eYwU8NeftXNWc6Xghh2GH/94viguN8qEQMekTjURDQ YiEMsNJSBm1U4Z6Ae/mknzGBYFHnzXlfHYIQpYdY1vR/8ZFObSFLkt6Gi73mGtz6YVN5 BcbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A1auwzx0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m29-20020a50d7dd000000b00458d1c48708si6010271edj.303.2022.10.04.00.21.10; Tue, 04 Oct 2022 00:21:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A1auwzx0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbiJDHKQ (ORCPT + 99 others); Tue, 4 Oct 2022 03:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiJDHKN (ORCPT ); Tue, 4 Oct 2022 03:10:13 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71CA81658D for ; Tue, 4 Oct 2022 00:10:12 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id e18so17576183edj.3 for ; Tue, 04 Oct 2022 00:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jAEhfX51bk79HNZmAskhx8y8O249VqSQLorGUrCt9VI=; b=A1auwzx0uLK8UKHFdIApRlLeNu3gD+H4KIUo7baJve+uy+94IrQBWpymUVmcMcs52z doE1PqANnuZNcCQ4dHVf6WQOMFD5n/MlN8FPTXq/km0h+FSiwnBGYelG0iwAe3rjC9wB 63OP6WbW63KTMSHzzWzVNbVAMpo6LXZFNlMvff0torOxIOJvOrhZ0YQJmH90vzqOmdgO ycV8i2AP9amN/nr5RjWwabltRy9yn91i93oqrk9aIL6Ncxwrhxef+ewXKQbb5lUItFTk cPWPrnQoVO0R4sugC8SKvKdxO4USMCmwvS2IpXxU9Cf2fC5iHCrwvRXVSo9ZIVi3NN/O AXjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jAEhfX51bk79HNZmAskhx8y8O249VqSQLorGUrCt9VI=; b=KVD6EZf4gUkMP5VErLv6k93LKr/VWOKtm4DGDx/3YZ9IOONlXe9ZVokPMLVNUUjQof 2SBsmoBiSJ3C4M5OrkVpQP6oVcDZcvQAYS4Vza8K0O0SDaOzJp1McXJicgh1A11z0VEE eYXDs7XZBrE/z+UUmcMt8n9IqMDAjJ0J2VcYMUFZw9JUdC1YTgwPX1apHOzUbHFyJhab 6qavG5F3s/227t2vJ47opijd4Uriab8dQsmyT1iLaHOftILoSQEVS54pyi78Q3EuqEKg VsIvm9ZP+YvKjflxyXZq5a6eGRCwNC89qB5I65rh0M5lZ5vs/aFhcPzaXDt5PwSygyHZ p/MA== X-Gm-Message-State: ACrzQf1QVVdQqSDC+SNQos8GycF9nJw3H8wXAq6PAabXIifXprYYeyqm y+Ucu+ybprqs08ZKyGgmttbNryHWvkbrme+Flj3jKA== X-Received: by 2002:aa7:cd4f:0:b0:458:6077:c3ac with SMTP id v15-20020aa7cd4f000000b004586077c3acmr18719031edw.32.1664867411023; Tue, 04 Oct 2022 00:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20220917024634.1021861-1-yangyingliang@huawei.com> In-Reply-To: <20220917024634.1021861-1-yangyingliang@huawei.com> From: Linus Walleij Date: Tue, 4 Oct 2022 09:09:59 +0200 Message-ID: Subject: Re: [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe() To: Yang Yingliang , Horatiu Vultur Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 17, 2022 at 4:39 AM Yang Yingliang wrote: > Add the missing destroy_workqueue() before return from ocelot_pinctrl_probe() > in error path. > > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller") > Signed-off-by: Yang Yingliang > --- > v2: > move alloc_ordered_workqueue() after ocelot_pinctrl_register(). Horatiu does this v2 look like you want it? Reviewed-by? Yours, Linus Walleij