Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <YzSsgoVoJn4+mSpv@google.com>
In-Reply-To: <YzSsgoVoJn4+mSpv@google.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 4 Oct 2022 09:59:04 +0200
Message-ID: <CACRpkdaR8=BeA88gE8m2g1DQ=zOW6Y7S9J6=aYAVqXRwEHax+g@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: st: stop abusing of_get_named_gpio()
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Patrice Chotard <patrice.chotard@foss.st.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 28, 2022 at 10:20 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> Pin descriptions for this chip only look like standard GPIO device tree
> descriptions, while in fact they contain additional data (in excess of
> number of cells specified in description of gpio controllers). They also
> refer to only pins/gpios belonging to the driver and not to arbitrary
> gpio in the system.
>
> Because we want to stop exporting OF-specific handlers from gpiolib-of,
> let's parse the pin reference ourself instead of trying to call
> of_get_named_gpio().
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Excellent work as usual, patch applied.

Yours,
Linus Walleij