Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Oct 2022 11:11:53 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Linus Walleij <linus.walleij@linaro.org>
CC:     Yang Yingliang <yangyingliang@huawei.com>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <p.zabel@pengutronix.de>
Subject: Re: [PATCH -next v2 1/2] pinctrl: ocelot: add missing
 destroy_workqueue() in error path in ocelot_pinctrl_probe()
Message-ID: <20221004091153.eag6watgujngeows@soft-dev3-1.localhost>
References: <20220917024634.1021861-1-yangyingliang@huawei.com>
 <CACRpkdZdv2ATT8yTGKomXAUq5Pnkcex3Az4prVQVv87BTPs=CQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <CACRpkdZdv2ATT8yTGKomXAUq5Pnkcex3Az4prVQVv87BTPs=CQ@mail.gmail.com>
Precedence: bulk

The 10/04/2022 09:09, Linus Walleij wrote:

Hi Linus,

> 
> On Sat, Sep 17, 2022 at 4:39 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
> 
> > Add the missing destroy_workqueue() before return from ocelot_pinctrl_probe()
> > in error path.
> >
> > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller")
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> > v2:
> >   move alloc_ordered_workqueue() after ocelot_pinctrl_register().
> 
> Horatiu does this v2 look like you want it? Reviewed-by?

I have noticed that Yang has sent another version (v3)[1] where he makes
uses of devm_add_action_or_reset.

[1] https://lore.kernel.org/all/20220925021258.1492905-1-yangyingliang@huawei.com/T/

> 
> Yours,
> Linus Walleij

-- 
/Horatiu