Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Oct 2022 11:25:56 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Prashant Malani <pmalani@chromium.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 1/5] device property: Keep dev_fwnode() and
 dev_fwnode_const() separate
Message-ID: <YzvuFBo5Vd6S4QoO@smile.fi.intel.com>
References: <YzQqcFZtJn90URrJ@kroah.com>
 <Yzb9nXSxvgJ+Mj6z@paasikivi.fi.intel.com>
 <YzcAh/xtqQM1Qin4@kroah.com>
 <YzrBO2m/b1MHuKny@paasikivi.fi.intel.com>
 <Yzr6r5XtmPXCoQx7@kroah.com>
 <YzsLDUhjDCCVRy2G@kroah.com>
 <YztBWlmdgylsntgM@paasikivi.fi.intel.com>
 <Yzvm6XF0Ar35XZvT@kroah.com>
 <YzvrVoJ3BBhZmaZT@smile.fi.intel.com>
 <YzvtrXlv5X0LHAxa@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzvtrXlv5X0LHAxa@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 04, 2022 at 10:24:13AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 04, 2022 at 11:14:14AM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 04, 2022 at 09:55:21AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Oct 03, 2022 at 08:08:58PM +0000, Sakari Ailus wrote:
> > > > On Mon, Oct 03, 2022 at 06:17:17PM +0200, Greg Kroah-Hartman wrote:

...

> > > > #define kobj_to_dev(kobj)						\
> > > > 	(_Generic((kobj),						\
> > > > 		  const struct kobject *: __kobj_to_dev_const,		\
> > > > 		  struct kobject *: __kobj_to_dev)(kobj))
> > > 
> > > Ah, doh!  I had the (kobj) part in the wrong place, thanks for that
> > > fix...
> > > 
> > > Ok, this looks better, let me see how well the build breaks with some of
> > > these changes
> > 
> > I believe I can rewrite my patch like this and then it will be much nicer since
> > we may constify all the rest without calling __dev_fwnode_const() directly.
> > 
> > Are you agree?
> 
> Yes, I think this is a much better option, try it and see.  Below is the
> patch I'm running through my build systems at the moment, feel free to
> copy the style for your change as well.

Yep, thanks for sharing!

-- 
With Best Regards,
Andy Shevchenko