Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <699e33a2-9498-9a84-47c9-419c952e75cf@collabora.com>
Date:   Tue, 4 Oct 2022 11:49:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] media: platform: mtk-mdp3: remove unused
 VIDEO_MEDIATEK_VPU config
Content-Language: en-US
To:     Moudy Ho <moudy.ho@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
References: <20221004023727.28946-1-moudy.ho@mediatek.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20221004023727.28946-1-moudy.ho@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 04/10/22 04:37, Moudy Ho ha scritto:
> Since remoteproc completely replaces the VPU in MDP3, unused config
> should be removed to avoid compilation warnings reported on i386 or x86_64.
> 

MTK_SCP replaces VIDEO_MEDIATEK_VPU... but your description is not wrong, anyway.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> Warning messages:
>      WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU
>            Depends on [n]: MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y]
>          && MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] &&
>          VIDEO_DEV [=y] && (ARCH_MEDIATEK || COMPILE_TEST [=y])
>            Selected by [y]:
>            - VIDEO_MEDIATEK_MDP3 [=y] && MEDIA_SUPPORT [=y] &&
>          MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] &&
>          (MTK_IOMMU [=n] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] &&
>          (ARCH_MEDIATEK || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC
>          [=y]
> 
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
>   drivers/media/platform/mediatek/mdp3/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mediatek/mdp3/Kconfig b/drivers/media/platform/mediatek/mdp3/Kconfig
> index 50ae07b75b5f..846e759a8f6a 100644
> --- a/drivers/media/platform/mediatek/mdp3/Kconfig
> +++ b/drivers/media/platform/mediatek/mdp3/Kconfig
> @@ -9,7 +9,6 @@ config VIDEO_MEDIATEK_MDP3
>   	select VIDEOBUF2_DMA_CONTIG
>   	select V4L2_MEM2MEM_DEV
>   	select MTK_MMSYS
> -	select VIDEO_MEDIATEK_VPU
>   	select MTK_CMDQ
>   	select MTK_SCP
>   	default n
>