Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <122af5c891fcc65fb6179ec53a89374daa4600aa.camel@redhat.com>
Subject: Re: [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in
 IPv6 sk->sk_destruct().
From:   Paolo Abeni <pabeni@redhat.com>
To:     Kuniyuki Iwashima <kuniyu@amazon.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        David Ahern <dsahern@kernel.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc:     Kuniyuki Iwashima <kuni1840@gmail.com>, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
        Vladislav Yasevich <vyasevic@redhat.com>
Date:   Tue, 04 Oct 2022 12:21:20 +0200
In-Reply-To: <20221003154425.49458-4-kuniyu@amazon.com>
References: <20221003154425.49458-1-kuniyu@amazon.com>
         <20221003154425.49458-4-kuniyu@amazon.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

On Mon, 2022-10-03 at 08:44 -0700, Kuniyuki Iwashima wrote:
[...]
> @@ -1723,7 +1736,7 @@ struct proto udpv6_prot = {
>  	.connect		= ip6_datagram_connect,
>  	.disconnect		= udp_disconnect,
>  	.ioctl			= udp_ioctl,
> -	.init			= udp_init_sock,
> +	.init			= udpv6_init_sock,
>  	.destroy		= udpv6_destroy_sock,
>  	.setsockopt		= udpv6_setsockopt,
>  	.getsockopt		= udpv6_getsockopt,

It looks like even UDPv6 lite can be ADDRFORMed to ipv4, so I guess we
need a similar chunk for udplitev6_prot? With that we can unexport 
udp_init_sock, I guess.

Thanks,

Paolo