Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp323590rwb; Tue, 4 Oct 2022 04:43:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7hBVb8r87MkRqTsMApI/oFoxi2fTm/2BZAKCcKph7yMnxHeDV746RdIixoaJhVpTj7VGdU X-Received: by 2002:a05:6402:2989:b0:44e:90d0:b9ff with SMTP id eq9-20020a056402298900b0044e90d0b9ffmr22782704edb.110.1664883833043; Tue, 04 Oct 2022 04:43:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664883833; cv=none; d=google.com; s=arc-20160816; b=tRbZwAmwf/gMnS7xQ1jiJph0jkrYW+ntHKBINU7hzODx5GuECLX+izF63wT3H5+B+N YVJvFZF58qJiq8LPSazoOI7Lfjqso9i63EFyf1dSjyw6QT9zjdqqmch5py5ib1PrwT/o EeAX84nuHATvSCTJOBPyeMMjLThpyIZxlCXPWqeYc92KXsmItlfod9i1kQ/lcf7qbHBi STisk07CzkqsOYiuLjE6xH8V6wTdsvRn53Ue/E4jx7hoctjj18RXMhiobxeggekEHH0z y8JaNuOCigH5dsA420pqzUbqD1si+wocaGJ0bluoprTRtiAN/+oWinvoSHfY6whiwsLR azCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :to:content-language:subject:cc:user-agent:mime-version:date :message-id:from:dkim-signature; bh=gnepkY0TgZKqop1C+S4YBSp9YXD3uP2dxXvg2KODGSM=; b=Fb2bK/CMwp9oYD7TYU7l6zwNoKH6MFk1A2JYrWnHLGYZURPOewBbXiCga1OrCD6fhg BOVwuWUiCCEuFxWhJDr5w7RUB9ZRrnNz63h0f5TV/GRx9wC8jfeWYCoCQ0Fyu5jKZ0J+ sOsuAB9MxWBVDjkrwmtGcqZpko9K2tp47gcq2BDdWgQu56x4g1dGeOeHid+QHWlrz04d b3SYufxkhKK3HCt0fTKahYRT4ZjonDEBXJZoW1YSRv/EjnropCm92jjJ7RX0B6Nev0R3 jzTDeZ6uTFf/HsEz4twJeHG2yAWldj8vPK5uyOJaIAzbB+2UjNmt13G9XZqoFbtly3Qk ggCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EGwsTaVy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy9-20020a170906fe0900b0078b34df632asi5859133ejb.488.2022.10.04.04.43.28; Tue, 04 Oct 2022 04:43:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EGwsTaVy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229517AbiJDLSg (ORCPT + 99 others); Tue, 4 Oct 2022 07:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiJDLSe (ORCPT ); Tue, 4 Oct 2022 07:18:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9598B27B17 for ; Tue, 4 Oct 2022 04:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gnepkY0TgZKqop1C+S4YBSp9YXD3uP2dxXvg2KODGSM=; b=EGwsTaVyTagGMsaoZEeli9lMdU1nwI0XEND8uBLdr4FnmC9KX+Uf4HaIewdF3lALXMaBoR McVMzeHNPMGet/0oweAvYb2HQIbkwRkYk+pfMxXdYARFNrGJm2zxx099evlhUSDAidHEBk jJRztIkdJHPUH8YNJhJP+xj1WWcEc9s= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-571-6c_IAEeTOmmx5xtOxlnNyA-1; Tue, 04 Oct 2022 07:18:30 -0400 X-MC-Unique: 6c_IAEeTOmmx5xtOxlnNyA-1 Received: by mail-ed1-f71.google.com with SMTP id dz21-20020a0564021d5500b0045217702048so10741821edb.5 for ; Tue, 04 Oct 2022 04:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=gnepkY0TgZKqop1C+S4YBSp9YXD3uP2dxXvg2KODGSM=; b=epPFDFbtiDBA6k7IUCc+eL66EsEf6qCe0gsoILKNmTdRTy+NQ4CplwMn78o+1QNXjL r0cXjY6uR8ccx7cdd5QREfoYvumSWIfRiNvaQ1saOzsyftqSTaLQS259DomEymnIhmSX HD74JstO/Lr/+jg4rLgGQYzNbXUGDJmiUNex8H8yFyZgbcU91sf4fdsnJfDxrxTHWBmn wofMVTYFuhzABQ/qm9EQ4vGQyjOfJVvS1gURPrO7Q199a2Vq6ttLhDjxss1apIjnAReN DfLEZEudtOkKpkyCvtbOdpG46Fk9vOIr+ibMD4VlVBtAJ+iLTDWwZVNRZ3rApYMougtA o3Hw== X-Gm-Message-State: ACrzQf21yeI9Q/AE5uFbnUsNQQNGFo8lWMVbRI8l9jT/rutWIYeMPgLq cKsxJKs3R+AhWlmuNvZPTZeOiurUDHnVUAZbsiqQyYoCZsre4PfJKklOJbpIbjR3eNu3ikUZp5X tO+Qk2K4lhrMObBThMZ+H+Yh7 X-Received: by 2002:a05:6402:90a:b0:458:ca4d:a2f8 with SMTP id g10-20020a056402090a00b00458ca4da2f8mr12409296edz.230.1664882309712; Tue, 04 Oct 2022 04:18:29 -0700 (PDT) X-Received: by 2002:a05:6402:90a:b0:458:ca4d:a2f8 with SMTP id g10-20020a056402090a00b00458ca4da2f8mr12409263edz.230.1664882309499; Tue, 04 Oct 2022 04:18:29 -0700 (PDT) Received: from [192.168.41.81] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id g2-20020a17090604c200b0073d7bef38e3sm6839369eja.45.2022.10.04.04.18.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 04:18:28 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <850048b2-ec8b-26db-6ea7-92ed30aab207@redhat.com> Date: Tue, 4 Oct 2022 13:18:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Cc: brouer@redhat.com, "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wei Fang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Ilias Apalodimas Subject: Re: [PATCH v2 1/1] net: fec: using page pool to manage RX buffers Content-Language: en-US To: Jakub Kicinski , Shenwei Wang References: <20220930204427.1299077-1-shenwei.wang@nxp.com> <20221003165157.2bbdae26@kernel.org> In-Reply-To: <20221003165157.2bbdae26@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2022 01.51, Jakub Kicinski wrote: > On Fri, 30 Sep 2022 15:44:27 -0500 Shenwei Wang wrote: >> This patch optimizes the RX buffer management by using the page >> pool. The purpose for this change is to prepare for the following >> XDP support. The current driver uses one frame per page for easy >> management. > > I believe this has been applied as: > > commit 95698ff6177b ("net: fec: using page pool to manage RX buffers") > > to net-next. Thanks! > Sorry, that I was not quick enough to review and ACK this patch. I just went over it quickly and the page_pool adding LGTM, so: Acked-by: Jesper Dangaard Brouer