Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp329802rwb; Tue, 4 Oct 2022 04:50:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6sZowkbagc4PMCytsOTGMIvpN6MnzxIXdbrBUJ5a8i77tAtEt4H0womggrcydwtuqTc7AG X-Received: by 2002:a05:6402:2489:b0:454:11de:7698 with SMTP id q9-20020a056402248900b0045411de7698mr23651967eda.214.1664884202627; Tue, 04 Oct 2022 04:50:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664884202; cv=none; d=google.com; s=arc-20160816; b=fRVaUwm3J4J3dFPdl88fzdgx/yD6pVvua+Rkl6eSRrucszqM87FdxiPrmCvzjL1VIG Hm5zJi4yi6n4vjrPZYzKvAqDlYbcNizKm3R/4lCbXp2Gf8S+GqrQdzWFFILLQtP67X8p GqKgnrnzeb+o76L7vBPNHrlILTvrdIrAiFoD4JmpNBr4ZlGVv8DcLOJk7xdSKqelafTp +8vPNG9I74F7RGhqHE1fHLhOOhDRoYxRw7XBdISmEk0gyMN88mJu5nsQNrQ7Bxbd/O2K VmvFN2JHnMPGdM5iGFx5Hk7WMed9aSt66kPt6hZCCJqB2rCDkr7eNALHAniJvlUtsuf+ QXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=TAa2P5YN5IAQwMyOm98htsEU7M7i2qkahMy6rH6LAkc=; b=XWCeKi73sT+qkGYKGir8Bp3RNAcPQWMG19W1jHZyK3cqkoAhGUcF7Fr5R7zdB18fyG tW558sFBWFzHD2H55Z/2BUvbZuRJFa8OFQTvRj11MAPee6txWWO1B1wgYPjquiBHa6or KHRs0TaVzraMAFkRVsE6CNKAkv5JfUJw2kTPVOHVh/QBtE+kmZjfv7HHYwKLFRE3zNA2 zrMR3dGGSiK8r1s014uMdfvGjR1WvCXzhg67+1gwe1XIo7oHaOzgoVMP3cu+7n+EHNSU mm7lPKDiFm8V1eg8Ipv7XpWR7uPvAyKO+1adKDoq835Qw+SZD8e6SxwAF+j0JLzBiM10 3mxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FfK6gHFL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf42-20020a1709077f2a00b0078262e3839esi12015885ejc.27.2022.10.04.04.49.37; Tue, 04 Oct 2022 04:50:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FfK6gHFL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbiJDLWd (ORCPT + 99 others); Tue, 4 Oct 2022 07:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbiJDLW1 (ORCPT ); Tue, 4 Oct 2022 07:22:27 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 675A829374; Tue, 4 Oct 2022 04:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664882546; x=1696418546; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=zV6XaQw7cFV+W0fZ4qt53I+U/j7E5pxnhTY/GN5mI2c=; b=FfK6gHFLfqWK3EtfEhy4oTNPvVUHY29mC98YH+DJGoZrm/DVRRyojCS7 jywZSSVVuSumK20I57wTlhtS+qKbm2yyYTBrT6cd/cQyNbCIYk7MQoTfl cC+/LqtkQAhhDSR17OvjPZpTH41hIqQFsy8tVqUcWAOvaTJ66I/g1RE+N VCeU9D482MsWUm9AqlhX9o7ibjxzeGi56lDO4VstZsXG4ms9xxVcUZnG6 MOPKN5c9HTkirEMrPM2olxWW0iGedRVo4Waar5fDf1vVWJ8UzRg1yoqez UHAY65LUeMYPjiba1iaqjOwqYCD1kH05GKsgQZHv0P5tXiTM7vJOd66Z5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="290105399" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="290105399" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 04:22:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="654737955" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="654737955" Received: from kmreisi-mobl.ger.corp.intel.com ([10.252.39.196]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 04:22:19 -0700 Date: Tue, 4 Oct 2022 14:22:17 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: "Jiri Slaby (SUSE)" cc: Greg Kroah-Hartman , linux-serial , LKML , Russell King , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, =?ISO-8859-15?Q?Pali_Roh=E1r?= , Kevin Cernekee , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 3/3] tty: serial: use uart_port_tx_limited() In-Reply-To: <20221004104927.14361-4-jirislaby@kernel.org> Message-ID: References: <20221004104927.14361-1-jirislaby@kernel.org> <20221004104927.14361-4-jirislaby@kernel.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2081053952-1664882543=:1585" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2081053952-1664882543=:1585 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 4 Oct 2022, Jiri Slaby (SUSE) wrote: > uart_port_tx_limited() is a new helper to send characters to the device. > Use it in these drivers. > > mux.c also needs to define tx_done(). But I'm not sure if the driver > really wants to wait for all the characters to dismiss from the HW fifo > at this code point. Hence I marked this as FIXME. > > Cc: Russell King > Cc: Florian Fainelli > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" > Cc: Kevin Cernekee > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Orson Zhai > Cc: Baolin Wang > Cc: Chunyan Zhang > Cc: Patrice Chotard > Cc: linux-riscv@lists.infradead.org > Signed-off-by: Jiri Slaby (SUSE) Perhaps you missed this one in the earlier mail. ...Anyway, here it's again: Reviewed-by: Ilpo Järvinen -- i. --8323329-2081053952-1664882543=:1585--