Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Oct 2022 16:37:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Xiaoke Wang <xkernel.wang@foxmail.com>
Cc:     "Larry.Finger" <Larry.Finger@lwfinger.net>,
        "florian.c.schilhabel" <florian.c.schilhabel@googlemail.com>,
        gregkh <gregkh@linuxfoundation.org>,
        linux-staging <linux-staging@lists.linux.dev>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: rtl8712: fix potential memory leak in
 _r8712_init_xmit_priv()
Message-ID: <Yzw3G8rPsW1TMhPW@kadam>
References: <tencent_FACCCAB91E1C6F141FE1CA4AC1FF2420DA08@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_FACCCAB91E1C6F141FE1CA4AC1FF2420DA08@qq.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PiooTI/7Zc+SLrwvUB6ECAV0XKMyrKJu9qUBrAccvLxMZl7En2PE0Bffnqt3?=
 =?us-ascii?Q?luQJOi0lV/gdCCTb9LfVVibkftViKiePwXOvkphQKn2CyUMnFrkkRpIpA35S?=
 =?us-ascii?Q?XMofdrCOk94sXrtXgl1jkGNheAyHL1sWmR1bLTpKOchfgxNEhKcbANXuR6tm?=
 =?us-ascii?Q?nXgV7yMMIsesk0fEUYUs9fMX0OhvKMWrfTUo0KbEe8LLWXGMouC5pWzB8t0i?=
 =?us-ascii?Q?+7dqClTBV0hXfVKBV8lVjt5JGoIpVN3wKxwZaYDbjti6o0xY+ouqwkI3hdUh?=
 =?us-ascii?Q?iHTaaXSpjKiW9vYmd+AHtXHKMACWA8VwpdFEMdbX0glzDuI9C56KneQS9Wi1?=
 =?us-ascii?Q?ug+XkJBw2ll5oevr+vmJHEV3baSFELz5Yv9IHmuSeOZIqE0kqTp2Dpq4DTfF?=
 =?us-ascii?Q?2bubNVj66RV8wUvubiTNmY3IVitElBduI3ATIEeplN0mKv25wxgneWVgJjFC?=
 =?us-ascii?Q?Ojdc1QJpC80uL8Z3q/AilAI9rfwVEQxQz6UiQzeWPuFZJPzZ1TYfvcON3QvT?=
 =?us-ascii?Q?wQKSNrcK2g0UjnBR/CHzgAbfAhnYjKA9Inso5e4SxTgBRchP5dDdfAg8RF0P?=
 =?us-ascii?Q?kjreh19fbaLQQ6qJ1WrymiLgQOq7lZuesLflkCeJ3wttU2tAwshCEibAUgGc?=
 =?us-ascii?Q?DS3sa9/UIbcuOLe2H1wanPMUNLzAmhH0W6Sfdn/Kz+PlfI62NBt3iUUcnGKw?=
 =?us-ascii?Q?D6ySRGY5e4Z4NJakVJ0umf2uNB1TcbVtqlZZXhbDXwhrXoezQ81JqeA6d+0s?=
 =?us-ascii?Q?SkzxgCb0UI6Wbd6OOkHSC9ujb5Q3K2HUL2chDA7gtuKvLpWXq0h2IlJqfFCu?=
 =?us-ascii?Q?2jfScQiQR22tngiPJG+XS2uWsf/42KTDLTaVeJyt2cMc2v6uAqrIlTghrWPc?=
 =?us-ascii?Q?PP2E3xeEbhMtM3gPBo/AzQbW/dQObK15Mv0f5vYCeKVZ8/KwTHe0SsnlHZUp?=
 =?us-ascii?Q?p4w1bBpzWAWKriexF624O8I1yzn0D4n5kTt6RSKzkhUypWapsysITL9HHTXv?=
 =?us-ascii?Q?lIwyAek93euyAp/1h0xV1do2xVp3KWMByklYC5jpBd+TtHYdnYJyR6R17ed1?=
 =?us-ascii?Q?8yR/lBTJIzOoCqPfPXpN14aI8sEQYY/b7Qh7M4kYL8lHMhEn5zxEUktlDhis?=
 =?us-ascii?Q?8AJcuR8HefJI+XWCTiGXkXD4+lWHq+iPIWMb9JGM0lZIcitxw+nnjM2QjoEq?=
 =?us-ascii?Q?73UgJPrmpcv4xAEvffrKthLhLnvSJbs8qCn3Yi+HGNtgWg5J1eGxN6KT0YUi?=
 =?us-ascii?Q?9lmf2CA6P4NGkOIJCOU7dBQuebxrjUgQE+unEUzFMIVkstW9hJ2+e4aArLiH?=
 =?us-ascii?Q?s6CUKFygVHKSaZ2D148Gc7sMuk1FdK41gZo6QooD1MrfLmBVcmAEyc6EY7Nn?=
 =?us-ascii?Q?xMnBTZid2Rh+oRc/Y8EVPMoasm+whx+hu0S9s2cssTpP5XVqhfVHfwvBuy+K?=
 =?us-ascii?Q?nyipwGfLZMPn6bd7DT6f6VemruurTFFy0x+y8OuFmAW7CaLk0Ej6SCxUAcH6?=
 =?us-ascii?Q?imj02dJzjRcCUdthJnN+unI3nxCrVA7akubT2801euxVYmjNPT1OlrpC9RlS?=
 =?us-ascii?Q?7jKhkJ+phbg4lrn3/ICpSAvCdcKPMUFEGNMgwUjLVtcTc7P0l8b7rvmp/m7t?=
 =?us-ascii?Q?4w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34fd01c8-6a0d-4e13-20e5-08daa60d9a27
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:37:37.9262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HvtZGNx9JBOV5Hcytpg3NDaZrR+jnPLx98yESO2gFi9OCEfu17TiaT1ynNc+D4aNjRf3V5aR5adIax75FP89PWf75wacHWTkwUNuvtMCsks=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5633
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-04_06,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 suspectscore=0 mlxlogscore=844 mlxscore=0 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210040088
X-Proofpoint-GUID: 62yS8A6lVl0rWqpqyOzPm_48cwDEzGd7
X-Proofpoint-ORIG-GUID: 62yS8A6lVl0rWqpqyOzPm_48cwDEzGd7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2022 at 08:55:08PM +0800, Xiaoke Wang wrote:
> 
> Yes, the memory address is still on the list, and at the above position of
> `Note`, the address of `pxmitpriv-&gt;pallocated_frame_buf` is also left on a
> list named `pxmitpriv-&gt;free_xmit_queue`.
> However, these lists are in `pxmitpriv` and this function is for
> initializing `pxmitpriv`. When this function fails, the probe function of
> this driver will finally fail. So I guess the list in `pxmitpriv` will not
> be accessed.

Sorry for the delayed response.  I think you are right.  This patch is
fine then.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter