Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp484581rwb; Tue, 4 Oct 2022 06:47:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7q0f9Nmo4pTD4sXsSlAu23cF/JBgT6KGnc0AGnKJHQkz4raSGqjuc2vQJQgMniTM89VwdX X-Received: by 2002:a17:907:2d8b:b0:781:c864:fffd with SMTP id gt11-20020a1709072d8b00b00781c864fffdmr18661390ejc.681.1664891254485; Tue, 04 Oct 2022 06:47:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664891254; cv=none; d=google.com; s=arc-20160816; b=YWXiE1v7mLrFtAA9GJavioUpaxPqPjOiQgsKMYqNvn8Ohsl/RE7PLZA42v/Dy0q6zz qsL7XBKxIvTwGN1weHOPrjUbptuT93+cCRl3p/RGNEfDE2UloWb6EpE8NNgKTxFCI+Il ov4ANt6HCLF7k2sTA+Um+gIesoPQjC58zszLZghdr81OIJ9h1UCE7mpb2hFBnYbGL7Sm gaZiAglblsbk4RtmN3YiMBa8Q8GvKwcHgofgyU4cDANAe0fY8UzU6ybZ0hWuLfBQRTEg pp2XlWGVLNUGjUb9RuyN4rgPoiqspbkTOICddUtbutRgZ6A0swqYgqj4ez8SFvhrwUF5 TE2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=Q2hm5FhkKiG+2OeYnuTfk6I4vztKMNId21nMRWPhs/M=; b=iB/LkfXSYsJvx2ei9KSsNMN6mCuUWIc/qSA0qS0Ejan5rSxpbFn/4TCLr7EJljjBXs MgkzhP9p260hLe2I7qyMGxOxWvPzXXBX5qf0OPGNqGOopUqtLMb8DQ3dyRXxVLmmbq1L s5iz7TmieC5S5bZDz/YhnAEB5RsrvlT8gIs4IlQ1YRlvlHutvYyBK4jq3hpFrarAaZlT UCA9IxJbCJ1Z8MmaJSMaG2qeCjHOZPQKrOHCFt/bqUukyT9KLR5qbSL+7E5tq1SnVwvN iT7qxbPwRrZKjNEVRFota0iOcnSvuvt3DNY9lUTdDJouqT5fc46NHst0hEAcaWn0Y/do LMRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a50a6cb000000b004577e83ea3dsi10482381edc.482.2022.10.04.06.47.09; Tue, 04 Oct 2022 06:47:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbiJDNjU (ORCPT + 99 others); Tue, 4 Oct 2022 09:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbiJDNiz (ORCPT ); Tue, 4 Oct 2022 09:38:55 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E368250539; Tue, 4 Oct 2022 06:38:54 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Mhf1R664Kz4xH2; Wed, 5 Oct 2022 00:38:51 +1100 (AEDT) From: Michael Ellerman To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Jonathan Corbet , Baoquan He , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Ingo Molnar , linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, Andrew Morton , Michael Ellerman , Jani Nikula , Vivek Goyal , Dave Young , Linus Torvalds , Joe Perches , Nicholas Piggin , David Laight , linux-mm@kvack.org, Christophe Leroy In-Reply-To: <20220920122302.99195-1-david@redhat.com> References: <20220920122302.99195-1-david@redhat.com> Subject: Re: (subset) [PATCH v1 0/3] coding-style.rst: document BUG() and WARN() rules Message-Id: <166488986181.779920.10714540040506715558.b4-ty@ellerman.id.au> Date: Wed, 05 Oct 2022 00:24:21 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 14:22:59 +0200, David Hildenbrand wrote: > As it seems to be rather unclear if/when to use BUG(), BUG_ON(), > VM_BUG_ON(), WARN_ON_ONCE(), ... let's try to document the result of a > recent discussion. > > Details can be found in patch #1. > > RFC -> v1: > * "coding-style.rst: document BUG() and WARN() rules ("do not crash the > kernel")" > -> Rephrase/extend according to John > -> Add some details regarding the use of panic() > * powerpc/prom_init: drop PROM_BUG() > -> Added > * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants" > -> Warn on more variants > > [...] Patch 2 applied to powerpc/next. [2/3] powerpc/prom_init: drop PROM_BUG() https://git.kernel.org/powerpc/c/c4167aec98524fa4511b3222303a758b532b6009 cheers