Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Oct 2022 16:10:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     v9fs-developer@lists.sourceforge.net, linux_oss@crudebyte.com,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        Dominique Martinet <asmadeus@codewreck.org>,
        syzbot+67d13108d855f451cafc@syzkaller.appspotmail.com,
        davem@davemloft.net, edumazet@google.com, ericvh@gmail.com,
        kuba@kernel.org, lucho@ionkov.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "9p: p9_client_create: use p9_client_destroy
 on failure"
Message-ID: <Yzww1LRLIE+It6J8@kadam>
References: <cover.1664442592.git.leonro@nvidia.com>
 <024537aa138893c838d9cacc2e24f311c1e83d25.1664442592.git.leonro@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <024537aa138893c838d9cacc2e24f311c1e83d25.1664442592.git.leonro@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hC6/PhX+ni0OI4i7EKV0hRd0+kTzqWNKgyTY86sIQzRjSzLkiDxpo6iJ5NmZ?=
 =?us-ascii?Q?HhC8DpppJYjunBD0iu5NWAWSFqjxlToNAziO6yO+mBikhf0DPuFB+1Fd76IN?=
 =?us-ascii?Q?I656uhtsMtn566LvV8mtQPTGyS8Gyf3zhtYQx+a+3YhegB/vvBBXAMjAkCwE?=
 =?us-ascii?Q?N4TacPvly1/1b9+OqDF84lXafMoCQygjqHNrJTLYCIZcaSIOra9QLzCdhKxN?=
 =?us-ascii?Q?SL3scpcroeF1afSvVBOabVznfdXviDAKa8Y+Q1tZeuY4PDra68TXE1Dezd6F?=
 =?us-ascii?Q?8pnEL5dP8LFYR1Bngp7fZAGPpcZ41cZNTbdwCO/lgb4kM18sZsEg9lbr4vdM?=
 =?us-ascii?Q?Fh6qWnX3BS5ttjDGB4vniZeNH9hPDbg5uk6Da9b0VnhJp9OQtr07vbkPnXix?=
 =?us-ascii?Q?Q5jXuHahnWoMdJqw7VVW+Z1V8RzI6JHpixWxrZdFeP9TnY/Gt21C8iEQLBu5?=
 =?us-ascii?Q?GGjVVCKUgE3EO/NB/6Yj8/B3j0ZPJgTJnhQ6MPotwJb1HwdYLs7SRUyvRcbd?=
 =?us-ascii?Q?moWHQbBpLw6p8bcXvox5Amfo7k4H4+R3AsT9P68MrJMhwpwyqtEZWK3ZfQDw?=
 =?us-ascii?Q?SlNqpxkvO3ppN9mFSGI4yAVz3E/Je/xkv6OWjPkkIHAeFCiK02XMeA+ZU9P7?=
 =?us-ascii?Q?pr/fS7syO98mPlSXPiXlnYbvWOJOHHsdxdCOY/ltz6O9T5KlWfEUgF5JLmVo?=
 =?us-ascii?Q?Ohl1t4cHKdJmrTQt1XnHr3DSO2H2QfHofF6JZjvblFkXIXPhIJf8xrX7XgKY?=
 =?us-ascii?Q?NuI97PKNrvM1hQ7t+kBoViLnqsZMSXUaqn5G2z7uxATQB/fSrF9pd857Zq28?=
 =?us-ascii?Q?ggsxfVBnceo6qJ2zz+IJ7aHvgZvald9Xlp4NYCjQA6Vmd6QO7v5dDWB+2GQc?=
 =?us-ascii?Q?we6a35oJS8bJHzoW34OuK+8/KRFN4LoVfdohdHKaRmH92AXeQAWv3AELMewg?=
 =?us-ascii?Q?GPC4ONU6OhM1baX910wvhgfGqNdsJhfQxg7AMS90GIalRmMnv/IZmI31Waz+?=
 =?us-ascii?Q?OuAAh3xFywtSxqcrZTK8KK4wvLHQyQV1tazC2u5FnCqASGFcZGt7OfGE5v/X?=
 =?us-ascii?Q?1F0xios/tUkQRAWVI73CnnjYxyhJMl9glIVIRPYoILUWNvW3aQf/1CTh2UGk?=
 =?us-ascii?Q?MRqkZFWQmBM3eKKqFljr4xhgEOaT4yIAuqVUHLdK7bK5n/TJ6dlim70LIQuZ?=
 =?us-ascii?Q?vGeAsLTDR5WZm0u+kJ5Xuvwuu3B5PYUSp2RSxb+rNuNTFgNVcpRX81AvRDqD?=
 =?us-ascii?Q?0gokF0uCfSBFASFB1JQijpZxeB/lU01pPVCHFDjF6nZkBsyzfgzsBCpE5B4M?=
 =?us-ascii?Q?a20SkVcAsI+GIAN8baPj2nqREiO9Io9t6Bx/Vl1eo0Fa36RyOYYGWrIChqsb?=
 =?us-ascii?Q?ajev1TDVIqoTiaQGU3jazXi0DyTv11K1ZWRVjEh+/LBdT3rS7BbcY3fJnsLB?=
 =?us-ascii?Q?IpOMzMgV2RObjhtPoZDdv6vG3ZGEhJRzcp6GXZBy8+yEVqdAzV2sZj9SclOH?=
 =?us-ascii?Q?MJyOkGt6dKh4SA53ZS9NWT3YXQrcrwtvXvrgIvvONpZEi9RTFjp4evRXNZub?=
 =?us-ascii?Q?k9358uKzKffFpTxq/t5xkx1Yww5p/TaOPaqggUXuKbikHBSSYsS57K8cV8QH?=
 =?us-ascii?Q?Ew=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86650115-2223-412f-4159-08daa609dccf
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:10:55.7079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5SxQ5na+wOQuJRvt3DTR0guvlwCnUSXtS8viovRr0w8dkpe8vFW62vRMJnyZ+ZA6b+j24YEaVrtCaqHw/xIxzJmr7lhyAT/uQpvPPUWc9UY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4123
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-04_05,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxlogscore=724 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210040086
X-Proofpoint-GUID: WBQX3YDIpEM-s3vfadxag6LTpXf-mOqx
X-Proofpoint-ORIG-GUID: WBQX3YDIpEM-s3vfadxag6LTpXf-mOqx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2022 at 12:37:55PM +0300, Leon Romanovsky wrote:
> Rely on proper unwind order.
> 
> This reverts commit 3ff51294a05529d0baf6d4b2517e561d12efb9f9.
> 
> Reported-by: syzbot+67d13108d855f451cafc@syzkaller.appspotmail.com
> Signed-off-by: Leon Romanovsky <leon@kernel.org>

The commit message doesn't really say what the problem is to the user.
Is this just to make the next patch easier?

regards,
dan carpenter