Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd357565-d428-499f-fa0e-e35aa043449f@amd.com>
Date:   Tue, 4 Oct 2022 09:28:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] KVM: SVM: Fix reserved fields of struct sev_es_save_area
Content-Language: en-US
From:   Carlos Bilbao <carlos.bilbao@amd.com>
To:     tglx@linutronix.de, bp@alien8.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        venu.busireddy@oracle.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, bilbao@vt.edu
References: <986a5886-4ddc-aa88-db52-e8781ec95aed@amd.com>
In-Reply-To: <986a5886-4ddc-aa88-db52-e8781ec95aed@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNVZTBQblhJMDlkcXBMMzJCTUQxdDk0dTg2QTc4b0RidHMydkdNUWJMUWF0?=
 =?utf-8?B?ZGtYMFBBMmpHNVYyUWlObjdPem0xSW9HUW9mcDlSaTRiSlRjcDhFMjFMN1py?=
 =?utf-8?B?SjlTd2tPMGkrZW8zS0g5ako2K2k3WGRQam1yUlQ0a3lmQ3hmQVhSN2pzSWxK?=
 =?utf-8?B?K0lKS05lYTkxbFYyVkVnSHBuRW5Heno3N3hsOTNpU012NDBsQlpMQk1EZ1JQ?=
 =?utf-8?B?M2MxUGRScktlZDcxVmZTT09pY21ydmhFUmJvc0pzNUdnSmZ1Nm51TU4yWk5I?=
 =?utf-8?B?LytTVFd0V0ErNmdNN3QyTVRuaDlZSjIyTFgyamx3Q0ZsVXpNTjJaN1hseDR2?=
 =?utf-8?B?RUlBdUtyVHNsbjF2UHlIVytkUitldmNsR2lFNTM1WlpacDNmQnRHcnlCK2p4?=
 =?utf-8?B?Z3RiYkZENURnUjZGZjF2a0VMeVZZWkFyUnZuWVZiajl6RER3cEhZU0VNaTVO?=
 =?utf-8?B?YWFiRjRzeGYwYklhbEd5Rnc2Qk1xNEY3VUlka1dmeTBIblFDRStJRnNYNWxS?=
 =?utf-8?B?Qnp4ZnVoLzN4aWtnajA4ZlNPaEFqSzZ6TkRweisvWmZLWXE2NDlGaldQWUkx?=
 =?utf-8?B?NlRuaTZjSVZ0dUJWY3JteVVVSEdVcjlqK3NrNUhzMllGdU9lR3Rsa2dwTm13?=
 =?utf-8?B?VUsyM1lPSU9hbEpLSGZwdWdBWkVyRVhCNTZxbHpFYmRoejNybWcrZmo5d1lX?=
 =?utf-8?B?UkNCUXg3V0xkOTAxcklQV3R0ODFlV3piQ3dSQVF4V3ZLaHBpSDdVOXZlaUxF?=
 =?utf-8?B?SkEwVUl0YWpmMCsvdzB0a1BxMnVlS3JiSFhYT1I4RnlpM2hRRTRjd29ZV1VV?=
 =?utf-8?B?VUQ1MDB3cWh2dSt3UENwcDJMem5QOG9Ec1pSbWh3U2Z1L05ET1RLcko3MzhH?=
 =?utf-8?B?Z0RVRE9wK1lLeUdVQXJ4TGdmSWExY2YyWCtYbEFnYys3VFU5UW5DdWJlL3Rv?=
 =?utf-8?B?NE1YZmFjdERySUVMemRNdmRWaE8waFZOcVJtcUZHMVZ4WVN3RlJZYlNQbXVD?=
 =?utf-8?B?OVljLzVHZ05DQUE0V0NkUmJ6d0UzbUZSVjM4a3Q4Q25vcUR1SW1lREVucUdG?=
 =?utf-8?B?Qm9JcndYaVpWdXZqa1pGNDdXTnh1UzlHclRjTEhPOVpoUThNMDBqejJkRVpX?=
 =?utf-8?B?Y1pFRC8xWnVhcTMyTzNlWXBhaWlBZ25kdmR5RWczcFFOUVZFcGZSMjZiM1RC?=
 =?utf-8?B?eWVDd1dJcWRiVGRVYTFGTWFkV0hhekhnWDdVMCtCNGUveTMwblhxRmdhZCtY?=
 =?utf-8?B?VnB6eWhJb0ZHdm9OeHNXYmRGdmt3enR6emQzWk0vVC94dTREOFNZc0gyN0NJ?=
 =?utf-8?B?OUZVMnF0V2RFNzNZR0pBZ0FzVEM2WkNYb1dpOVM1VlAzcGtZNnVVaGhkZVFi?=
 =?utf-8?B?bGc2VEZuMVFJM0J1WHVuejNyeEgvN2lnaDJCS243MUdEWlJqRW1IMVRPS0Jn?=
 =?utf-8?B?RnJYV0RJQnBTREgvcDJhSjZYenJidGU2MTRFbUF1aTdERE9mdWE4M2RENVd5?=
 =?utf-8?B?ZGpiZ3FlYTY5dytRVVBLUHQ5V0s3eHUwQ0pMTXIzSzZBbGpTbWxLTXl5K0RR?=
 =?utf-8?B?bDJ6eFhGamRZRnJ2dHlQQjIxUVdiZWphU3N5eUFlU2NHU0w2SkcybGEvaTZY?=
 =?utf-8?B?TkllcjY3TzBVeVhVaWdqaGJjYXFLcFhISmx4eEhIbkJ1K1lFRTV6VTcwbmoy?=
 =?utf-8?B?YTZ2MVdXQW9wTGpLd0xlZEVLMFFSaHZQdW5BbmxBYlFNMlV4NjMvZThiNzB2?=
 =?utf-8?B?ekUySUN4b25zaU9aMmZtYUNRaDlGN1g3aWxCNUFFZUxOYXh5YXk3R3dKNGhr?=
 =?utf-8?B?NnI4TG9tR1FHdFZCR1lsMkFsemk2SmJpdit5RG4zY1dmS04zQ2k2MTJCdFls?=
 =?utf-8?B?N1NPOGwxRHVDNnhCNmZaZUxpUWNSNU1nMDk5ZVQ5WVV0aWtpckdibmdWa1pS?=
 =?utf-8?B?QlJyM1g5MS9NOTJ3TTRvNmw3ZEhhL1h3eElkS01qSGlSK01YTExUTllwTkRT?=
 =?utf-8?B?QkhnbjZ0R0xDa0Y1bFZzV3lZK2NmNlBJNExRK2xwZGJKNnRxemNiTDZSblpt?=
 =?utf-8?B?ZHNjN29VdFBBRWhIWEhrOFg3aFdrU3pka1RnRjNrWnY5Z2s4ZVFxM09JSWdY?=
 =?utf-8?Q?1LtF2AMxlfxGfU5SZ6c4dT1Y5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a334fa4c-5ae1-4b29-5110-08daa614b321
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 14:28:26.2627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 106j6wRtoT2RANGj8vIHLecijJvU73DI0N0jAIHNJEXgwFJQU1w6s2Kvw4K9yqaWUp8glv4w+gLGFZFMIohwMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4900
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/4/22 09:05, Carlos Bilbao wrote:

> Reserved fields of struct sev_es_save_area are named by their order of
> appearance, but right now they jump from reserved_5 to reserved_7. Rename
> them with the correct order.
>
> Fixes: 6d3b3d34e39eb ("KVM: SVM: Update the SEV-ES save area mapping")
Actually, there is no bug, so this Fix tag could go. Thanks!!
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
>  arch/x86/include/asm/svm.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> index 0361626841bc..6ab45a0389dc 100644
> --- a/arch/x86/include/asm/svm.h
> +++ b/arch/x86/include/asm/svm.h
> @@ -393,14 +393,14 @@ struct sev_es_save_area {
>      u64 br_to;
>      u64 last_excp_from;
>      u64 last_excp_to;
> -    u8 reserved_7[80];
> +    u8 reserved_6[80];
>      u32 pkru;
> -    u8 reserved_8[20];
> -    u64 reserved_9;        /* rax already available at 0x01f8 */
> +    u8 reserved_7[20];
> +    u64 reserved_8;        /* rax already available at 0x01f8 */
>      u64 rcx;
>      u64 rdx;
>      u64 rbx;
> -    u64 reserved_10;    /* rsp already available at 0x01d8 */
> +    u64 reserved_9;    /* rsp already available at 0x01d8 */
>      u64 rbp;
>      u64 rsi;
>      u64 rdi;
> @@ -412,7 +412,7 @@ struct sev_es_save_area {
>      u64 r13;
>      u64 r14;
>      u64 r15;
> -    u8 reserved_11[16];
> +    u8 reserved_10[16];
>      u64 guest_exit_info_1;
>      u64 guest_exit_info_2;
>      u64 guest_exit_int_info;
> @@ -425,7 +425,7 @@ struct sev_es_save_area {
>      u64 pcpu_id;
>      u64 event_inj;
>      u64 xcr0;
> -    u8 reserved_12[16];
> +    u8 reserved_11[16];
>
>      /* Floating point area */
>      u64 x87_dp;