Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 4 Oct 2022 07:14:54 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH 4/5] thermal/core: Move the thermal zone lock out of the
 governors
Message-ID: <20221004141454.GA1746997@roeck-us.net>
References: <20220805153834.2510142-1-daniel.lezcano@linaro.org>
 <20220805153834.2510142-4-daniel.lezcano@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220805153834.2510142-4-daniel.lezcano@linaro.org>
Precedence: bulk

On Fri, Aug 05, 2022 at 05:38:33PM +0200, Daniel Lezcano wrote:
> All the governors throttling ops are taking/releasing the lock at the
> beginning and the end of the function.
> 
> We can move the mutex to the throttling call site instead.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/thermal/gov_bang_bang.c       |  4 +---
>  drivers/thermal/gov_fair_share.c      |  4 +---
>  drivers/thermal/gov_power_allocator.c | 16 ++++++----------
>  drivers/thermal/gov_step_wise.c       |  4 +---
>  drivers/thermal/thermal_core.c        |  2 ++

This doesn't drop the lock from drivers/thermal/gov_user_space.c.
Is that on purpose ?

Thanks,
Guenter