Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 04 Oct 2022 17:19:11 +0200
From:   Frank Wunderlich <linux@fw-web.de>
To:     Rob Herring <robh@kernel.org>
CC:     linux-rockchip@lists.infradead.org,
        Frank Wunderlich <frank-w@public-files.de>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Yifeng Zhao <yifeng.zhao@rock-chips.com>,
        Johan Jonker <jbx6244@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Simon Xue <xxm@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy
User-Agent: K-9 Mail for Android
In-Reply-To: <20221004150929.GA1506199-robh@kernel.org>
References: <20220825193836.54262-1-linux@fw-web.de> <20220825193836.54262-2-linux@fw-web.de> <20221004150929.GA1506199-robh@kernel.org>
Message-ID: <EC42D2C8-ACA5-4B6A-BC95-534CBDFC36C8@fw-web.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 4=2E Oktober 2022 17:09:29 MESZ schrieb Rob Herring <robh@kernel=2Eorg>:
>On Thu, Aug 25, 2022 at 09:38:32PM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files=2Ede>

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - rockchip,rk3568-pcie3-phy
>
>The driver also has 'rockchip,rk3588-pcie3-phy'=2E Please send a fix=20
>adding it here or removing from the driver=2E Are they not compatible wit=
h=20
>each other?

Hi,

Right,
original driver has rk3588 support,but we can't test it=2E Initialization =
and lane-mapping (bifurcation) was bit different=2E So we wanted to upstrea=
m rk3568 first (but have not removed this part from driver)=2E

I see that someone added rk3588 basic support and if he can test rk3588 i =
can send compatible for it=2E


regards Frank