Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kuniyuki Iwashima <kuniyu@amazon.com>
To:     <pabeni@redhat.com>
CC:     <davem@davemloft.net>, <dsahern@kernel.org>, <edumazet@google.com>,
        <kuba@kernel.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <syzkaller-bugs@googlegroups.com>, <vyasevic@redhat.com>,
        <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
Date:   Tue, 4 Oct 2022 07:55:24 -0700
Message-ID: <20221004145524.32829-1-kuniyu@amazon.com>
In-Reply-To: <122af5c891fcc65fb6179ec53a89374daa4600aa.camel@redhat.com>
References: <122af5c891fcc65fb6179ec53a89374daa4600aa.camel@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From:   Paolo Abeni <pabeni@redhat.com>
Date:   Tue, 04 Oct 2022 12:21:20 +0200
> Hello,
> 
> On Mon, 2022-10-03 at 08:44 -0700, Kuniyuki Iwashima wrote:
> [...]
> > @@ -1723,7 +1736,7 @@ struct proto udpv6_prot = {
> >  	.connect		= ip6_datagram_connect,
> >  	.disconnect		= udp_disconnect,
> >  	.ioctl			= udp_ioctl,
> > -	.init			= udp_init_sock,
> > +	.init			= udpv6_init_sock,
> >  	.destroy		= udpv6_destroy_sock,
> >  	.setsockopt		= udpv6_setsockopt,
> >  	.getsockopt		= udpv6_getsockopt,
> 
> It looks like even UDPv6 lite can be ADDRFORMed to ipv4, so I guess we
> need a similar chunk for udplitev6_prot? With that we can unexport 
> udp_init_sock, I guess.

Good catch!
Yes, I'll add that changes in v4.
Thank you.