Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp736803rwb; Tue, 4 Oct 2022 09:57:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44zNkoO8UANCCddOf854zJoq3+4dHuP5sUInjhymszx/BLailPnI9P+61Qv4rIJDPxVJA2 X-Received: by 2002:a17:907:2672:b0:780:8bb5:25a3 with SMTP id ci18-20020a170907267200b007808bb525a3mr19966213ejc.281.1664902628932; Tue, 04 Oct 2022 09:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664902628; cv=none; d=google.com; s=arc-20160816; b=oM3jDNWN++yveV8OGGvcYTnoHhosebzF27PlVxc3baxziLwIONx852txfSqC6KCOig +Wcx/uk1DpgAxWxhrFUgU8b4/WaRBOUHHbfWn+4fCpkDFxCnzU86lDlkSsgm542Kv09N SaUUqhPmfRUtYGdtArOX1bzIhoR7JBeCFdWughFm1fyuv+8jTcPivwGHqwp7Ljz0qPys rwZCWfIxiqk2piXN+wo9Ht7IUwQjiGXpR8UjT24bwiUVCdpmkPtORZWcM80/ojpkUYee /xqFPyax5sVRKt+yG4zM3Asl7J5lNhfnpk4ctmE1P9OD/3e/5z6HSp4UBTdSF6eqSHMz wTPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=c2f/IvwYYABYZVbIQp9qWgy/qVUR3KaPTanuyp3TFpc=; b=hAFUCCnYBW2r0uUtzE48p48y5bDPoXRtyMwQyMKcGiK2+fmJtxlSGuyDKXdc1dIHtS poJmT5AJ+UIy5Z4O7XBAokmdNyJVpd/8JWDHp25g+Zfj8mAlQpIfu3WJkF+tXlVUwfcD 5m2euroWKFaG+j+l7I7O3ITQLTdJAFBErriOPq9y8ukl6pSpjwe+RKqyiOJFUNfdtoxW t9PoAJrOXAAkTt7iNUDZ8iv9zi+LxAxeRQeQOdFn4WlBeKlbwlLFNwCZdh64o6BEbSKK zRsARVdhe3WylN5G9LhqDAvsY67tiuUEGGwijo3VigmwzFz9fcLFTd+eHYa9v4oTyBi+ NuYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HusjNIHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i20-20020a17090639d400b0077cb9bc7984si9582284eje.181.2022.10.04.09.56.44; Tue, 04 Oct 2022 09:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HusjNIHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiJDQbd (ORCPT + 99 others); Tue, 4 Oct 2022 12:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbiJDQb0 (ORCPT ); Tue, 4 Oct 2022 12:31:26 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C58D2F3AE; Tue, 4 Oct 2022 09:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=c2f/IvwYYABYZVbIQp9qWgy/qVUR3KaPTanuyp3TFpc=; b=HusjNIHidkEeqrr0rB0KQc7xSz R27LxyvHHhj6CttXEnl9b+cP7vLpuTugR9/RzkaUoSu7zJqaAXdTOLkkjTqunPkmpajobgoeYO1g1 mIBFfnncOKELGw4SI5wPCEOENayis6n1E/wmlK2mrOCgggFkpyqCyPZ391JiCY0rYVMpjJP0/LIPr +43s+SedMlOv6wXUzVexG0M+neQLfTn49GNvKtCLbQgexjphS8EEzeF1U6zpRakGEDi1TeJIVdy1i MScrajHrI1KyPm62adPZEu+3s25VotezamF2GtFOKGfFdKkCgDhI9Q5hxTcEdMkcxppUNxtp+CDAu OMh+k6tg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofkpF-00ADKW-Qk; Tue, 04 Oct 2022 16:31:21 +0000 Date: Tue, 4 Oct 2022 09:31:21 -0700 From: Luis Chamberlain To: Christophe Leroy Cc: Rasmus Villemoes , "linux-modules@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] module: remove redundant module_sysfs_initialized variable Message-ID: References: <20220929121039.702873-1-linux@rasmusvillemoes.dk> <4f4a62a2-4395-420f-0a20-e84c06b8c3ed@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4f4a62a2-4395-420f-0a20-e84c06b8c3ed@csgroup.eu> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2022 at 04:35:43AM +0000, Christophe Leroy wrote: > > > Le 04/10/2022 ? 01:40, Luis Chamberlain a ?crit?: > > On Thu, Sep 29, 2022 at 02:10:39PM +0200, Rasmus Villemoes wrote: > >> The variable module_sysfs_initialized is used for checking whether > >> module_kset has been initialized. Checking module_kset itself works > >> just fine for that. > >> > >> Signed-off-by: Rasmus Villemoes > > > > Looks pretty sane to me, thanks! I'll queue this up for 6.2 > > as we didn't get a chance to spin test this for 6.1 on linux-next. > > > > Maybe you can mention that this is a leftover from commit 7405c1e15edf > ("kset: convert /sys/module to use kset_create") Sure, did that. Luis