Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <ilpo.jarvinen@linux.intel.com>
CC:     <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <andy.shevchenko@gmail.com>, <u.kleine-koenig@pengutronix.de>,
        <johan@kernel.org>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <macro@orcam.me.uk>,
        <geert+renesas@glider.be>, <jk@ozlabs.org>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485
 support to quad-uart driver.
Thread-Topic: [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485
 support to quad-uart driver.
Thread-Index: AQHY1V0xNl764Wi+W0ymRRIbNpbBhK38aB2AgAIZh1A=
Date:   Tue, 4 Oct 2022 17:51:56 +0000
Message-ID: <BN8PR11MB3668B169D079C3F9D1C3BB72E95A9@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20221001061507.3508603-1-kumaravel.thiagarajan@microchip.com>
 <20221001061507.3508603-3-kumaravel.thiagarajan@microchip.com>
 <d184aa6d-23e-edf6-4cee-f5f4ad6bf90@linux.intel.com>
In-Reply-To: <d184aa6d-23e-edf6-4cee-f5f4ad6bf90@linux.intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3TPrfErxkSmWgByuJ6+oON5g9QKRcRWlLp9g+UN0pOOXQm4QB18Zx5NgSH?=
 =?iso-8859-1?Q?DOtxKsGfbhNUQXoD9yDoTz93x05sm8d4OeaCHpYTBkk4JcFNGV7ljL5n7T?=
 =?iso-8859-1?Q?zJmcCXbL4cWirnDQBzUo5sR2/nYJcDoZqQxTjwyu6LGzNI/O0Igf5T7hTb?=
 =?iso-8859-1?Q?Bv2fz6lrOv1646ZmXDEtw5K7ZuUNVfiT71jTX2Lx2Yk2umyr4opVsIFsTI?=
 =?iso-8859-1?Q?MZvndOAUjFhrQAJdPYDllO7zIJ04586klTSBOkNgNbOd773pqkDUgp/3Tm?=
 =?iso-8859-1?Q?ku0llj2dZ54VsVqalLyKwn8LwWZPkasjFsl9HSSDsVOyIS3YiySwit//D8?=
 =?iso-8859-1?Q?7WWCKusQZ543kAr5i5PAbXBc5+lKkYRj/bVvtMOPoUYMcrWkv9SL3ujtys?=
 =?iso-8859-1?Q?z7ElCWQ8mjABe5QDEOOOMtVVQh6txFsHYhvTPrbzqH/g75x7/rRTweWg40?=
 =?iso-8859-1?Q?88BLd+loBqvdvLK3A/YgGpP8OW+oi1lYm1xMaXt5YAaSCr/AFV9RALVRE0?=
 =?iso-8859-1?Q?IERfvHUJ/VR2AiKIeILpK8+kvyPNiRh1DJUiwHBnf1vYREpah9LmIMaVzi?=
 =?iso-8859-1?Q?bsDMylGHv9hZltrxBaJtZzAexSFl3zXyvR/AF56avt/cBUudZmHbtDxm7x?=
 =?iso-8859-1?Q?Zc1btq9PUMufCxiq8/uAH0aS2nzGaMq23iE0gm5aK1EcpfvrK+WA4b9JU9?=
 =?iso-8859-1?Q?EGzvhmBO+HDiLQBhoMh9vA+ZxylWKajfC5WqWtPtp4SgxTRQ7IstIEnQQE?=
 =?iso-8859-1?Q?io5cLtsF8qBWaQABB+f6sF7d/ac4Wia8Jsm7LfmbRrfk0uwk2KUW/af+e+?=
 =?iso-8859-1?Q?XJbflPu1fNbZLeBxYmepyx5J+DFLLIUcnfUI9l/lYu2pzG5VPoOMBuP0+E?=
 =?iso-8859-1?Q?0HyOrLFgqEgIIBm0W7b03W9LjJopKz3Ddt8zAUVhwnWdtkAwQiU2KDa5g1?=
 =?iso-8859-1?Q?qwZtV/0Hi1qYjnYWi3WOHIFzPu17g1raYaQ7qZ26YPBpVMwQAbkv1iPXWo?=
 =?iso-8859-1?Q?6MTFsjw2rE9QvQFsi6MaZ/ME1MQV10t4XqfnHiGg6CzYkzltRUPFBRpHAD?=
 =?iso-8859-1?Q?yrL1Afgh5fP7ed3LijxscZ3OB/HVBxqxmlznFCrD34VJYGla+ZablYRs5k?=
 =?iso-8859-1?Q?ZSmaR28i8loxZv4ECJ/S7/FIMmWhHu7eFK51LxLpaQ+Vpg6F4S+lZAHDmK?=
 =?iso-8859-1?Q?NsVgG+A7CqI1SqiPTpLYYW2MzuSRMCfzOGG+UYndSSk0TqpkqoIq1A8F1g?=
 =?iso-8859-1?Q?ZPq358+/vJmoqj60h3t7ay+SWUajXwOaY1M3z+mJh+6wzNpB1D63PInb9p?=
 =?iso-8859-1?Q?KJZ905wK2VeBw9tNy4oAcMESm27HsZHGeR0m9dkKUOXhfAdbRFK8/g+1fd?=
 =?iso-8859-1?Q?r64MyvKeEHDMj2R9XQbqnBvqF9yusSJpb/mQvLWBZ4v8RsF3SiP3eAsFmm?=
 =?iso-8859-1?Q?dRPUYe2peJQwpxRgmsbZNI7TGLb0jLO5zVF8FX/aRPk5xqExWp50uZKF2b?=
 =?iso-8859-1?Q?nBONRBOrDwDihOSUuG9ZcVJ518FBtgtqqrgCO4qqNmZRsSCY1prNBWWGZO?=
 =?iso-8859-1?Q?dGx3sM8zuBqrMX+xVAxggi2JZYsw1kvZXHrxCYyNMXEVDULig5kho8IVZc?=
 =?iso-8859-1?Q?vcs+tfFuQiwxBd4bPIk0Ivle4jZi70uGxzBaSjlcRXfwp+3Kn84VpOsEFF?=
 =?iso-8859-1?Q?fRONVID5resKnt5NCgI=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97131f46-8ff0-4832-d73c-08daa63120f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 17:51:56.2599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rqBho3jZ1sk+XeF83L4pgLJpRxHPF6D7xyt7vusifHOMeEDG9QFW+mkPzkGCbE9gTZj/VLbHxiXQoM4CUJ3nORo6ZEcBFXpLb9+4clQ1s6pn2ELi5RT/fGxzb1x5FE1S
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7276
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Monday, October 3, 2022 2:51 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485
> support to quad-uart driver.
>=20
> On Sat, 1 Oct 2022, Kumaravel Thiagarajan wrote:
>=20
> > pci1xxxx uart supports rs485 mode of operation in the hardware with
> > auto-direction control with configurable delay for releasing RTS after
> > the transmission. This patch adds support for the rs485 mode.
> >
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@microchip.com>
> > ---
> > Changes in v2:
> > - move pci1xxxx_rs485_config to a separate patch with
> >   pci1xxxx_rs485_supported.
> > ---
> >  drivers/tty/serial/8250/8250_pci1xxxx.c | 57
> > +++++++++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_pci1xxxx.c
> > b/drivers/tty/serial/8250/8250_pci1xxxx.c
> > index 41a4b94f52b4..999e5a284266 100644
> > --- a/drivers/tty/serial/8250/8250_pci1xxxx.c
> > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> > +
> > +             if (rs485->delay_rts_after_send) {
> > +                     baud_period_in_ns =3D ((clock_div >> 8) * 16);
>=20
> Is this 16 perhaps UART_BIT_SAMPLE_CNT?
Yes. Is there any macro definition for that? I could not find any definitio=
n in the above name.

Thank You.

Regards,
Kumar