Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <ilpo.jarvinen@linux.intel.com>
CC:     <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <andy.shevchenko@gmail.com>, <u.kleine-koenig@pengutronix.de>,
        <johan@kernel.org>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <macro@orcam.me.uk>,
        <geert+renesas@glider.be>, <jk@ozlabs.org>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power
 management functions to quad-uart driver.
Thread-Topic: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power
 management functions to quad-uart driver.
Thread-Index: AQHY1V0267YcXgrzdEqBqc2LceMdk638cKmAgAImnGA=
Date:   Tue, 4 Oct 2022 19:01:19 +0000
Message-ID: <BN8PR11MB3668A5B77A0514EAD23800BCE95A9@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20221001061507.3508603-1-kumaravel.thiagarajan@microchip.com>
 <20221001061507.3508603-4-kumaravel.thiagarajan@microchip.com>
 <7892467b-c2de-c62-e977-62761dc5cbb@linux.intel.com>
In-Reply-To: <7892467b-c2de-c62-e977-62761dc5cbb@linux.intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?r703EHdYBPBklx8YFj0yqfqAWAlXiaqqy4I7Tfo/NWyCU+MJeC8tlNLD3m?=
 =?iso-8859-1?Q?WN+iy72hxOccFhk8yGzC2lFv/C/Uii9B7S2kYc1tGpfCZdphx6W9WE+mae?=
 =?iso-8859-1?Q?ccXVgYjb7qBgbasroFOAt2nSJUV7Sa2k0+VzTNUCU245CiMaMGVKxgFin6?=
 =?iso-8859-1?Q?GmoB7DHv1nO9fPDNNg9qPXzHataBN8VhUIZWO69yZEqEc69zbjeYVDxvB8?=
 =?iso-8859-1?Q?/rKM0ZWKXdV5N02yz83SnqN3W6kAcChpfBAvQzBIJPFIimInDPzMVNcBNE?=
 =?iso-8859-1?Q?y3fG8CUHg+xzka6ywTJmDMrPQH1b5PHUAv0HVODOf/uTXAMw6AW0+GwyXs?=
 =?iso-8859-1?Q?9qtMEPF3w4ul05orhJ3t/24fbip8rG3xcEUOA0GdwY44TZJ4gPB7mL3/El?=
 =?iso-8859-1?Q?MqzT7u8ElWEuQwnLhfkEzDGPfVWCHESmGsSJkc3hVUKZvYHPrBRjw0aU9c?=
 =?iso-8859-1?Q?X9/TlLTfLRMYviPwUqHgANKNHMwXjBVdxbqweyQvTzRMFwJQcnlomCD76K?=
 =?iso-8859-1?Q?Ye2Uxm3pSQ0Gv/W/PGNdrnSQyz9AI0kMh4wwotRL60l6T53Jz7x0cZnW6Y?=
 =?iso-8859-1?Q?bgbLedqrAOgnK2qkT6cZ8nmthE5MQo3ReiisTdUNBoTJNqfMHzaGG3uvX0?=
 =?iso-8859-1?Q?PvdYiwigOuWXy7k6xAEozB7exVNaQKg2qx64Pn1sBTUdhRFIDCPal7vUnf?=
 =?iso-8859-1?Q?BhXh0DvPwrdrfGqeRv7O6QYDnQfjfjRYs6Nl2qcalWjEsjj8ThW+DlqGF/?=
 =?iso-8859-1?Q?YydlY+TYCmg2a9w3ln4SotkK0oXZEvUlnSoqpklw0Q/7zmJ/MM1gDoZRXO?=
 =?iso-8859-1?Q?lluPRJKTwdVlKLkpFjIpu5wtn8kmyqKXaxhvBTsuPWmODbc6pDNgnjjbSK?=
 =?iso-8859-1?Q?U/nmBUH6fbNXX2ydagB6O/TQ+hK3vzEnUldLeeAhr1aOTJW+ulLUgZdMO8?=
 =?iso-8859-1?Q?xTLcidzjQbRQGFQLt9VSdldWgLpnKKtfKdguP7gY5d7ASgxhqqQATE5j0+?=
 =?iso-8859-1?Q?diemWcSL2y2PsD8Jp9P/iFfikPfVUsRQEcTIysnhxlE8rrsPPWZlhwhm3K?=
 =?iso-8859-1?Q?Ev3w5xVALAd+Hh12rVHpXrRSKbMIZ3z2w7vrDAhLcApdixuqjWhvufMVu9?=
 =?iso-8859-1?Q?A1ooFBTfU6jnwH6WZiRNvFwC243wvNCVvzzW8/HCQwnGhFu8z0iqoxe4+1?=
 =?iso-8859-1?Q?4ai7YZAnOJM3dC4e15rc2RPchURcUXH+5ZcaAZRTxPpYlXZi5vWMtm2IH5?=
 =?iso-8859-1?Q?H+NKFjWfEenu1po52N0o86GGn4egeEnpRFyxFVDSKf6t+kjSrx6VuJwgm9?=
 =?iso-8859-1?Q?US+FLT6tlV9bRn0pgqkXEBiEHq5ikaC8X8Po3HqXIbTwIwiLG3oOtdmaaD?=
 =?iso-8859-1?Q?vKkC/CHJISoo0hQAugXZFdcn/Fj9ZfUlZ+jdM+W2mXzsY/oQoNK9EWrAaw?=
 =?iso-8859-1?Q?FzxApHHbevlVIDTWJo8xneM5YeLrrXjkTErr/TZtOBObkqNK8PROd28cfA?=
 =?iso-8859-1?Q?6AF0QpraBtVpapid08eul3pipU6LHFpbY0tp19YVI/ao7PwOBmM4AkwutQ?=
 =?iso-8859-1?Q?mrAlyGEJg1gPcHwWXtla03ZLNUI/VcmA2ERksnbgsJ+3waBiq9a9DQyWsG?=
 =?iso-8859-1?Q?F6YmT8apLgcuhwPUjptObROln+6EhkRQKrp8cJYHyzcK2Ok02WynHBYW0P?=
 =?iso-8859-1?Q?vlc+Ng94NLiaP6rOtfs=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7349b5f-bbb2-4279-5475-08daa63ad260
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 19:01:19.3876
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aOLjvAGHsamKTZs4oyY+1eCzJMzyPOUm7LyN9KDPU23J9mpOj9ebGWo8AWhIWfpqscugZ3ocA7ToF0UuDkzWp83D4hREftTqPZLk7G5Wq8uIgUXB3u9qarC7hA4L1nbb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5302
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Monday, October 3, 2022 3:21 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power
> management functions to quad-uart driver.
> =20
> On Sat, 1 Oct 2022, Kumaravel Thiagarajan wrote:
>=20
> > pci1xxxx's quad-uart function has the capability to wake up the host
> > from suspend state. Enable wakeup before entering into suspend and
> > disable wakeup on resume.
> >
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@microchip.com>
> > ---
> > Changes in v2:
> > - Use DEFINE_SIMPLE_DEV_PM_OPS instead of SIMPLE_DEV_PM_OPS.
> > - Use pm_sleep_ptr instead of CONFIG_PM_SLEEP.
> > - Change the return data type of pci1xxxx_port_suspend to bool from int=
.
> > ---
> >  drivers/tty/serial/8250/8250_pci1xxxx.c | 112
> > ++++++++++++++++++++++++
> >  1 file changed, 112 insertions(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_pci1xxxx.c
> > b/drivers/tty/serial/8250/8250_pci1xxxx.c
> > index 999e5a284266..0a0459f66177 100644
> > --- a/drivers/tty/serial/8250/8250_pci1xxxx.c
> > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> > @@ -352,6 +352,112 @@ static void pci1xxxx_irq_assign(struct
> pci1xxxx_8250 *priv,
> >       }
> >  }
> >
> > +static bool pci1xxxx_port_suspend(int line) {
> > +     struct uart_8250_port *up =3D serial8250_get_port(line);
> > +     struct uart_port *port =3D &up->port;
> > +     unsigned long flags;
> > +     u8 wakeup_mask;
> > +     bool ret =3D false;
> > +
> > +     if (port->suspended =3D=3D 0 && port->dev) {
> > +             wakeup_mask =3D readb(up->port.membase +
> > + UART_WAKE_MASK_REG);
> > +
> > +             spin_lock_irqsave(&port->lock, flags);
> > +             port->mctrl &=3D ~TIOCM_OUT2;
> > +             port->ops->set_mctrl(port, port->mctrl);
> > +             spin_unlock_irqrestore(&port->lock, flags);
> > +
> > +             if ((wakeup_mask & UART_WAKE_SRCS) !=3D UART_WAKE_SRCS)
> > +                     ret =3D true;
> > +     }
> > +
> > +     writeb(UART_WAKE_SRCS, port->membase + UART_WAKE_REG);
> > +
> > +     return ret;
> > +}
> > +
> > +static void pci1xxxx_port_resume(int line) {
> > +     struct uart_8250_port *up =3D serial8250_get_port(line);
> > +     struct uart_port *port =3D &up->port;
> > +     unsigned long flags;
> > +
> > +     writeb(UART_WAKE_SRCS, port->membase + UART_WAKE_REG);
> > +
> > +     if (port->suspended =3D=3D 0) {
>=20
> Is this check the right way around?
Yes. I think port->suspended is not set for wake-up capable ports and the c=
ode in this if block gets executed for those ports.
I will check this again.
>=20
> > +             spin_lock_irqsave(&port->lock, flags);
> > +             port->mctrl |=3D TIOCM_OUT2;
> > +             port->ops->set_mctrl(port, port->mctrl);
> > +             spin_unlock_irqrestore(&port->lock, flags);
> > +     }
> > +}
> > +
> > +static int pci1xxxx_suspend(struct device *dev) {
> > +     struct pci1xxxx_8250 *priv =3D dev_get_drvdata(dev);
> > +     struct pci_dev *pcidev =3D to_pci_dev(dev);
> > +     unsigned int data;
> > +     void __iomem *p;
> > +     bool wakeup =3D false;
> > +     int i;
> > +
> > +     for (i =3D 0; i < priv->nr; i++) {
> > +             if (priv->line[i] >=3D 0) {
> > +                     serial8250_suspend_port(priv->line[i]);
> > +                     wakeup |=3D pci1xxxx_port_suspend(priv->line[i]);
>=20
> So first serial8250_suspend_port() calls into uart_suspend_port() that se=
ts
> port->suspended to 1, then pci1xxxx_port_suspend() checks if it's 0.
> Is this intentional?
Yes. I think port->suspended does not seem to be set for wake-up capable po=
rts and only=20
for those ports, inside pci1xxxx_port_suspend, TIOCM_OUT2 is cleared.
But I must check for the race condition as Andy had pointed out.
Please let me know if there are any questions.

Thank You.

Regards,
Kumar