Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91791c6a-345a-e9d7-cc72-3bd27df5bbf7@quicinc.com>
Date:   Tue, 4 Oct 2022 15:02:21 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add QDU1000/QRU1000 dt
 bindings
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Georgi Djakov <djakov@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221001030602.28232-1-quic_molvera@quicinc.com>
 <20221001030602.28232-2-quic_molvera@quicinc.com>
 <0bf97760-09e0-e64f-3ef6-2b861131f83e@linaro.org>
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <0bf97760-09e0-e64f-3ef6-2b861131f83e@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/1/2022 4:31 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Add interconnect IDs for Qualcomm QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  .../bindings/interconnect/qcom,rpmh.yaml      |  8 ++
>>  .../dt-bindings/interconnect/qcom,qdru1000.h  | 98 +++++++++++++++++++
>>  2 files changed, 106 insertions(+)
>>  create mode 100644 include/dt-bindings/interconnect/qcom,qdru1000.h
>>
>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> index a429a1ed1006..c524d92ee203 100644
>> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> @@ -132,6 +132,14 @@ properties:
>>        - qcom,sm8450-nsp-noc
>>        - qcom,sm8450-pcie-anoc
>>        - qcom,sm8450-system-noc
>> +      - qcom,qdu1000-clk-virt
>> +      - qcom,qdu1000-gem-noc
>> +      - qcom,qdu1000-mc-virt
>> +      - qcom,qdu1000-system-noc
>> +      - qcom,qru1000-clk-virt
>> +      - qcom,qru1000-gem-noc
>> +      - qcom,qru1000-mc-virt
>> +      - qcom,qru1000-system-noc
> Not a correct order.
Will fix to alphabetical.
>
>>  
>>    '#interconnect-cells': true
>>  
>> diff --git a/include/dt-bindings/interconnect/qcom,qdru1000.h b/include/dt-bindings/interconnect/qcom,qdru1000.h
>> new file mode 100644
>> index 000000000000..2bdfa0c15d2c
>> --- /dev/null
>> +++ b/include/dt-bindings/interconnect/qcom,qdru1000.h
>> @@ -0,0 +1,98 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
> Dual license.
Will add second license.
>
>
> Best regards,
> Krzysztof
Thanks,
Melody