Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d3b272e1-3b5d-c843-e8ac-57dc5e3a7ced@amd.com>
Date:   Tue, 4 Oct 2022 16:46:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of
 drm_dp_add_payload_part2()
Content-Language: en-US
To:     Lyude Paul <lyude@redhat.com>, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>, Wayne Lin <Wayne.Lin@amd.com>,
        Ian Chen <ian.chen@amd.com>,
        Mikita Lipski <mikita.lipski@amd.com>,
        Hamza Mahfooz <hamza.mahfooz@amd.com>,
        Claudio Suarez <cssk@net-c.es>,
        Colin Ian King <colin.i.king@gmail.com>,
        Jani Nikula <jani.nikula@intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20221004202429.124422-1-lyude@redhat.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20221004202429.124422-1-lyude@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amVMczhyNnZrUUVONzZoOHI0d0xTYlVuOG1PbFJDczV0NnlHRUJmMGtJSnRM?=
 =?utf-8?B?bjdVa09ocUZEb1piZzllYlBBK2ZnM3B3YnNHRHEzSnBSZlk4R3NadVN3TDVs?=
 =?utf-8?B?OUlFakszTUMxYzkxSDFhZk83MXZOaFY5Si9hZ1NEdkpqMkRaRldFdnNtR21F?=
 =?utf-8?B?R2hxNGRJWk9Xcnh0NTBLa3dKejZVOVFpNWQ3eS9XQURZWXBSTFhYK2JLcHZV?=
 =?utf-8?B?d2hKQ3RXaXY2QTlhZnEzMHRZQXAxaWZBbTZtR1RzYWxEQVdqd3ZLR3IzYWhH?=
 =?utf-8?B?aUtNb1FxUVB4RHZtZkRtYkRBTzd0YXByeTJBNnJkMVNYWm10Uk9OY1JNTjE3?=
 =?utf-8?B?bWVCb282Si9wdFBnd0l6VkZ2RXdnaURsN2ExTHMwUHFRdU1OMHBtclFWOVp6?=
 =?utf-8?B?d2pObXppV3lsNUlpYnlBUnAxK2IyekM2WE1VTU5iZWljVGtKc0JFdi9RUEYw?=
 =?utf-8?B?THQyT0g0Z3c1UGRLMktUY2F5TmhoVi9WUm1xblY2ZlBDSFJ2amozN1lZQ0gw?=
 =?utf-8?B?YmxLNTc2V1MyZy9Ydng3MFN3ZVlldnlQVVluSlhwQ25YdWxtQWRGczQ5RGlw?=
 =?utf-8?B?U2l5amdQZDg2T1BvTzlkRmFRbVdxeFlQSzNqTTcyT0F2QWhkalU2OHZOcERE?=
 =?utf-8?B?R2QzU01melRZaXh3VS9SWVg0dVoxM2MxQXBFNGxEMm03YmlNU3V5TkVoSkQ1?=
 =?utf-8?B?eFFOT2pmNDVtazhleFVCUU9VaXFkNWpnVmxIbDQ0ckdKU3VBY29WT1ZsbTJs?=
 =?utf-8?B?aU1XZ0Rhd28rdFhNMWpUT0FFeE9nV3FOR0FMdEE0VXhSN25NS2lnUGtLeXg4?=
 =?utf-8?B?S1loLzBYMG03NTEyT0FQYkRiYnRrYkNTc3RTZUE2TGFqUVZtWXFSNitKWmI4?=
 =?utf-8?B?NzNhZTBmV2NXeEJ1Wi9DOUduY2YxRzM5dEtjNlVaNlNxalRhb00yUCtuT290?=
 =?utf-8?B?QlpVU2YwTjhTLzhzdWRzQ1FiY2FocWhUb2tuQ1Btcllvb0dGUVhjUnJNVURm?=
 =?utf-8?B?cmlIRmxsRjNVUys4aitaWnJ4TXRMRVZmUHE2QVIvNVkzNzMrQzB0VmtucmRF?=
 =?utf-8?B?WUNGeTRUY1hsMzJjMVhsWExmRktIMlNCeXVsZXY4cFMzL1hWWVBZUnM1UDg0?=
 =?utf-8?B?bXFyZlMwdU5oVjZ4dWF1cHl1bkM5a3ZYb1kyS01tYTY5KzMySS9zY0s0OUZz?=
 =?utf-8?B?aXZKNEhIc2tZdjAxWk0wa2duckxOZE84ZlAxeGhpTllVUktEUFQwU2VidVkv?=
 =?utf-8?B?VGNBaUxvS0JRcTNYWW5aSUh3WVFTazlVUmkyVzV6bWgwVUxTNUYxbGE2WHM4?=
 =?utf-8?B?ZXRXbWZ4QU4xMWIwazZwam9EdDlOZDFYb2IxaTdqYy9sOCtoVDNneHUyVWtB?=
 =?utf-8?B?OVE2SjBCbHNLTTJzWCtTby9PNTZ1R0dXZnZzTFpabjRUVVQrY21oelNzSWNZ?=
 =?utf-8?B?Q0ZIc3MrVzNyaGx5bE5WdkJPQ3VkNVQwaTlyRjVvaWxuYzBmYnFBWEpMdXNG?=
 =?utf-8?B?aDArR3I0VU43b2dBbzk0L2V1bVNpL1ZYKzZubFJ3OGlZeGhkTVBHUlp5L2I1?=
 =?utf-8?B?Tyt5dTZidzJGKzEzTHRHTlRlVG1MdWIwblkyVTlsVWhONTRSYllSRW1TTkI1?=
 =?utf-8?B?UUVPaFFlL2xrL1laNkpsZ2dtTWUxakk1ZmQ0OUFGU3pucmZPaVBRdVVxU2da?=
 =?utf-8?B?YldWdWFQQzBJTEo1NlE3YllVN2o2WTAxNDVaZ0ZEVnN4VHpmN1d1b1ZOY1Uw?=
 =?utf-8?B?Q0JzM1hhcXkvWElVNzVGVlRBT2xVNFhscGJDMVZvVk8xLzZNUkxCWCtnbWZF?=
 =?utf-8?B?Ty9iUXdEWUxXYzRJSDY1K3VzVW56bUJ4VVhkbExRa0NMcmloNlo4VUc2RjRU?=
 =?utf-8?B?dlBzVFYzejVHUitPajNwNnliT25UdHpyNmRGNnkzaGVDRGdDeDFaTldsM09K?=
 =?utf-8?B?U1BPbVpXMGp0ZWdnM0Zud1RHVjE1eGJzZUx1RnVyakV5QjM3TlpOdENpeFBu?=
 =?utf-8?B?b1ZGeU9laGlXR2JVWWRwREUzOUl1Z0tjTTVjcThsQThRdjZ5VWNlaWs3d3dX?=
 =?utf-8?B?dHlteTFaaUdjUlB3QVhBNjkwOGZwTkI3cnZXVVZIV3hla2YzUkFGMVM5dmJi?=
 =?utf-8?Q?/3hv1TFhAcwdRzsWo2S1tvG4Y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd2af34a-b5a1-40f1-0c50-08daa6498dac
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 20:46:46.7595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p4Aw+IUpYpvt2/CziotvdWirUne9LQVozRkIE8xf2OcNdCelcD6CjH6bEbMFepvbSvonla+dpoLSYTJ8eRSe3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5609
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-10-04 16:24, Lyude Paul wrote:
> Yikes, it appears somehow I totally made a mistake here. We're currently
> checking to see if drm_dp_add_payload_part2() returns a non-zero value to
> indicate success. That's totally wrong though, as this function only
> returns a zero value on success - not the other way around.
> 
> So, fix that.
> 
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171
> Fixes: 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state")
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index b8077fcd4651..00598def5b39 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -297,7 +297,7 @@ bool dm_helpers_dp_mst_send_payload_allocation(
>   		clr_flag = MST_ALLOCATE_NEW_PAYLOAD;
>   	}
>   
> -	if (enable && drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, payload)) {
> +	if (enable && drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, payload) == 0) {
>   		amdgpu_dm_set_mst_status(&aconnector->mst_status,
>   			set_flag, false);
>   	} else {

Hi Lyude,

Maybe I'm missing something, but I can't find the 
drm_dp_add_payload_part2() function on amd-staging-drm-next. Which repo 
are you using?

Thanks
Siqueira