Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: ZAPVf8n9ojwmaaC8dJa6Bg61J8HW46qRJ/q69BzhSJkR0kYZeTk/EaVai3z5729YajE0tMzGX9
 3RREjSVPcPO+G36GLOwf/wrt7c8yYGFF+gkMGC+k29WbnCS5L2pamTDan5KdocfvBLClxZquyD
 D+ZU9LTezxaHEqRMxjIw4DwMVSTT+LrLo0kmn/P+fzo0mT6gvxt63sTzbwfuKXVKdtOWPEtAox
 tYVjDbraJ205cE2axf36iOlUnRwlnO0WMV3tWf3YBcJ0RwVdSwCYX6Ia9i7RNRIND+ryzNzvrU
 nOs91LB30xCILSCrih5S/SSn
IronPort-SDR: 9AQ+rtDZXWcFYYMVlqrYIzMesPrcPTR74zyUrEk1Z1xmrqks9aoGdj9S5DVSum73C/kFxUxP8I
 EFi39WNYI4E2b5qb8bYxYuWaBvob3UqsFAOOSGMzJkovED3qusr/cSj79VjdtAcp7BAMlsDAZt
 3G2W/aEIr0mWM/TgOPHTzprgxvFdMboHXjMZiN/2UkbthcHvq3pmUq7kW8WMPW89MJiqYu9+2u
 9gvZRs1thxpp/tQAqZlI/xrOm6JAb3MlvAXqt9iNZ7dw7p1OJso0CKR1MhGigpitwWGFa2WeCV
 qs4=
WDCIronportException: Internal
Message-ID: <7e3a521e-acf7-c3a8-a29b-c51874862344@opensource.wdc.com>
Date:   Wed, 5 Oct 2022 07:40:26 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] block: allow specifying default iosched in config
Content-Language: en-US
To:     Khazhy Kumykov <khazhy@chromium.org>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220926220134.2633692-1-khazhy@google.com>
 <fff022da-72f2-0fdb-e792-8d75069441cc@opensource.wdc.com>
 <CACGdZYKh4TXSaAAzJa13xsMH=tFzb4dYrPzOS3HHLLU8K-362g@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CACGdZYKh4TXSaAAzJa13xsMH=tFzb4dYrPzOS3HHLLU8K-362g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/5/22 03:33, Khazhy Kumykov wrote:
> On Mon, Oct 3, 2022 at 11:12 PM Damien Le Moal
> <damien.lemoal@opensource.wdc.com> wrote:
>>
>> This will allow a configuration to specify bfq or kyber for all single queue
>> devices
> That's the idea
>> , which include SMR HDDs. Since these can only use mq-deadline (or none
>> if the user like living dangerously), this default config-based solution is not
>> OK in my opinion.
> I don't think this is true - elevator_init_mq will call
> elevator_get_by_features, not elevator_get_default for SMR hdds (and
> other zoned devices), as it sets required_elevator_features.

OK, but my point remains: why not use a udev rule ? Why add a config
option to hardcode the default scheduler ? Most average users will have no
idea which one to choose...

>>
>> What is wrong with using a udev rule to set the default disk scheduler ? Most
>> distros do that already anyway, so this config may not even be that useful in
>> practice. What is the use case here ?
>>
>>
>> --
>> Damien Le Moal
>> Western Digital Research
>>

-- 
Damien Le Moal
Western Digital Research