Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Oct 2022 01:12:25 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Thomas Tai <thomas.tai@oracle.com>
Cc:     "tony.luck@intel.com" <tony.luck@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "reinette.chatre@intel.co" <reinette.chatre@intel.co>,
        "naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
 memory
Message-ID: <Yzyvya4wdfovw2eh@kernel.org>
References: <20220928153832.1032566-1-thomas.tai@oracle.com>
 <20220928153832.1032566-2-thomas.tai@oracle.com>
 <YzdkwIsNVI7P34ej@kernel.org>
 <SJ0PR10MB462307B1EA3097E1E725309DFD589@SJ0PR10MB4623.namprd10.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SJ0PR10MB462307B1EA3097E1E725309DFD589@SJ0PR10MB4623.namprd10.prod.outlook.com>
Precedence: bulk

On Sun, Oct 02, 2022 at 02:51:22PM +0000, Thomas Tai wrote:
> 
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > Sent: September 30, 2022 5:51 PM
> > To: Thomas Tai <thomas.tai@oracle.com>
> > Cc: tony.luck@intel.com; dave.hansen@linux.intel.com;
> > reinette.chatre@intel.co; naoya.horiguchi@nec.com; linmiaohe@huawei.com;
> > akpm@linux-foundation.org; linux-mm@kvack.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
> > memory
> > 
> > On Wed, Sep 28, 2022 at 11:38:32AM -0400, Thomas Tai wrote:
> > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > > address validation), add a similar code in hwpoison_inject function to
> > > check if the address is located in SGX Memory. The error will then be
> > > handled by the arch_memory_failure function in the SGX driver.
> > >
> > > Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> > > ---
> > >  Documentation/mm/hwpoison.rst | 44
> > +++++++++++++++++++++++++++++++++++
> > >  mm/hwpoison-inject.c          |  4 ++++
> > >  2 files changed, 48 insertions(+)
> > 
> > Hmm.. no change log.
> > 
> > What was the change in-between v1 and v2?
> 
> Hi Jarkko,
> I put the change log in [PATCH V2 0/1]. Following is the details, hope you find it useful.
> 
> Changes since v1:
> - Add a comment in hwpoison_inject as suggested by Miaohe
> - v1: Reviewed-by: Tony Luck <tony.luck@intel.com>
> - v1: Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> Thanks,
> Thomas

Also,


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko