Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1236001rwb; Tue, 4 Oct 2022 18:10:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4mlh1GDg4CRq58VG784kDfPDq+6jTKrm1A7Fox+6tSxIrKeNxPObOYB21DM5bY+pnvz1/4 X-Received: by 2002:a05:6402:f24:b0:459:2743:82f8 with SMTP id i36-20020a0564020f2400b00459274382f8mr9128207eda.418.1664932221161; Tue, 04 Oct 2022 18:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664932221; cv=none; d=google.com; s=arc-20160816; b=FYttfaa69rRB/VIah3t0hJROM8iyc6CijQWUJlD0jyTID67QDhR0ePBs84M9sqtDVz cClKalh63aCostfVpuZ59ez7HyHCQ+6NuIaKCTnhD0G/z0p+BEEwjmwoewoj2UpwwEOp PpjOr2g5w1Az0l0M3qzEVI06dq4Bo2Kt7F+a20Hrj1knV1BJyBK5/CZSoTJl4Zwvp82X lJ8H9EpgKVAnjHuEskz3/5RQ9AoW0zQGmT6++SrUstqEvNfBa5McJyyflxTIEUTYrbvH QZGRP/PW2Xk7mnLhI63MmvtqyliJPbn0kecmOqvgL0zwKly6N/JSIG6JGVMoFN9Eqo1v 9Jrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=xMDCCgPKo5Rcf046K175DIfPsqPmk4MBD2wJT/gdkEY=; b=bxEBpruI1K5nBXnWaLEhVD62irtk0F+6OnO5kgw8Z3UPyCc/etM2wX/5CrKuxbleII xTxRlrwf6arQD7zykkNRDLYU/4PZvOatCt5PFzvR05WsHL4H/Xoy1BFzZ95LAuPda75s 55iKkvCJ8VG5BQxkIn0dLx0dZmdYuHPdao9mWq3e0RxB5GBmnRfdq5VIZJQsv0o7AoIn j032TKJPYzkHaKDxQBlLvqCy8RnohDv7KMjQq7+fdWFVLzQJTn8qpGFgklQyQyNJxQXF GmbnzeQGPjri8yxmYyZFn2tyRvtQIGWQAbWhrY4BLOb+1+o1O6KnuTSif080MPkb3M8o URJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VEoHgV50; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f15-20020a50a6cf000000b0044869b3886bsi10912101edc.194.2022.10.04.18.09.54; Tue, 04 Oct 2022 18:10:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VEoHgV50; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbiJEAay (ORCPT + 99 others); Tue, 4 Oct 2022 20:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiJEAau (ORCPT ); Tue, 4 Oct 2022 20:30:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B14756B82; Tue, 4 Oct 2022 17:30:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ED89BB81B54; Wed, 5 Oct 2022 00:30:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45066C433D6; Wed, 5 Oct 2022 00:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664929847; bh=y4Zwm8QOPM6J2mvf2FDbEYt5AqCQVuApnRv1mKgcby8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VEoHgV50wq7+CCtjldXASZQq4dfOAIQECU2Ieaczh37GmqqGS57nIuP588wl5TmCk 3B33uPCR24m791TKLtDOH2u7ptipHps4i2V8ZW8iKy11Sg5Uj3mLyo4gJo/H3CSkxi maj/277l9cWCTJHba8dalj/Nq0HSKnRK6KYEsYFhTlV9Rntc1iZvDEMQPnNttqQztc jnHRDt4k5QZezRezDhI3VVmBcFIGyiKsWww1A0PVEmezbHnOyzno2f09/VAEnlP6Ip fd4IRhGu1iuYAcVBXSOVTAuBQTuhiZqVbBlCAbfjCy8yMYSCX78HScIVl7K2tjxz04 bn1yg48lGg6xA== Date: Tue, 4 Oct 2022 17:30:46 -0700 From: Jakub Kicinski To: Stephen Hemminger , Peter Kosyh Cc: Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant. Message-ID: <20221004173046.5ec6d3ca@kernel.org> In-Reply-To: <20221004082936.0d0c9bcb@hermes.local> References: <20221004095034.377665-1-pkosyh@yandex.ru> <20221004082936.0d0c9bcb@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Oct 2022 08:29:36 -0700 Stephen Hemminger wrote: > On Tue, 4 Oct 2022 12:50:34 +0300 > Peter Kosyh wrote: > > > printf to array 'eqo->desc' of size 32 may cause buffer overflow when > > using non-standard IFNAMSIZ. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Signed-off-by: Peter Kosyh > > NACK > Non-standard IFNAMSIZ will break uapi and many things. > I see no reason for kernel or tools like iproute2 to support or > fix those related bugs. I think the commit message is missing the point, but the warning may be legit. Pater please read the requirements for sending patches based on automated checkers: Documentation/process/researcher-guidelines.rst