Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abbe10d1-4c2a-5fad-3f92-e55c514d3ce2@gmail.com>
Date:   Tue, 4 Oct 2022 19:29:50 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: linux-next: build warnings after merge of the broadcom tree
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Cc:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        ARM <linux-arm-kernel@lists.infradead.org>
References: <20220725095913.31e859ec@canb.auug.org.au>
 <df8f4765-a804-cb50-bbb5-475925ba2036@milecki.pl>
 <20220815105419.4df1005b@canb.auug.org.au>
 <20220831091654.45d5ed41@canb.auug.org.au>
 <20221005114841.4540d325@canb.auug.org.au>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20221005114841.4540d325@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/4/2022 5:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 31 Aug 2022 09:16:54 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> On Mon, 15 Aug 2022 10:54:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
>>>>
>>>> On 25.07.2022 01:59, Stephen Rothwell wrote:
>>>>> After merging the broadcom tree, today's linux-next build (arm
>>>>> multi_v7_defconfig) produced these warnings:
>>>>>
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)
>>>>
>>>> This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
>>>> basic PCI controller properties") reduced following warnings:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> down to this one:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> and basically does the right thing (adds required properties).
>>>>
>>>>
>>>> I'm fully aware "ranges" need to be added (it's mentioned in the commit)
>>>> and it's one of next things on my BCM5301X list.
>>>>
>>>> So while my commits triggers that problem it also reduces warnings so
>>>> I'd say it's acceptable.
>>
>> Not from my point of view:  I was not getting any warnings and now I am
>> getting 254 lines of warnings :-(
>>    
>>> So, is something being done about these introduced warnings?
>>
>> I am still seeing these warnings.
>>
>> The above commit is now
>>
>>    61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")
> 
> Has any progress been made with this?  This commit is now in the
> arm-soc tree.

Yes, I was hoping to get some feedback on this patch:

https://lore.kernel.org/all/20220920210213.3268525-1-f.fainelli@gmail.com/

but I suppose being the ARM SoC maintainer I can just go ahead and push it.
-- 
Florian