Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: Gb17HQHHUvbZIfVupZI9aVofVMr+5mDwgDr20mKQ2A1PWUP5GKLwB46fAkgEhT2zmJ7i+i+H7Z
 1ED+Lkn9iqpOEI6nZkGox6fF08rndrjL+ouM7jruBCKp1emYoEONuk6zzOiSqry6sXt3V327ug
 vc8Gl3QxJmesUlRNMkFXZAWWT+tNH+f2u2qCjMZgZwm0nBg/4XjJ6zZxXed8Q32MrPb8c4zM+1
 N2UVZTkxQ2l8REZgqayStpq70nJzaLmEq+QQlupERLpzOB0stThEuKIYq+5d1BYo403jTEoEtW
 E9is09v0KWE8FzNuerWZKVxY
IronPort-SDR: VAYgIb8rZ3MgAxkWyRQtafgeBUWWl8uljwXtY42Pa/EAkKLMNnp+vCanjXzd91xwysM3YWNRzD
 PQQWbhJn+PoGDKaYiqw2Oe1ecIxRV89OL/8hJbORJoi+BwnGejF3WRF8Ssd9x5eDoDnVP2Gbce
 pS3tNq2nTyxJviz8V1EzEmqDTJA8lP3rYk3/0kyxRE9GTYDs40bBxEVAGUEI18NWFgkNjck7X7
 /WhaS2N3Pa91GJ3SKD2WIIV/0dEzFhwq16Asz2ouEAYzwM3+f0jIRnmC56XXgMCXfTaKUqBWay
 WVg=
WDCIronportException: Internal
Message-ID: <64c8beb8-ddb1-c86c-c6c6-aea93776f619@opensource.wdc.com>
Date:   Wed, 5 Oct 2022 14:04:18 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 4/6] null_blk: initialize cmd->bio in __alloc_cmd()
Content-Language: en-US
To:     Chaitanya Kulkarni <kch@nvidia.com>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     axboe@kernel.dk, johannes.thumshirn@wdc.com, bvanassche@acm.org,
        ming.lei@redhat.com, shinichiro.kawasaki@wdc.com,
        vincent.fu@samsung.com, yukuai3@huawei.com
References: <20221005031701.79077-1-kch@nvidia.com>
 <20221005031701.79077-5-kch@nvidia.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221005031701.79077-5-kch@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/5/22 12:16, Chaitanya Kulkarni wrote:
> The function __alloc_cmd() is responsible to allocate tag and
> initializae the different members of the null_cmd structure e.g.
> cmd->tag, cmd->error, and cmd->nq, Move only member bio that is initialized
> from alloc_cmd() into __alloc_cmd().
> 
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/block/null_blk/main.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index b82c2ffeb086..765c1ca0edf5 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -743,7 +743,7 @@ static void free_cmd(struct nullb_cmd *cmd)
>  
>  static enum hrtimer_restart null_cmd_timer_expired(struct hrtimer *timer);
>  
> -static struct nullb_cmd *__alloc_cmd(struct nullb_queue *nq)
> +static struct nullb_cmd *__alloc_cmd(struct nullb_queue *nq, struct bio *bio)
>  {
>  	struct nullb_cmd *cmd;
>  	unsigned int tag;
> @@ -754,6 +754,7 @@ static struct nullb_cmd *__alloc_cmd(struct nullb_queue *nq)
>  		cmd->tag = tag;
>  		cmd->error = BLK_STS_OK;
>  		cmd->nq = nq;
> +		cmd->bio = bio;
>  		if (nq->dev->irqmode == NULL_IRQ_TIMER) {
>  			hrtimer_init(&cmd->timer, CLOCK_MONOTONIC,
>  				     HRTIMER_MODE_REL);
> @@ -775,11 +776,9 @@ static struct nullb_cmd *alloc_cmd(struct nullb_queue *nq, struct bio *bio)
>  		 * This avoids multiple return statements, multiple calls to
>  		 * __alloc_cmd() and a fast path call to prepare_to_wait().
>  		 */
> -		cmd = __alloc_cmd(nq);
> -		if (cmd) {
> -			cmd->bio = bio;
> +		cmd = __alloc_cmd(nq, bio);
> +		if (cmd)
>  			return cmd;
> -		}
>  		prepare_to_wait(&nq->wait, &wait, TASK_UNINTERRUPTIBLE);
>  		io_schedule();
>  		finish_wait(&nq->wait, &wait);

-- 
Damien Le Moal
Western Digital Research