Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <24361bea-ecfe-b6e1-e755-5151220767f2@linaro.org>
Date:   Wed, 5 Oct 2022 09:30:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v4 1/2] media: dt-bindings: mediatek: Rename child node
 names for decoder
To:     =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= 
        <Allen-KH.Cheng@mediatek.com>, "robh@kernel.org" <robh@kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
References: <20220930112237.14411-1-allen-kh.cheng@mediatek.com>
 <20220930112237.14411-2-allen-kh.cheng@mediatek.com>
 <20220930220011.GA1107972-robh@kernel.org>
 <ffc56eb60a3ef74c815c8d3c170a0df51958e20d.camel@mediatek.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <ffc56eb60a3ef74c815c8d3c170a0df51958e20d.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 05/10/2022 09:21, Allen-KH Cheng (程冠勳) wrote:
> Hi Rob,
> 
> On Fri, 2022-09-30 at 17:00 -0500, Rob Herring wrote:
>> On Fri, Sep 30, 2022 at 07:22:36PM +0800, Allen-KH Cheng wrote:
>>> In order to make the names of the child nodes more generic, we
>>> rename
>>> "vcodec" to "video-codec" for decoder in patternProperties and
>>> example.
>>
>> They are either generic or they aren't. Until something generic is 
>> defined, I don't think it's worth the churn to change.
>>
>>
>>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
>>> Reviewed-by: AngeloGioacchino Del Regno <
>>> angelogioacchino.delregno@collabora.com>
>>> ---
>>>  .../bindings/media/mediatek,vcodec-subdev-decoder.yaml    | 8
>>> ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
>>> decoder.yaml
>>> b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
>>> decoder.yaml
>>> index c4f20acdc1f8..67fde48f991c 100644
>>> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
>>> subdev-decoder.yaml
>>> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
>>> subdev-decoder.yaml
>>> @@ -91,7 +91,7 @@ properties:
>>>  
>>>  # Required child node:
>>>  patternProperties:
>>> -  '^vcodec-lat@[0-9a-f]+$':
>>> +  '^video-codec-lat@[0-9a-f]+$':
>>
>> Just 'video-codec' doesn't work?
>>
> 
> Thanks for your reply.
> 
> hmm, I think 'vidoe-codec' does wrok.
> 
> There are two seperate hardwares for the MTK video codec.
> codec-lat and codec-core.
> 
> Is it ok to keep two child node names for various hardwares?
> 

Aren't they still codecs?

Best regards,
Krzysztof