Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbXFYU40 (ORCPT ); Mon, 25 Jun 2007 16:56:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751541AbXFYU4T (ORCPT ); Mon, 25 Jun 2007 16:56:19 -0400 Received: from fmx03.freemail.hu ([195.228.245.53]:59507 "HELO fmx03.freemail.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750718AbXFYU4S convert rfc822-to-8bit (ORCPT ); Mon, 25 Jun 2007 16:56:18 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jun 2007 16:56:18 EDT Date: Mon, 25 Jun 2007 22:49:36 +0200 (CEST) From: =?ISO-8859-2?Q?Bart=F3k_Albert?= Subject: Re: [patch] Reporting the lid status using INPUT To: GMail cc: Dmitry Torokhov , linux-acpi , Bastien Nocera , David Zeuthen , linux-kernel In-Reply-To: <15e53e180706241506p53ec648ib93d684bbe076a46@mail.gmail.com> Message-ID: X-Originating-IP: [131.111.8.102] X-HTTP-User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070603 Fedora/2.0.0.4-2.fc7 Firefox/2.0.0.4 MIME-Version: 1.0 Content-Type: TEXT/plain; CHARSET=ISO-8859-2 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1946 Lines: 53 GMail On 16/06/07, Dmitry Torokhov wrote: > On Saturday 16 June 2007 13:11, Richard Hughes wrote: > > On Fri, 2007-06-15 at 15:53 +0100, Richard Hughes wrote: > > > On Fri, 2007-06-15 at 10:29 -0400, Dmitry Torokhov wrote: > > > > On 6/15/07, Richard Hughes wrote: > > > > > On Fri, 2007-06-15 at 13:29 +0100, Richard Hughes wrote: > > > > > > in response to an event, but I'm thinking in a resume hook we should > > > > > > probably do acpi_evaluate_integer(handle, "_LID", NULL, &state) and then > > > > > > send an event, just so userspace is aware of what the state of the panel > > > > > > is. > > > > > > > > > > Attached patch fixed the issue for me. Comments? > > > > > > > > > > > > > The patch makes perfect sense. The only issue I have is this: > > > > > > > > > + /* on resume we send the state; it might be the same, but userspace > > > > > + * should handle duplicated events */ > > > > > > > > If switch state matches to what input layer thinks it is the event > > > > will not even reach userspace. > > > > > > Okay, new patch attached, thanks for the speedy review. > > > > This fix is also confirmed by somebody else, see > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243030 > > > > It would be great if this could go into .22, although I appreciate it's > > quite late in the day. > > > > This is of course Len's call but in my book this is a bugfix and as such > is appropriate for -rc4/rc5. > Guys? Any ack-nak? works perfectly for me so far. Albert 15% KEDVEZM?NY minden PLASZTIKAI M?T?TRE az Aesthetica orvosi k?zpontban! Klikk ide!http://www.webdesign.hu/aesthetica/flash_microsite/?id=9;p_code=2079 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/