Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1636876rwb; Wed, 5 Oct 2022 02:31:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6VVmzzcNA7Dcu1TIcvFA/vk4P7qpRymwyx7Cu9DTRJC0vmcIW4oKtGTuGF4UoA4gDSu9E7 X-Received: by 2002:a17:906:ee8e:b0:730:3646:d178 with SMTP id wt14-20020a170906ee8e00b007303646d178mr23400726ejb.426.1664962297850; Wed, 05 Oct 2022 02:31:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664962297; cv=none; d=google.com; s=arc-20160816; b=IfYXKrKyh5IhkD50DfAyGmp8qERcSTKzxo1lffYtyaooprio4wAlkKj7yZIx1tApHV NK4zAKrpe/j591qKUI+YzlaNxqOvX1lfA/GkPtJ5N/CBb/k7YkLgHzW8pN4v8R4GNU5X 3+zKnWf4GbV1CbfjSfEtQ6iyfn02U1svfvhKAC9OMAUaJt8RzSEoWxNIsZrOWB5XwFpc Tf6QE5NpQmPUYEVL6dOiyrFZAqJ928IVTWpqyKYPYnXpc9Ul0Z7Kf97VHW4HXq+XAqOp 3SCCMcYYjUpayPmy+Y88wwlPmKOhm2a4KgrEuX3hj5lfBvFVK7lLP65Zl6zqMvN3nbmO VMeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:references:in-reply-to:user-agent:subject:cc:to:from :date:dkim-signature; bh=0aaE5YzYEK172qzp5pik2jCR92WPSlO4droa23kYQMc=; b=HONBOnL0kZ+04IrH2p+kT1ABW93xWFBd16y3kKCe4mgyrYPhw802nmQem+mwHyDl2m OsA/bKOV2ok2hPw3LMOvaIyRPIeKrvR/xbDrSzdvakCD3D9bd/fckx/gUxeZEo/74NA9 3JT0iCRiUrhEH/UDfP8u122PQEFKrUVCgA2VkhFjW25/kb18qVv8TLPQ0jlvdgelYSXz 0Bu0+aUI8XWjQRGftK7x81Wxu4x+qtA4/LTcYWmzUF8mPaXI283IL+HpYXvdtCRcXZQh om0MsekZYtb+40tG0UPaeALEZf010seX6wC4Ifn5TxXydPyEzJOSpuqoBtty/OAKuZq5 36zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDAltb2O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c18-20020a056402121200b0044ee88a08b1si9438280edw.277.2022.10.05.02.31.05; Wed, 05 Oct 2022 02:31:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CDAltb2O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbiJEJGM (ORCPT + 99 others); Wed, 5 Oct 2022 05:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbiJEJGI (ORCPT ); Wed, 5 Oct 2022 05:06:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C88B37644D; Wed, 5 Oct 2022 02:06:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55C3AB81D49; Wed, 5 Oct 2022 09:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 490B7C433D6; Wed, 5 Oct 2022 09:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664960765; bh=hJ2FlaFirUuI4hX9j6QpETml7t5ItP4nxc9UwAYJ8tw=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=CDAltb2OxH7o/HxYn2/oU7A5p6W5RcL0WkwL63fIQQByoKvBmfYhibYXlngZXOhDS zFaUAUTu/PdVH3LgtRwifdsSM4Jm669AIkgSpwsZslVD8gjOr33yqu8HmqJlZviKjl liiP+HotD1eCP5Hg9XN/zeLg1LLrLFxF/ynm2LR6wA+iHOV4B5l7OXH1MW5OfjJRWT uwuUr9v+IVBG7AJ0Ec+uYWOTCfYpPfuIs1rBUN92sAS8u4u+gYRtnGGp6eL9PLeeOs TYfICQAqPQ91szksq37nGOa//hRb9NfHaFZoeB57vTyjGWb79TZVkrkNYajdPLsjpW uE8licpGT03VQ== Date: Wed, 05 Oct 2022 09:58:01 +0100 From: Conor Dooley To: "Lad, Prabhakar" CC: Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Krzysztof Kozlowski , Magnus Damm , Heiko Stuebner , Guo Ren , Conor Dooley , Philipp Tomsich , Nathan Chancellor , Atish Patra , Anup Patel , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Biju Das , Lad Prabhakar Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_v2_2/2=5D_soc=3A_renesas=3A_A?= =?US-ASCII?Q?dd_L2_cache_management_for_RZ/Five_SoC?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20221003223222.448551-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20221003223222.448551-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 October 2022 09:44:56 IST, "Lad, Prabhakar" wrote: >Hi Conor, > >Thank you for the review=2E > >On Tue, Oct 4, 2022 at 6:43 PM Conor Dooley wrote: >> > +static void cpu_dcache_wb_range(unsigned long start, >> > + unsigned long end, >> > + int line_size) >> > +{ >> > + bool ucctl_ok =3D false; >> > + unsigned long pa; >> > + int mhartid =3D 0; >> > +#ifdef CONFIG_SMP >> > + mhartid =3D smp_processor_id(); >> > +#endif >> >> Won't this produce complaints from your if you compile with CONFIG_SMP >> set? >> >No I dont see a build issue with SMP enabled, do you see any reason >why it should fail? Not fail but complain about the unused variable=2E