Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ed567ab-6f1d-996e-66d1-da1e6b7ab8d2@suse.com>
Date:   Wed, 5 Oct 2022 13:58:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 1/4] xen/pv: add fault recovery control to pmu msr
 accesses
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221005110302.13455-1-jgross@suse.com>
 <20221005110302.13455-2-jgross@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221005110302.13455-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFRBU2xmcUxxQTRUczY5Q2ZlSEIwR1RyMFZUMm5oZ3NUejBnU0M5Q0ZIaWlG?=
 =?utf-8?B?bHArLy9EQzBPM25PRjd4NzVzMXZpVjVTak1aNDFLVSswQ3EyVTM2OTZvaUJC?=
 =?utf-8?B?OE1rOGV6dU4wRVExM2I3NHlCZHVNS1AxNWtmc0lyRXZod2hxaHVFYWJTbitu?=
 =?utf-8?B?SGIyeEtKQ3A2Tk5uNjAxeEpyM3lpVnlLMVlaR0pKbEhML0Y0REhMUFVCY0Zs?=
 =?utf-8?B?N092TlUyWmhadkR1cit5NFRCTklVUFdDY3VQQ3hNTEk1c25qSnQwbkJTV1o2?=
 =?utf-8?B?ZXY1VVgrcTlDQ2RBMnlzSXY5MEJrRWd1RWorQk1scysxTGZ2NXZudEJGQUNr?=
 =?utf-8?B?TUVDa1JGR2syZUVvUkpyVG40NkI3SVJ0Zy9BbHNkVG92Z2s0TkpKQ2pMNWJh?=
 =?utf-8?B?UStucXY2TzhzZW92bkRVVXFtMklTYmhtRW1IamFjQVFEM0p1UW1GY0JTYzV0?=
 =?utf-8?B?VElhS2ExcGRlY2NYN081cVBGRG1xcDZvQWFCQm91dTdELzFpNTQzVi9jUjNp?=
 =?utf-8?B?clJYUHE0VitDZ3JCTVFwUkRYa3N3eXdDYTJldFRJNm9UTUFpK2gxNEtFa3BY?=
 =?utf-8?B?VjBsNlRrUmtHL3BOcHFhb3NoMW9YYkpRZW9GVzF4Y1did0h5S0xEN0plUk9U?=
 =?utf-8?B?Skg4YTluZGRqZi9sakgyYi8xNUttQWZLdk95SU1hYUlaZ2hnd0J4RThlTUlo?=
 =?utf-8?B?eXBhV0djNHJNQWFaeWwzK1FVd0dRVjJEcktiQzVkLzUyWlI4SUtKelF4Tk9I?=
 =?utf-8?B?QjNGTTdoWnRsM2JmbkVSYVNvUzM1QjY1QzFqK0oveW9ScEJNaGVYa1RtV3lW?=
 =?utf-8?B?bHVETUtlN0lZMjd1U25NNzVvbGlMZk91aExvVGRPMjJPMUhHTzZ2S3lOVWRQ?=
 =?utf-8?B?aFdXcHFuWkR0ZzVnaXM5cFB2VTU2U0VCR2pybUhXcmVRd1pFaUNQOTdqQWVS?=
 =?utf-8?B?VDd0N1ltMWQ1THlVRFh1Y044WTdtM0pwVmFodnhtd1BScmNaREJaalAxanMv?=
 =?utf-8?B?ZzVJUW9GalpOVHpTaXdIQzRoNXhidXZIUWZzcXNVbkxDajFwRi93a2lDVDVZ?=
 =?utf-8?B?aFJ3bVcyMzRBSzRBeU5xc2x5b1VZUmlSckZ6c1BTYXViWUIrblJGd2NlbDB0?=
 =?utf-8?B?YjNpQUJYSnNBSExYZ0FldFhSTlBwb1NDVlIvT0xGU2UyVjRJek1sL1gvVFZs?=
 =?utf-8?B?WUI1am9iSWgrSTk1djRoRkhCc0tPQUVoUUk5Ym1VaXcxVEdlOHpIZEtuc3pW?=
 =?utf-8?B?QUxpK09QWGZkQTBleDV3WmlEb3VmZnM5RFJha1h2V0hvVzgrbEJzN0pZdkNM?=
 =?utf-8?B?Z2RFZkUvRVR2alpDOXd0OXFlek9FRUYvK1R2SzlmeVJlbmpKZTJuU0RETjVx?=
 =?utf-8?B?dTRKZFBvS0RqTnRNdzcwK3VRUThYN2tmQXVROUtUM0czZXNLSm9WWGVmMFRw?=
 =?utf-8?B?UXJsUXdMMlJudGdWOXg3VC9hUDk3K2EzaXhUSk13QUxVWkhYc0xLZGJyNnZG?=
 =?utf-8?B?NDlPMUVkQkRnTTNJK3BPWkdGcHFMNldqcFhjR3hKYm42a2F4aC9qOG5lVlov?=
 =?utf-8?B?bW96Z3FwWXY0QllNVlkxdHIzUUMvUzFTZDFzTWxadEIrNDRmcDNVSlh1T1Vz?=
 =?utf-8?B?QStlSmdsNU14NGhETmNrNmJ4citrVEZ6bnFVQm5ubE5JQWdHWEpRcjdUNkJD?=
 =?utf-8?B?anZSYXZpeC9OODhBMEZzY01GTHhQL3hzWC9ER2hzR3lmd0dXcGUwd3BtUmJ1?=
 =?utf-8?B?cGZmaGkvSVpJZGZBU2lwS0lxUmxnY3gvWnRCZ3RTcE5UajNaRDJZM2pONFpt?=
 =?utf-8?B?S2l6c0V3Vm9rTm1RZzY2aWZVOEtsbllLQ1hHY3J5TENVYkgwNTRXQWplUHZ4?=
 =?utf-8?B?MEc3MlhGMWRBVGpCblVkUjJiZFlacHNwaU43TExpY0NLcjF4ZEFzclExRHFu?=
 =?utf-8?B?dU9LTU1kMkhOdHNYNzZ4R0dUNXVvNkVwbmRNaGlCL05lQW5lVjRqYjQ0dDZI?=
 =?utf-8?B?cVFFcTZuZmRxM0d1blUyMXA2cSsxMys4cWVkQTIyaTR4ekgzZTVuV3NDL2Fu?=
 =?utf-8?B?a0ZobU56bkN2UkhoUzBvaHZBb3d1MXgvOWZGOFhGMlA3ejdVdjgzTjdicjRp?=
 =?utf-8?Q?ZFyqYifuGgvvl8O+rYfoSAskf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50e61fa7-7a02-47e1-78ca-08daa6c8f3a6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 11:58:43.9664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZvMw+u1YU6ueMJhXqnCrvVHZujnINUH3CiUhAw21AisbqUUn15M248WkyNbedhrlaWw5mq4N3PHL1Nhy3a5Pcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8990
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05.10.2022 13:02, Juergen Gross wrote:
> Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
> of read/write MSR in case the MSR access isn't emulated via Xen. Allow
> the caller to select that faults should not be recovered from by passing
> NULL for the error pointer.
> 
> Restructure the code to make it more readable.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>