Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Oct 2022 08:48:39 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>, iommu@lists.linux.dev,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] iommu/s390: Fix duplicate domain attachments
Message-ID: <Yz1vF7B0FLvLVvE0@nvidia.com>
References: <20221004120706.2957492-1-schnelle@linux.ibm.com>
 <20221004120706.2957492-2-schnelle@linux.ibm.com>
 <2a56d7bc-3beb-51fe-fc65-f2f3bd192e34@linux.ibm.com>
 <dd92817a13601a4a449096b7ae94caa66a113853.camel@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dd92817a13601a4a449096b7ae94caa66a113853.camel@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dy6n0A34T+SJS+Qu5BX6+jJ/VewlLoRVyHXSZNKQLMqep6cff5udAmu3JaTE?=
 =?us-ascii?Q?VRo8ipsqW9NwvngOhlJuK9SDmFXtc8Hsa6rbOwJoU9mHKcsNb5BwL9TmFiyK?=
 =?us-ascii?Q?193t/Jw2wKsXVCdn74zhsoMpdJ4DSNLnSGeVvA/V898FbgKdm6LY9LmWHZxK?=
 =?us-ascii?Q?2+7TMP1prWvC7usbtIGLpw25mByVGozC+bQMwqDhlKrwzN3Tz/lKuwAnX5Qp?=
 =?us-ascii?Q?WbjMvy4lwjv7jCOfqwL1TwGcclIIdNzdNn4bf++YNnxuPrvZsO6WPRYB2ekc?=
 =?us-ascii?Q?XdcZxD6Gemnt+AIpGx3ctUF4yDETUOWM25cKFPwiWA2PSFvfnhzXeOybvlnc?=
 =?us-ascii?Q?5Cf0EYUiqkGhKPlgg+8zyg0+QlI5mnD5/+m/jkwOZCbuT41+zb5R4H56+dsh?=
 =?us-ascii?Q?qwFKuIL7JwLXmxCZlccD/Tl17hoght2/amn4nbjBgtjg122ElG986/pnKjAc?=
 =?us-ascii?Q?x1DtlAnDa7WUaghbXXbdsDA6s8hniG3bml6NNh5REeLjw6cD/XS8HB8qfY9O?=
 =?us-ascii?Q?rTTv5/b6qC5LOx+3mcaZ8C0zfLi6VYiN65DM8a1fs5t6krEdyOymgsVw28+N?=
 =?us-ascii?Q?yNwA+WTYeOiXjn7DAew9pAnWn+9kXudWkF/2wduJtrKg+7srhBDOMRNBYxZC?=
 =?us-ascii?Q?ofF5QspKY6ymBr38/EhZei0Ld/kZw3H0jZvLYm6yDUastZ+T6+LV2VsXfuN7?=
 =?us-ascii?Q?tjw9PUETmI5db4v3RAIS3yrn1pgu6/UbgCZihv4vX4lbxDdS9xZBX0dw//DG?=
 =?us-ascii?Q?NTjbSsg7fFIHiNIOU9emZziSLJQKeRhrRGNHDhRxfMUmEPtprRG2NcMJFcxW?=
 =?us-ascii?Q?eCDhTyK2koPpZhMGs+cbwuxeidiVLQKQIoldG1zZwKWicRe733U6HpTo7Ejn?=
 =?us-ascii?Q?+dE0YvkZLXwyrP+RumYS2OYsKcn5GR7NdpLurLRuuV00D+BkpHgG0+tH8Bu+?=
 =?us-ascii?Q?zWy0c9zYbEhJd6dnoXIfxBvYsHGiw4fTni9/HzIvWCC7CBArYtLQDQHh67Rf?=
 =?us-ascii?Q?nFio49sQ+3URwN6KaTadUyaQzAs/7Sj1Lsu8uZ92lN1msYACjvKI8v+/iBN+?=
 =?us-ascii?Q?wQ8s40rmAntvdWQbF2lNjnSp2e5qc7xuZtPQmVIeLx/5eMLybwlfHlxz7v80?=
 =?us-ascii?Q?XOXRoX58unzFUyDL2FPP+CRlEN4mj2h1m5ZHyh/AmHy3IBL296yNlEnPtV/0?=
 =?us-ascii?Q?8+N2bDCLS+wPjSDj29UzDdY8W7jEJYejSq300Sa6Vx8fNLu22iDFwo0RrZCX?=
 =?us-ascii?Q?bGHMJ3496NkBBrpHQktZuVnkmJg0UXjz6+52lafxBrWPacqUwTKbAUGVBFMB?=
 =?us-ascii?Q?TL2BQHYjpituuVhuXQGr1I7uH1ZsmxbFN+V3QJWIPMuYjueli/r2k48dDvqu?=
 =?us-ascii?Q?twHVEvme9E7QmzVpICLsu8w38IvAD2xwzIcAwUxmHcuauu78vVDzAiR0ONhN?=
 =?us-ascii?Q?L5yuEXZkBnd8mpCjR/SsvlSCa6U+Hn0xXvaubtq/sSkvQKzEz7QDcIgtniN5?=
 =?us-ascii?Q?iqGWxEuBfjmsMivF3Mw0u6W21pKDGpSCUd0UHosOBfgonEuxIrUuEEacG+Iu?=
 =?us-ascii?Q?o0M6BuapyNbW0twpStA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0144ae23-416c-48af-999b-08daa6c78ef9
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 11:48:45.5177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CuZ/oY6nN5et42CI06PNMZIohXSR1j52fi7L3n/QyM8+t7l1SCc7vTxRDgoY29SA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6534
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 05, 2022 at 09:58:58AM +0200, Niklas Schnelle wrote:

> A failed aperture test leaving the IOAT registered would indeed be bad.
> I guess I focused too much on the failure scenarios at the state after
> these patches where this can't happen. I think this would leave us in a
> bad state because zpci_register_ioat() succeeded with the domain's DMA
> table but we won't have attached leading to the wrong decisions in
> recovery paths (see below).

Domain attach should either completely move to the new domain and
succeed, or it should leave everything as is and fail.

So it looks OK to me.

> Recovery (via zpci_hot_reset_device()) should then be able to deal with
> these situations as long as zdev->dma_table matches the IOAT
> registration state.

If you are doing reset the s390 driver should keep track of what
domain is supposed to be attached and fix it when the reset is
completed. In this case it should not fail attach here for the
mandatory success domain types.

The core code does not reasonably handle failures from this routine,
it must be avoided if you want it to be robust.

Jason