Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9677f39a-5297-bb1c-d4e3-62484ec1cf25@nvidia.com>
Date:   Wed, 5 Oct 2022 14:52:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 2/4] ALSA: hda: Rework snd_hdac_stream_reset() to use
 macros
Content-Language: en-US
To:     Takashi Iwai <tiwai@suse.de>
Cc:     =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Mohan Kumar D <mkumard@nvidia.com>
References: <20220818141517.109280-1-amadeuszx.slawinski@linux.intel.com>
 <20220818141517.109280-3-amadeuszx.slawinski@linux.intel.com>
 <657d2418-0c3e-296f-8f4a-dc10ced2dffe@nvidia.com>
 <87a66av4gk.wl-tiwai@suse.de>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <87a66av4gk.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHpSK213b0syKytoSVBYVUsxQ3BnbHVYT0UzazJDQVBIWWVVZHBWVm44RmdL?=
 =?utf-8?B?c1ZwY2NIUGgvc2tWdnlqZFVrdnF5MDRzSW9va0F5VWloMEorS3pQREt6bi8r?=
 =?utf-8?B?SWg4UTRYSnBTdEkzTTVlcVh1czVoeE5uUnpuaEFMYU9UV1JBSzYxbzJOemJq?=
 =?utf-8?B?cW5hWGoxL0xJYUxTS21KdHNOb2xCdkhjVG1hSTEzYVZxTmF1OEhGQWVTRWJW?=
 =?utf-8?B?YXYzeVNTbzd4YUMvL1ZWS3RoQkhBdC8zaHhTV2VPc05peHo4VmxFd3BQYWFs?=
 =?utf-8?B?bXFFTElvL3F5MGZpQ1lLb2tYbUtub3g5bm9pUkx6TFc4VjBhbTVRdUpIeVBv?=
 =?utf-8?B?dnFvMitMb3lLWjhyWE9qTmR3bHZXUCtsOUppd1JTWCs3YzdFek96M0hoMFNs?=
 =?utf-8?B?WWV0ekYyTElweE4wdjN3MTdrcGE4TS9IbTI0dHE3OU82dVZiU3M4TmlDSW9R?=
 =?utf-8?B?R0ZkV1JSaHNSMUxMbGczandKV0kyUHZOU201ZElnNDZjbTJQdDBYRGFrVlBL?=
 =?utf-8?B?azhqYnR6dUZlQktmVWxxWGhvYVorWnN2ZVl0Z0FURUk5ZkNnbXVsZUNIMGZS?=
 =?utf-8?B?TVplWjdkTUZ0K3hTM3dkc3JZM293Vmc3SHdWWlJYbzFVZWRpSnJCSUVwWFhQ?=
 =?utf-8?B?SXFQQW1tZGU3SXJzbmNZSDVjMEtLcE9ucGF4VmR2TERidDhLOUg4azJJTEhE?=
 =?utf-8?B?NEVPNWVlVFB0cXBjM2twRzFJWERQMzhzRHRoZ05MUE1tUmZMZmIzQ0lXajcz?=
 =?utf-8?B?UnEzZXJFWjFFLzQzUkZVZHltNEFNeGQ0WXArZHBMaUo4bWdRbjdPcnAva25k?=
 =?utf-8?B?SndoWWY5b3pKcjhxTkVlV1RHeE55SWdrTHE0c25WMkZ1Tk9oTHA2RnpQNEJp?=
 =?utf-8?B?eHF6Q2xDZjhhL1NmaGpJY3hEMFRXaGQ0WVBwY1V1NkVPdFAwWGFDRmJlV0po?=
 =?utf-8?B?SmpPNytucktCaUtjeldlQUZOcERTUjRmUExBNnVtQlJ5cEozWXRLZlEveno5?=
 =?utf-8?B?ZEhjNmtXb0JIdlpYUnFQcUxOV211U2xjaDc2Szd6dG9YdU9sV0M5Z2YrdVRN?=
 =?utf-8?B?aTcyYUJWWlYwMXQxSTc0Y2JnSFQ1bjZhV1VEVXc4V0lzSFFqano3Qk1WbGNO?=
 =?utf-8?B?WitaVHNTS2ViMGpKbEt0TVA1bHJBSVU3M1o4YzZTMDV6Tlc5NkpsckxZMlp5?=
 =?utf-8?B?N0dpbitpeUY0bmV1Nk9Nc2ZRSmd3RUlZQjVVNXMrVW5ySUxiL09tbExoc3RV?=
 =?utf-8?B?VnpjSWY1NWFGV3lVNEJsZHhlbko0eWIxQjgvZlFYT0tJNTNNTkxram1tVlBn?=
 =?utf-8?B?NThMQTdzdVJKNnhJdGpaYUdZVkxMMGVmQ3BuazBNYUxaUGhIc2VRU0k5K1Ra?=
 =?utf-8?B?RjJMNXFlWFhmdUhDR3d6ZVFBNjJGMXJqQ0FYZjNaU1c0TWxpakxwYjYxV3da?=
 =?utf-8?B?YTloK0Z5WXBpaXA0Yy82YnJyYU9ENmVWMFJHMHVzWEo1U0Z6eW9IR0J5WHRn?=
 =?utf-8?B?anBwMWRNZ1pNUmxwakFOY3ZLWlh5Q0FLQVlUSEpVcTlPcm1JbGtiQ3dtWmVH?=
 =?utf-8?B?WGs3UTRPMnNaQjZrbitSbDJhQktPdjRYUU1EeVB3ak1HdGt3NVZ1ZC80cmlX?=
 =?utf-8?B?SnV1M1prRmRoUGxYakVnYUhhaFVianJmRGRLUjhWbitmRjNzdHNZOFUzemF2?=
 =?utf-8?B?d1BheDkvR3ZuSWIraWFDZzJJK0FFaVdjSnRDajRyY29naVZJby9oMndnWnpm?=
 =?utf-8?B?YlMwVVByU2ZwRG41WjIwWmx3VmdGS3JwNlpLSHRRdVNXYnQwRDQyOGFBazIy?=
 =?utf-8?B?MHE1K2NzRCtBMFJuczRxL2hweDAzcnhTQmpMWWpYalE0RnJqaWNNU081WnFT?=
 =?utf-8?B?OUdZdzZoc043Nys4OEdWTEd3WnRDUzRuK2o1YkVGU0JEeTlkNG5GVVd3eGYx?=
 =?utf-8?B?Q1kvazVnQTNidjFEdDB2Y3NhSFpqUDFSblBBLzAxTXNqUkRSOWZ1WUIzTW9y?=
 =?utf-8?B?QXJXOXgyN1dKd0JTSzJkSElSVUIvdHFsQTBYMEMza0ZtcjUzeEFoYk1QOFJO?=
 =?utf-8?B?NGwyOUJ3QlEwNUcyKyt6OUZ5WWd5eHRsY243M3RjSTIxdzB4K29CSGp6bmw3?=
 =?utf-8?B?a0R1cG1STmdBcDMwZ210ZEMxMnhVeVVDSUdSTHo2b2VVMzgrS0dRb3piU0V6?=
 =?utf-8?B?b2pOazhxd3dQd0VWcW1YbHl6RUc4OWMvSHBia25IUmQvbWdnR0Y5TzNPN0pn?=
 =?utf-8?B?OC93SVNieHMxWTJIWkc2b0V6Wk9nPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb02c4d-2ace-4708-cb65-08daa6d8cdb1
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 13:52:12.2985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NFxwP9hNiyW11Ft/eLFmjHg8OXCzatfN4ppKME7pcG2qZel4ELIf9y8ITfsmTXMeRq+LJoAdZB9IWxDOWBT3HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05/10/2022 13:29, Takashi Iwai wrote:

...

>> HDA playback is failing on -next for various Tegra boards. Bisect is
>> point to this commit and reverting it fixes the problem. I was a bit
>> puzzled why this change is causing a problem, but looking closer there
>> is a difference between the previous code that was calling
>> snd_hdac_stream_readb() and the new code that is calling
>> snd_hdac_stream_readb_poll(). The function snd_hdac_stream_readb()
>> calls snd_hdac_aligned_mmio() is see if the device has an aligned MMIO
>> which Tegra does and then would call snd_hdac_aligned_read(). However,
>> now the code always call readb() and this is breaking Tegra.
>>
>> So it is either necessary to update snd_hdac_stream_readb_poll() to
>> handle this or revert this change.
> 
> Does the patch below work?
> 
> 
> thanks,
> 
> Takashi
> 
> -- 8< --
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -592,8 +592,8 @@ int snd_hdac_get_stream_stripe_ctl(struct hdac_bus *bus,
>   #define snd_hdac_stream_readb(dev, reg) \
>   	snd_hdac_reg_readb((dev)->bus, (dev)->sd_addr + AZX_REG_ ## reg)
>   #define snd_hdac_stream_readb_poll(dev, reg, val, cond, delay_us, timeout_us) \
> -	readb_poll_timeout((dev)->sd_addr + AZX_REG_ ## reg, val, cond, \
> -			   delay_us, timeout_us)
> +	read_poll_timeout(snd_hdac_reg_readb, val, cond, delay_us, timeout_us,\
> +			  false, (dev)->bus, (dev)->sd_addr + AZX_REG_ ## reg)
>   #define snd_hdac_stream_readl_poll(dev, reg, val, cond, delay_us, timeout_us) \
>   	readl_poll_timeout((dev)->sd_addr + AZX_REG_ ## reg, val, cond, \
>   			   delay_us, timeout_us)


Amazingly it does not work. I would have thought that would, but it does 
not. I am a bit puzzled by that?

Jon

-- 
nvpublic