Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1986716rwb; Wed, 5 Oct 2022 07:36:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5nNHTaBsPI8kkfQotUY70ciOawQYFfAYvwCJa+aCL0e9AqtgkS6fTT1uRQS7GvYYLBc9Qg X-Received: by 2002:a17:907:3e01:b0:730:a690:a211 with SMTP id hp1-20020a1709073e0100b00730a690a211mr23503870ejc.596.1664980575572; Wed, 05 Oct 2022 07:36:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664980575; cv=none; d=google.com; s=arc-20160816; b=vj2nAfF3plxC6i20Yv22zIgmtuMLQBg3Ysg4DsEyU8gdpIBrjhVRIBB1Yo3n2jmzcT o192OUhEEZpZnoMMCJBopldSCHwTgqQSduNOBZRXfC3L1x51Wqre/5hDmWK1Ppqtgom6 n636HCxKUeZbj1isivaIKoNA6p3oXxJXmmlexcVhg/FVdVu2eirtYHnMJFlGPj8HjdLh UGs01hZkcr1qU3XLGzNokSa+XT7BDlsgQvCbA3wxRHUw5uGj0gloprvF5YGcEIp3IzL/ cIWQMSsTDMU0nhEM8+msy+7fRhchmYgEvYaFfcOPrauOuRVWiOC744pdwuMa6MhUYJ5F Fj3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=nzoOOPt3rGRHE6vpkEA1gtCwMT1bHi2fUQTRfwEoWTw=; b=hYiUpARiHOkT1MnJw0JRB6xgOc7L+J1xKHK5yOsmEn4rwSNuf103PYfJJO5tUWk2FS WutACWtgF7DF1X+JdG6nGulgm8bOVSn6uXC03CXhJKWuet8HjzZaY9qt8T29NE7KMDX0 +p/x/3WdWooz6brU3U8pef4VMAh1zo6CDZLxWV6UgvKX7Fi8E1luKX8fcgQW37G3ut3B n3NkQgnSmYKyqRu/kMLTSTN8C9aucp6LEmjuy6w+gv8YkpfLZaG+gw6//o8fKSWfN8G0 g98nR3+9t8Pb7RyQxgouYuLvhHu5rXkOoCWs3SU7VAPUDgb1cOzHHBYPllkqXtjd4O9g SVvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz12-20020a1709077d8c00b007891fd9179bsi12099676ejc.150.2022.10.05.07.35.50; Wed, 05 Oct 2022 07:36:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbiJEONW convert rfc822-to-8bit (ORCPT + 99 others); Wed, 5 Oct 2022 10:13:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbiJEONT (ORCPT ); Wed, 5 Oct 2022 10:13:19 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F778786CA for ; Wed, 5 Oct 2022 07:13:18 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-277-pbZ9B6vQOZqIfuygrqUt7Q-1; Wed, 05 Oct 2022 15:13:15 +0100 X-MC-Unique: pbZ9B6vQOZqIfuygrqUt7Q-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 5 Oct 2022 15:13:13 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.040; Wed, 5 Oct 2022 15:13:13 +0100 From: David Laight To: 'Enzo Matsumiya' , Muhammad Usama Anjum CC: Steve French , Paulo Alcantara , "Ronnie Sahlberg" , Shyam Prasad N , "Tom Talpey" , "kernel@collabora.com" , "kernel-janitors@vger.kernel.org" , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/2] cifs: remove initialization value Thread-Topic: [PATCH 1/2] cifs: remove initialization value Thread-Index: AQHY1/zYsp5T2i23xkGOtbqlLehPIK3/2DFg Date: Wed, 5 Oct 2022 14:13:13 +0000 Message-ID: References: <20221004062333.416225-1-usama.anjum@collabora.com> <20221004142306.ysgh45nhgdo4z3ok@suse.de> In-Reply-To: <20221004142306.ysgh45nhgdo4z3ok@suse.de> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enzo Matsumiya > Sent: 04 October 2022 15:23 > > Hi Usama, > > On 10/04, Muhammad Usama Anjum wrote: > >Don't initialize the rc as its value is being overwritten before its > >use. > > Being bitten by an unitialized variable bug as recent as 2 days ago, I'd > say this is a step backwards from the "best practices" POV. Depends on your POV. If you don't initialise locals there is a fair chance that the compiler will detect buggy code. If you initialise them you get well defined behaviour - but the compiler won't find bugs for you. Mostly the kernel is in the first camp. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)