Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221005133120.50483-1-olivier.moysan@foss.st.com> <20221005133120.50483-4-olivier.moysan@foss.st.com>
In-Reply-To: <20221005133120.50483-4-olivier.moysan@foss.st.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 5 Oct 2022 17:56:15 +0300
Message-ID: <CAHp75VffeeP+_nX86faEbnJFH51kGA2fUcJgqp1_U8EsbRrD9w@mail.gmail.com>
Subject: Re: [PATCH v2 3/8] iio: adc: stm32-adc: add stm32mp13 support
To:     Olivier Moysan <olivier.moysan@foss.st.com>
Cc:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        nuno.sa@analog.com, Paul Cercueil <paul@crapouillou.net>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Yannick Brosseau <yannick.brosseau@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 5, 2022 at 4:36 PM Olivier Moysan
<olivier.moysan@foss.st.com> wrote:
>
> Add STM32 ADC support for STM32MP13x SOCs family.
>
> On STM32MP13x, each ADC peripheral has a single ADC block.
> These ADC peripherals, ADC1 and ADC2, are fully independent.
> This introduces changes in common registers handling.
>
> Some features such as boost mode, channel preselection and
> linear calibration are not supported by the STM32MP13x ADC.
> Add diversity management for these features.
>
> The STM32MP13x ADC introduces registers and bitfield variants
> on existing features such as calibration factors and internal
> channels. Add register diversity management.
>
> Add also support of new internal channels VDDCPU and VDDQ_DDR.

for new

I have a d=C3=A9j=C3=A0-vu that I have pointed out all these...

...

>         struct stm32_adc *adc =3D iio_priv(indio_dev);
>         int ret;
> -       u32 val;
> +       u32 val, msk =3D STM32H7_ADCALDIF;

It's better to split and reorder like

       struct stm32_adc *adc =3D iio_priv(indio_dev);
       u32 msk =3D STM32H7_ADCALDIF;
       u32 val;
       int ret;

...

>  static const struct of_device_id stm32_adc_of_match[] =3D {
>         { .compatible =3D "st,stm32f4-adc", .data =3D (void *)&stm32f4_ad=
c_cfg },
>         { .compatible =3D "st,stm32h7-adc", .data =3D (void *)&stm32h7_ad=
c_cfg },
>         { .compatible =3D "st,stm32mp1-adc", .data =3D (void *)&stm32mp1_=
adc_cfg },

> +       { .compatible =3D "st,stm32mp13-adc",
> +         .data =3D (void *)&stm32mp13_adc_cfg },

For the sake of consistent style I would put this on a single line.

>         {},
>  };


--=20
With Best Regards,
Andy Shevchenko