Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Oct 2022 08:44:08 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add
 ocelot-ext documentation
Message-ID: <Yz2mSOXf68S16Xg/@colin-ia-desktop>
References: <20220926002928.2744638-1-colin.foster@in-advantage.com>
 <20220926002928.2744638-13-colin.foster@in-advantage.com>
 <ec63b5aa-3dec-3c27-e987-25e36b1632ba@linaro.org>
 <YzzLCYHmTcrHbZcH@colin-ia-desktop>
 <455e31be-dc87-39b3-c7fe-22384959c556@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <455e31be-dc87-39b3-c7fe-22384959c556@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ARTYC+waE/tMJbHaZgv5lC4Vv8si4n8wbdI7Vhwdt1Waxk35rfZXNmtSVsHe?=
 =?us-ascii?Q?Qiz8GoUZ7Vd+uqZonWdDsqlTwzAGH0v6IRpo+Rm5Lkf5xobqYb/605vnDBcf?=
 =?us-ascii?Q?r64jnLP0lLtxiIAKU04uIJdRNS4G/zf+dIu5a3rL5sUu4B0JowhKRlCPC4UU?=
 =?us-ascii?Q?G2H81TpebddthPKKZCBO6BNnuRN2zjQDX8KSR603utLLL8xNV/2tUNKYHhqU?=
 =?us-ascii?Q?Wn0nryhY22NegWiv39O55mVm5LmwHsajth8AHAsYfrt5Gf4keeH8OEgaof9O?=
 =?us-ascii?Q?BResv2w+TETjVOk53yISoonvjjLTmE0tNJzN85NNpmbcM7rivYB42XUmRwjn?=
 =?us-ascii?Q?ws6jAGNsxsJqhqER11roP7c//OQLoHGX+oNNEmbzzjaLw1rstBjOJHZ5Ipqd?=
 =?us-ascii?Q?WdUB1Wx29GsOy2r7nc4X6QSbHeMq3DSWAI+j2BGnEKVcEtQFO/q5TyE2AjxK?=
 =?us-ascii?Q?n6DGRgQ8xYgtiIwGXk6M3C7n8BFNDrkuQwCBd3wakPi1kKg6lSiD6GiGVzVd?=
 =?us-ascii?Q?FuBQ7NdAuhPjnBu4MukymoVj9KGyIf9Rzv5IkiPwkgxr3fmrg/XMo8iLBFwa?=
 =?us-ascii?Q?0+BZfdYUSmf1YJ+dvMUCHTRKEzoTfcRajLBDRuMXothKIcnat3nadnAwE4+K?=
 =?us-ascii?Q?024kAH4ykZ+yWiNQm1100enR/wloWT+NivoC5ZB9K1/Qpr1wltnrv7QBd7OO?=
 =?us-ascii?Q?ESSGtgrqQKyLB6KRwSgGin6SKe0KUW8p/YPQMKABXVbNNorqxwrlgngCoBzV?=
 =?us-ascii?Q?EJD0tsX/sjW3GnW2N5GGcOteieOuqDBDPxYXa8rd6CuAzUPPx90QViVnod13?=
 =?us-ascii?Q?b1ii8df0THL/q4/Dq4mdUp6PPF8UJiHe9sRm/SYRaZzyT3Hk4J+zRvFIU+Ze?=
 =?us-ascii?Q?xTqGg6Fk6B6t3/OcfCA/TPLSZO5st+nGsxx0xIJD3PoIynNtBVB8KAqtsSA2?=
 =?us-ascii?Q?oEIrE9peweeTgY9JdXdi6MdkbGzLrggr6WuoQ1y/2aDM5qy1cRxhhHRUVvOd?=
 =?us-ascii?Q?mMfklR+t/Z0yVirvhCdYVel09PzYvJacJg05AhWjIA66jQXdUgU8M7eCQNdo?=
 =?us-ascii?Q?TGYgutFyRCVaxaORrYFb4R+fGhBxEmH5yN/S4v+Va9ASp5Z2WGaVsh6dL2Bv?=
 =?us-ascii?Q?AFEwdqHwt4hnwztyS0W//H45AnsG/MM2h4CLprc/LJATqBQ1Hxr58NE53n0x?=
 =?us-ascii?Q?DH+5gXaEAVDCC4eXmNvtp6xus9muZJzHg8iPLwMcsImuzo/SbXOPuPF4NSs2?=
 =?us-ascii?Q?tMKIX853Mbhd1raAOlx024VVr6asv3NknuhEYMJKUJ0FHnQuUTI8iUmqaG91?=
 =?us-ascii?Q?JlFtqdmOp/suFT90t0BaPnzd/khVcA55OP2g4Na7Cz4BneKXYRfUYitbSOLp?=
 =?us-ascii?Q?0zvlCJw+7WyJJoAyv/29680h7Axs5BboOJLrdVii4AfDX9izgkezflDbTBnP?=
 =?us-ascii?Q?m650hKIYyBQ2V0EdxNVYftFJLG6DSuFZV0QjPtE9qAB47h4jiD35Ug1QZWl5?=
 =?us-ascii?Q?/By22C59DrXDzuWCzBIZuzyumFjYnkAe16BIiy1jPAz2+A2ftjEqVIZ6A1pJ?=
 =?us-ascii?Q?SZHUGExOLgkiScBgW8mSvOoRMgOkajlifxx6MKUcIsFFiXhYmnUcNC98nIKG?=
 =?us-ascii?Q?Gg=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1eadd62-5053-4055-6725-08daa6e873f1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 15:44:14.1201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IO5slTHsoTTrI6PWRYWCAWEaeFioIOBz0gcFzl1IZktBy+mfsru++k116Lm/scFLDTFsBLHk2kP6J071g7cYsabgtQ2rXQjaFZJs2act2QA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5173
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 05, 2022 at 10:03:04AM +0200, Krzysztof Kozlowski wrote:
> On 05/10/2022 02:08, Colin Foster wrote:
> > Hi Krzysztof,
> > 
> > On Tue, Oct 04, 2022 at 01:19:33PM +0200, Krzysztof Kozlowski wrote:
> >> On 26/09/2022 02:29, Colin Foster wrote:
> >>> The ocelot-ext driver is another sub-device of the Ocelot / Felix driver
> >>> system, which currently supports the four internal copper phys.
> >>>
> >>> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ...
> >>> +  # Ocelot-ext VSC7512
> >>> +  - |
> >>> +    spi {
> >>> +        soc@0 {
> >>
> >> soc in spi is a bit confusing.
> >>
> >> Does it even pass the tests? You have unit address but no reg.
> > 
> > I omitted those from the documentation. Rob's bot is usually quick to
> > alert me when I forgot to run dt_binding_check and something fails
> > though. I'll double check, but I thought everything passed.
> > 
> >>
> >>> +            compatible = "mscc,vsc7512";
> >>
> >>
> >>> +            #address-cells = <1>;
> >>> +            #size-cells = <1>;
> >>> +
> >>> +            ethernet-switch@0 {
> >>> +                compatible = "mscc,vsc7512-switch";
> >>> +                reg = <0 0>;
> >>
> >> 0 is the address on which soc bus?
> > 
> > This one Vladimir brought up as well. The MIPS cousin of this chip
> > is the VSC7514. They have exactly (or almost exactly) the same hardware,
> > except the 7514 has an internal MIPS while the 7512 has an 8051.
> > 
> > Both chips can be controlled externally via SPI or PCIe. This is adding
> > control for the chip via SPI.
> > 
> > For the 7514, you can see there's an array of 20 register ranges that
> > all get mmap'd to 20 different regmaps.
> > 
> > (Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml)
> > 
> >     switch@1010000 {
> >       compatible = "mscc,vsc7514-switch";
> >       reg = <0x1010000 0x10000>,
> >             <0x1030000 0x10000>,
> >             <0x1080000 0x100>,
> >             <0x10e0000 0x10000>,
> >             <0x11e0000 0x100>,
> >             <0x11f0000 0x100>,
> >             <0x1200000 0x100>,
> >             <0x1210000 0x100>,
> >             <0x1220000 0x100>,
> >             <0x1230000 0x100>,
> >             <0x1240000 0x100>,
> >             <0x1250000 0x100>,
> >             <0x1260000 0x100>,
> >             <0x1270000 0x100>,
> >             <0x1280000 0x100>,
> >             <0x1800000 0x80000>,
> >             <0x1880000 0x10000>,
> >             <0x1040000 0x10000>,
> >             <0x1050000 0x10000>,
> >             <0x1060000 0x10000>,
> >             <0x1a0 0x1c4>;
> >       reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
> >             "port2", "port3", "port4", "port5", "port6",
> >             "port7", "port8", "port9", "port10", "qsys",
> >             "ana", "s0", "s1", "s2", "fdma";
> > 
> > 
> > The suggestion was to keep the device trees of the 7512 and 7514 as
> > similar as possible, so this will essentially become:
> >     switch@71010000 {
> >       compatible = "mscc,vsc7512-switch";
> >       reg = <0x71010000 0x10000>,
> >             <0x71030000 0x10000>,
> >       ...
> 
> I don't understand how your answer relates to "reg=<0 0>;". How is it
> going to become 0x71010000 if there is no other reg/ranges set in parent
> nodes. The node has only one IO address, but you say the switch has 20
> addresses...
> 
> Are we talking about same hardware?

Yes. The switch driver for both the VSC7512 and VSC7514 use up to ~20 regmaps
depending on what capabilities it is to have. In the 7514 they are all
memory-mapped from the device tree. While the 7512 does need these
regmaps, they are managed by the MFD, not the device tree. So there
isn't a _need_ for them to be here, since at the end of the day they're
ignored.

The "reg=<0 0>;" was my attempt to indicate that they are ignored, but I
understand that isn't desired. So moving forward I'll add all the
regmaps back into the device tree.

> 
> Best regards,
> Krzysztof
>