Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221004204025.7be8a3be@canb.auug.org.au> <20221005173904.12540ffe@canb.auug.org.au>
In-Reply-To: <20221005173904.12540ffe@canb.auug.org.au>
From:   Alexander Potapenko <glider@google.com>
Date:   Wed, 5 Oct 2022 18:54:38 +0200
Message-ID: <CAG_fn=VLGmRn85V-yG-6Dtq71_f-7wpYiG2RyjBDgKj0NAe7-Q@mail.gmail.com>
Subject: Re: linux-next: manual merge of the mm-stable tree with the kspp tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 5, 2022 at 8:39 AM Stephen Rothwell <sfr@canb.auug.org.au> wrot=
e:
>
> Hi all,
>
> On Tue, 4 Oct 2022 20:40:25 +1100 Stephen Rothwell <sfr@canb.auug.org.au>=
 wrote:
> >
> > Today's linux-next merge of the mm-stable tree got a conflict in:
> >
> >   include/linux/fortify-string.h
> >
> > between commit:
> >
> >   9f7d69c5cd23 ("fortify: Convert to struct vs member helpers")
> >
> > from the kspp tree and commit:
> >
> >   ff901d80fff6 ("x86: kmsan: use __msan_ string functions where possibl=
e.")
> >
> > from the mm-stable tree.
> >
> > I fixed it up (see below) and can carry the fix as necessary. This
> > is now fixed as far as linux-next is concerned, but any non trivial
> > conflicts should be mentioned to your upstream maintainer when your tre=
e
> > is submitted for merging.  You may also want to consider cooperating
> > with the maintainer of the conflicting tree to minimise any particularl=
y
> > complex conflicts.

Looks good, thanks for handling this!

> >
> > diff --cc include/linux/fortify-string.h
> > index b62c90cfafaf,6c8a1a29d0b6..000000000000
> > --- a/include/linux/fortify-string.h
> > +++ b/include/linux/fortify-string.h
> > @@@ -325,11 -282,13 +325,13 @@@ __FORTIFY_INLINE void fortify_memset_ch
> >   })
> >
> >   /*
> >  - * __builtin_object_size() must be captured here to avoid evaluating =
argument
> >  - * side-effects further into the macro layers.
> >  + * __struct_size() vs __member_size() must be captured here to avoid
> >  + * evaluating argument side-effects further into the macro layers.
> >    */
> > + #ifndef CONFIG_KMSAN
> >   #define memset(p, c, s) __fortify_memset_chk(p, c, s,                =
       \
> >  -            __builtin_object_size(p, 0), __builtin_object_size(p, 1))
> >  +            __struct_size(p), __member_size(p))
> > + #endif
> >
> >   /*
> >    * To make sure the compiler can enforce protection against buffer ov=
erflows,
>
> This is now a conflict between the mm-stable tree and Linus' tree.

Anything else we need to do specifically for Linus' tree?

> --
> Cheers,
> Stephen Rothwell


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg