Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <b23c765b-4999-17a4-d89a-55d6ba72f68d@redhat.com>
In-Reply-To: <b23c765b-4999-17a4-d89a-55d6ba72f68d@redhat.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 5 Oct 2022 10:40:45 -0700
Message-ID: <CAHk-=whDpj0wAwFK8tDjVUkRoT06ZD-d+OQpojodPPqE_eEcHg@mail.gmail.com>
Subject: Re: [GIT PULL] platform-drivers-x86 for 6.1-1
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Andy Shevchenko <andy@infradead.org>,
        Mark Gross <mark.gross@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        linux-acpi <linux-acpi@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 5, 2022 at 5:46 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> There also is a small conflict in drivers/platform/mellanox/mlxreg-lc.c
> due to a locking fix which landed mid 6.0 mixing unlock + return with
> goto style exits in error paths. My tree has a fix on top to consistently
> use the goto style. Here you can just take the version from me tree.

Ugh.

Why use goto when a simple 'break' would work for all but the first case?

I took your side rather than clean things up and not being able to
test the end result, but it does seem pointlessly complicated.

              Linus