Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e59c4bb7-d6fe-ed43-0bfd-124e3930260b@intel.com>
Date:   Wed, 5 Oct 2022 13:54:25 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.3.1
Subject: Re: [PATCH v2 3/4] selftests/resctrl: Remove duplicate codes that
 clear each test result file
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com>
 <20221005013933.1486054-4-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20221005013933.1486054-4-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEtkQmkrUVZ4cTl5b1pnRGFDbFBTY2xzTDFxb2d0NlhsdW5PN3Y4YU9xU3Nk?=
 =?utf-8?B?Vk9qOW5KNk5LVUsvc0ppeGdCU2pBdVJvOXVVaW1tRXdhbXR5Sm1mdkM5d1kr?=
 =?utf-8?B?UTJzT3YxNnhPRFlSWklYdDZMeWV3VlEzK2QrZmE3bFdoSDJEU0EwYU96c3Ro?=
 =?utf-8?B?NG9KQnMzWnY0c2NyRHByR2xGUk1mZWhPY0xzNS9GT29zK25xQUZITXlnb2RF?=
 =?utf-8?B?RTlwRGNsaFdWY1pTc0ZJZ09hYnB5NU9CVW95NEFTUUZiYmJpUVphZDNoMk1G?=
 =?utf-8?B?Nm5RVWJ4Um9aVWQwVE9ScTV2Q0FjR0hIMWxtWTVFYXVqeWZQUWZUMkw4TzRw?=
 =?utf-8?B?a09qeTF4NzE3V0x2V25mY0pUc09SN3lmSENvbWdVaGJtUlFWcmNyYTV6T28r?=
 =?utf-8?B?RVpLSkN0djRYMEZ4djg4R3pIRmllUjNGZGhhZUhnR2FVbFgxYWhhSTV4bWk5?=
 =?utf-8?B?aXNYN2JwYTZhRWszNzJ1Y3prNzJodE4wVHk4SExjbEtDMm9IZVhSS0JTc2t6?=
 =?utf-8?B?RmZCS1pzcS9zekdHcC9PQnVuNjVMSEJKL3N1em5DckxNV25tWGZNT2JsK3Z3?=
 =?utf-8?B?MnN4d1RWSW1YNkZLUzVUM2ZyWmtrVXJNblNiQ1dlVzFnQmxoeXdNeW5BWkI3?=
 =?utf-8?B?ZFJWdUUzd1RPOGo2aFpZcG9leHdlTlpFRlFDV1JHcjErUkw1bzRwN1hJWlJn?=
 =?utf-8?B?RmNaMzNIN1UxQWNxVG1IL3hTZUh1U2xMYjY3WXIzN2dBSXFQckVodXVjejd0?=
 =?utf-8?B?c01JZC82REcvdG5nZThlVU1TWmdlQXBpeks2RXorMFNXdWlySENXbWovVG9F?=
 =?utf-8?B?Q3VaOGFaeDZneG1Jb0lraWRDeHJ6NUpucHVXaFZIam56T2R1Z2svRFN3YVh3?=
 =?utf-8?B?MVYvQTA2UEtxaFlnNWIwYm8rVkRSUy9KVDRTQ0pXanFFbS9hb05zcFNjaWtx?=
 =?utf-8?B?Sm5tZ3FxQlN4MFNqZEgzMVorcUc4OVpoZUJiZE5mYU9RK0l6NDFSOFYwa1k4?=
 =?utf-8?B?TVg1b1AwQ1B0NVVSc1orcGtNdlZURWhESnh4cHBUWXhXRDZHaGxYZzU4ZEF4?=
 =?utf-8?B?ci96MGRwUVdyV2ZxWUt0d2ZhZWJMRnRnUk5ZOFlmZ2VCdHJLcU1OVkUvamNn?=
 =?utf-8?B?U1M1bDNjd3dxRmwxVVljbnIzbEl1NnMzd0VSVFNURHZLeUREaTNaK2NqZmY4?=
 =?utf-8?B?VmFnZERBSStyTU1ObjRIRUdKajEycXh4cy9qaWd4WDlKNzBQRS9OZEowaTFG?=
 =?utf-8?B?aFFFZWJRZFdKdngrY3g5QTJwbmhZTlgwdmw3UDgwNHhvVGlBOTRjL3FHN3ph?=
 =?utf-8?B?Wk5PTFRRNjExeVROODNqdlFBajd3bWV6WEk2Rlk3Q2dORTdLZFcybWhEVDhR?=
 =?utf-8?B?ZjhTVE8wajBmSjlkYndVMEpVRUwrYkdJR29ES1Jadk5LZTZxZ0pFL2YxRlB5?=
 =?utf-8?B?ak96d3lXK0h0WUxKQmRaYjJDaUczQ0xsREMwQjhCUDdQODRNSm1IaXRPODVX?=
 =?utf-8?B?N2ZzVEdEOTI2RVZZNzFYZHlHNkpVT3NFdTRtY1M0NkpCWXI5Z213WTM0ajA2?=
 =?utf-8?B?SWlUT29qUnNjMllka1d2SDVUV3RkSGFXU3NUUjBBMEZWdXNqZGNYTHQ3WWd3?=
 =?utf-8?B?MVRSWm5lZ254Y1RiNWs2RHc0VzhzckdSeDVTRkZMSkl1OVJQU1FubEhuRUlr?=
 =?utf-8?B?OGpOV0dPanM2WkZCK203RDhmaEREcm5uUUtpVlNZWnRkWEZTci9oVFA0MkhI?=
 =?utf-8?B?MEN2M0ROOGMwTCsrQStnUHlsTWFUakg0Z0UxVnZuN0EwMjM5V3BUb1FHbENF?=
 =?utf-8?B?N1JjRXoxTU1ZN21uRlY4Q3BFOWppQTZNaWF2a3BzYmhKRWdXSDkvN2V5a0ti?=
 =?utf-8?B?aGhGZG9iWmgrMU90ZTBUZ1ZkNVVNMHd6OTc1bDViZjdscG40SHlVb3JCRi9G?=
 =?utf-8?B?YW0zTnlIbnpFcjZRSkkxRGtITWttQXhncEdTNW5qbUF3Z1RROUswWTBudHhy?=
 =?utf-8?B?TjNlTUlvRnVpSTJ3N0ZYVmZDY2tjSmM0ZEQya2kzT2pCVVJyWUxFSnRIVnY3?=
 =?utf-8?B?a21BaUNCMDVLajhoakFMQlVWakZndElYT2svZDlQODV5RFJKRVRZRFUwSTNE?=
 =?utf-8?B?UnVRaysrQ3A0MEdZTWpWZFhyMk5xSkg0NFRlR2dxcHVzVWJhK3JDclhWRTd5?=
 =?utf-8?B?R1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 36289e60-6844-4ce5-f6ba-08daa713cb32
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 20:54:28.3865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3Se/aLDmjjZPf/l0MCpD7iCeRVEdsKbtqwrFhpsldUZVqvZr1qAV9bL7iQdxTy1pBxt4gXqHuOaLrirc0K4xkH57iGC9ZNdK5LOSFx8Jbc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 10/4/2022 6:39 PM, Shaopeng Tan wrote:
> Before exiting each test function(run_cmt/cat/mbm/mba_test()),
> test results("ok","not ok") are printed by ksft_test_result() and then
> temporary result files are cleaned by function 
> cmt/cat/mbm/mba_test_cleanup().
> However, before running ksft_test_result(), 
> function cmt/cat/mbm/mba_test_cleanup()
> has been run in each test function as follows:
>   cmt_resctrl_val()
>   cat_perf_miss_val()
>   mba_schemata_change()
>   mbm_bw_change()
> 
> Remove duplicate codes that clear each test result file.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index df0d8d8526fc..8732cf736528 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -88,7 +88,6 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, int span,
>  	ksft_test_result(!res, "MBM: bw change\n");
>  	if ((get_vendor() == ARCH_INTEL) && res)
>  		ksft_print_msg("Intel MBM may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
> -	mbm_test_cleanup();
>  }
>  
>  static void run_mba_test(bool has_ben, char **benchmark_cmd, int span,
> @@ -107,7 +106,6 @@ static void run_mba_test(bool has_ben, char **benchmark_cmd, int span,
>  		sprintf(benchmark_cmd[1], "%d", span);
>  	res = mba_schemata_change(cpu_no, bw_report, benchmark_cmd);
>  	ksft_test_result(!res, "MBA: schemata change\n");
> -	mba_test_cleanup();
>  }
>  
>  static void run_cmt_test(bool has_ben, char **benchmark_cmd, int cpu_no)
> @@ -126,7 +124,6 @@ static void run_cmt_test(bool has_ben, char **benchmark_cmd, int cpu_no)
>  	ksft_test_result(!res, "CMT: test\n");
>  	if ((get_vendor() == ARCH_INTEL) && res)
>  		ksft_print_msg("Intel CMT may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
> -	cmt_test_cleanup();
>  }
>  
>  static void run_cat_test(int cpu_no, int no_of_bits)
> @@ -142,7 +139,6 @@ static void run_cat_test(int cpu_no, int no_of_bits)
>  
>  	res = cat_perf_miss_val(cpu_no, no_of_bits, "L3");
>  	ksft_test_result(!res, "CAT: test\n");
> -	cat_test_cleanup();
>  }
>  
>  int main(int argc, char **argv)

I think this is the right direction ... but you fell into the trap that I
warned you about in https://lore.kernel.org/lkml/bdb19cf6-dd4b-2042-7cda-7f6108e543aa@intel.com/
- search for "please be careful".

Reinette