Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Richard Acayan <mailingradian@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Richard Acayan <mailingradian@gmail.com>,
        Lee Jones <lee@kernel.org>, linux-gpio@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl
Date:   Wed,  5 Oct 2022 18:23:50 -0400
Message-Id: <20221005222350.47420-1-mailingradian@gmail.com>
In-Reply-To: <1ed91afd-74d2-1ab0-0d15-1b6e0dfba13b@linaro.org>
References: <20221004215814.11694-1-mailingradian@gmail.com> <20221004215814.11694-4-mailingradian@gmail.com> <1ed91afd-74d2-1ab0-0d15-1b6e0dfba13b@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> On 04/10/2022 23:58, Richard Acayan wrote:
> > The Snapdragon 670 has a Top-Level Mode Multiplexer (TLMM) for various
> > features. Add a driver to support it.
> 
> (...)
> 
> > +
> > +const int sdm670_reserved_gpios[] = {
> > +	58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
> > +};
> > +
> > +static const struct msm_pinctrl_soc_data sdm670_pinctrl = {
> > +	.pins = sdm670_pins,
> > +	.npins = ARRAY_SIZE(sdm670_pins),
> > +	.functions = sdm670_functions,
> > +	.nfunctions = ARRAY_SIZE(sdm670_functions),
> > +	.groups = sdm670_groups,
> > +	.ngroups = ARRAY_SIZE(sdm670_groups),
> > +	.ngpios = 151,
> > +	.reserved_gpios = sdm670_reserved_gpios,
> > +	.complement_fw_gpio_ranges = true,
> 
> This still fails to build... v6 was not compilable, v7 is still.

Sorry, I only see the problem with complement_fw_gpio_ranges being removed from
the struct and not being removed here (in v7). Is there another issue that
affected v6?

> 
> Best regards,
> Krzysztof