Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221004131750.2306251-1-roberto.sassu@huaweicloud.com> <20221004131750.2306251-2-roberto.sassu@huaweicloud.com>
In-Reply-To: <20221004131750.2306251-2-roberto.sassu@huaweicloud.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 5 Oct 2022 16:02:23 -0700
Message-ID: <CAEf4BzaeOknT5d_ziidov3UXMZD40WCVHFamqC2_eH9nAUNUYQ@mail.gmail.com>
Subject: Re: [RESEND][PATCH 1/6] libbpf: Fix LIBBPF_1.0.0 declaration in libbpf.map
To:     Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, mykolal@fb.com,
        shuah@kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Roberto Sassu <roberto.sassu@huawei.com>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 4, 2022 at 6:18 AM Roberto Sassu
<roberto.sassu@huaweicloud.com> wrote:
>
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> Add the missing LIBBPF_0.8.0 at the end of the LIBBPF_1.0.0 declaration,
> similarly to other version declarations.
>
> Cc: stable@vger.kernel.org # 5.19.x

there is no need to backport this, libbpf has its own release cycle
and it is released from github mirror. And also this doesn't have any
effect, this inheritance between versions in .map file is mostly for
humans, according [0] (and I checked in practice that it doesn't
change anything for libbpf).

So it's good to fix, but no need to bother maintainers to backport it
to stable branches.

  [0] https://www.akkadia.org/drepper/dsohowto.pdf

> Fixes: e2371b1632b1c ("libbpf: start 1.0 development cycle")
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
>  tools/lib/bpf/libbpf.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
> index c1d6aa7c82b6..04fab9f1fdd7 100644
> --- a/tools/lib/bpf/libbpf.map
> +++ b/tools/lib/bpf/libbpf.map
> @@ -367,7 +367,7 @@ LIBBPF_1.0.0 {
>                 libbpf_bpf_map_type_str;
>                 libbpf_bpf_prog_type_str;
>                 perf_buffer__buffer;
> -};
> +} LIBBPF_0.8.0;
>
>  LIBBPF_1.1.0 {
>         global:
> --
> 2.25.1
>