Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b19fcc887b8a6fbc4b7d68cf03aa6626dc2a6fcc.camel@nxp.com>
Subject: Re: [PATCH RESEND v4 0/2] drivers: bus: Add Freescale i.MX8qxp
 pixel link MSI bus support
From:   Liu Ying <victor.liu@nxp.com>
To:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, saravanak@google.com,
        gregkh@linuxfoundation.org, geert+renesas@glider.be,
        krzysztof.kozlowski@linaro.org, robh@kernel.org
Date:   Thu, 06 Oct 2022 11:18:06 +0800
In-Reply-To: <20220822060323.3481384-1-victor.liu@nxp.com>
References: <20220822060323.3481384-1-victor.liu@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1ljMjA0Q3pzQ3EwdkhaNEZ6emtQcWFIbmtJaHJEOEU4NjVpTTRtbUpNZ0ph?=
 =?utf-8?B?aS9GeHhVOHpxd3pnUFNGZkt3REU3TnN5aGY0SEs0cFdLQTlYT0FGMG5LQi9D?=
 =?utf-8?B?NXRsOUhDVEVpdDM5WE1ZRlFSNlRUZ0FERm5zL0VJNTRMZ0VVb0JTQmM1Nmc3?=
 =?utf-8?B?UTZYVnFQcEdvbzBLNGJOUzExZlRIcmtvZUVrVEFMelJyYmlHb2dla1BkcUhD?=
 =?utf-8?B?Q0Z4M2w0TnpMNVBLbGdsU09iM0JuQ2xpeVphM3RIVnZlVTE3Q2tucmc1NlpR?=
 =?utf-8?B?eGVJbll2MTZ3YXM4ZFVycTZzUXdpbmxNSFpNaU90d2VxNk9Od2NwYzlPd25Q?=
 =?utf-8?B?NUpxSzd1eXFuMUlHdUIzOEo1TUduTmEwM2ZRSHcvWGwzM29SS0hQUkF2bFI4?=
 =?utf-8?B?UWRpMWtQeEpaU2ZGdjJoV2N3ZGM5M1NxUXlTLzBXM1NqdmIwdThpMUhYUWJy?=
 =?utf-8?B?a3YyM0s2aWhPUFBCeTZuaEh3SlN0MldNREhZK0xhR1hzQzJ2V2ZyVHVVdlpi?=
 =?utf-8?B?ZGMwTkJIUVMwa3Exd0JKS05JTDU5YzZsOVlaT3VLZ2R4NHdpamZVMHZoVXA0?=
 =?utf-8?B?NGluYXhiZjdDOHgxVEMxYjZFV1pwUHVYQnN6SFdvbnc2elFPczBhWGxRQ2VG?=
 =?utf-8?B?Y3lzM0xXRGVQWHVqWXpCLzFDRDJIdUJ4aUJqT1JBcU50UC96SkwvcDFNdjFo?=
 =?utf-8?B?Q2JhSWRYM0VyVkxyY29wSGFESmJTblkvTllyaU05R0hwUVFtOUZBR3oycHBi?=
 =?utf-8?B?RjVydkdSYy81L0JudElldVJFSjZuK0I1RHV3OHRlL2NxaEp5ZzV5dnpXVGtX?=
 =?utf-8?B?czBzVGUyNGpTMDJieTFIaElOOWI3Wmw1c1hLZVZUaFdkVFVtbjdBZ3hLdUNz?=
 =?utf-8?B?WTNvTzE4RWttWGNvMzNVSys4eFUyMVdzU0ZQTU9uNzlXU0pJMkRMVHJBZW5P?=
 =?utf-8?B?VjZDdkNlWHkvV08yZEhGSTRnNzZ1SkV5cmFkeFo1c09xR3ZWd01xSE8zYjFt?=
 =?utf-8?B?RkNCODNxS2NzYjlESjBLMjhSRW53SmVsY0FabWc3K2NBamc3ZHpLYXp4c0Vy?=
 =?utf-8?B?Z2xKZ1hLMmVaNjlmNHJDdE95QjlOVUN2aXRvc1p1ajB4Tm4xYStQTTRSYmRY?=
 =?utf-8?B?NEowalkvNlhud2RXOFhGRkcraklRclU5bGVrWTE1bG1lSzRMQVA2Q1NaQWsv?=
 =?utf-8?B?dzZERDRrNm9vSk9xK01SMnZ5KytaekFuLzBTREMrNm1vVEJ4a3RPQlZBb1l0?=
 =?utf-8?B?ZUFCUlFxY0J0c0FreFo5MjROZEpxalJLRDMxRnh2d3FZbFFwaGdoS3MyZmRD?=
 =?utf-8?B?OHFQQ0NHTWltdk1wOW9BRksvR1NmdXRIdXJPT3BmcW5taUhXOWY4ZnV0alJZ?=
 =?utf-8?B?a1lDN0ZLT25lWUNRU0gxUEZOL2dRNFFnNkhsZUhWSjZ6SEJtVlVQL0JTWDJq?=
 =?utf-8?B?elNwT1IrbytqQlVadjJBWWRCTUFTZDRxejYxL1k3TzNHdzNqNXdYeC9tT3RN?=
 =?utf-8?B?SWkzb295NzVucm5teWtHaTNiQ1NVZXBDU2N0MHF0RzBQNENna2t6enE4MXVW?=
 =?utf-8?B?VnlPSlM1Z2thdHQwV2xEekwxcHBOWmFRbnkvRHR2MDVIMWxKTElpMTZZc2tv?=
 =?utf-8?B?dzBjVktONDhpOGw0aWZObjJWdjlCTHhTZnZYckRwZ1Y2aDJrM3dQYjZRZUVn?=
 =?utf-8?B?S1haaisxbzVHUjdEOG5EWmRkbzJmWmhsMTFwTmI3Sk45aEl3Tmt2QnRTblFz?=
 =?utf-8?B?SWxrMWJHWTRCV09hbTFNK1hJUFN2aUNNTkxxSTdLR1JJWlV0aTRTNFdhYzBV?=
 =?utf-8?B?clQ4cnNYS0NKL0hDc1RYSHV1bHg5MWZxU3hUWUc1dGVRM0htRWVzOWNDQ2dx?=
 =?utf-8?B?MUFwVktIOWg2NWNjMzBHUERwVDRVOWRDMkxyZ1FlRHdFSjZrRk8xNktWZDZW?=
 =?utf-8?B?TW5CT2hXd1MzaGhaY3BjU21ud0FkU2dqNHdQNFN5eVl0UVpDSnhiSk5vN0Z1?=
 =?utf-8?B?SHpIMExNUFFYZjROTkZJM1FBbnIwZTRJMWhwWVBabGFWMUlEYnNVSXFTaUtz?=
 =?utf-8?B?K0gxVVAyNkFtMlFXU2FUMDNvWHJxZFVKQk1lVXVpU2hXNTVhNVVhK2ExVWZq?=
 =?utf-8?Q?uoLIyCfIGCExEwelVBwkm14qr?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 322c6e3c-eac8-4ff7-9fbf-08daa749881f
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 03:19:09.4569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S8HwltzmmobH07v0HrFK9X96Kipc0KdXjUIG9kbd36feq8+tNxy7OImVjmpe4UOQJMSyKYIAkDeHLNBMtF8pxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8198
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Mon, 2022-08-22 at 14:03 +0800, Liu Ying wrote:
> Hi,
> 
> This series aims to add Freescale i.MX8qxp pixel link MSI bus support
> by using the existing simple-pm-bus driver. A power domain and two
> input
> clocks need to be enabled before the MSI bus accesses it's child
> devices,
> which matches what a simple power-managed bus is(See simple-pm-
> bus.yaml).
> 
> Patch 1 enables/disables functional clock(s) as a bulk in the
> simple-pm-bus driver when the simple-pm-bus is being power managed,
> since the MSI bus takes the two input clocks as functional clocks.
> 
> Patch 2 adds dt-bindings for the MSI bus.
> 
> v3->v4:
> * Drop patch 1 in v3, because simple-bus/simple-mfd devices probed by
> the
>   simple-pm-bus driver should not be child nodes of simple-pm-bus at
> all,
>   as simple-bus/simple-mfd's child devices PM operations cannot be
> propagated
>   to simple-pm-bus. Those simple-bus/simple-mfd devices needs
> dedicated drivers.
> * Drop unnecessary 'bus == NULL' check from
> simple_pm_bus_runtime_{suspend,resume}.
>   for patch 1 in v4. (Geert)
> * Add Geert's R-b tag on patch 1 in v4.
> * Add child nodes in the example MSI bus node of the MSI bus dt-
> binding. (Krzysztof)
> * Resend v4 to imply this series is based on v6.0-rc1 so that there
> are not any
>   dependencies for the MSI bus dt-binding. (Rob)
> 
> v2->v3:
> * Add a pattern property to allow child nodes in the MSI bus dt-
> binding. (Rob)
> 
> v1->v2:
> Address Krzysztof's comments on patch 3:
> * Add a select to explicitly select the MSI bus dt-binding.
> * List 'simple-pm-bus' explicitly as one item of compatible strings.
> * Require compatible and reg properties.
> * Put reg property just after compatible property in example.
> 
> 
> Liu Ying (2):
>   drivers: bus: simple-pm-bus: Use clocks
>   dt-bindings: bus: Add Freescale i.MX8qxp pixel link MSI bus binding
> 
>  .../bus/fsl,imx8qxp-pixel-link-msi-bus.yaml   | 232
> ++++++++++++++++++
>  drivers/bus/simple-pm-bus.c                   |  48 ++++
>  2 files changed, 280 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> bus.yaml
> 

I don't see any more comments on this patch series.  Can it be picked
up please?

Regards,
Liu Ying