Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221002220126.18849-1-hcvcastro@gmail.com>
In-Reply-To: <20221002220126.18849-1-hcvcastro@gmail.com>
From:   Roderick Colenbrander <thunderbird2k@gmail.com>
Date:   Wed, 5 Oct 2022 21:02:37 -0700
Message-ID: <CAEc3jaBiN_b_AJGugkYSwxF-ZWHzD6ib4r99tm9Z4RwN2=bgzw@mail.gmail.com>
Subject: Re: [PATCH 2/2] drivers: hid: warn feature report 0x81
To:     Henry Castro <hcvcastro@gmail.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I see in the other email. If it doesn't support this request, it is
likely a clone device. We are about to submit a brand new DS4 driver
(for hid-playstation). It will use a different report (0x12) if I
recall which does the same thing. That's the more mainstream one we
use.

Thanks,
Roderick

On Sun, Oct 2, 2022 at 3:01 PM Henry Castro <hcvcastro@gmail.com> wrote:
>
> Unfortunately, my PS DualShock 4, does not support
> the feature 0x81 to get the MAC address. Instead,
> use a unique hash to fake a MAC address, so I can
> use DS4 to play Retroarch :)
>
> Signed-off-by: Henry Castro <hcvcastro@gmail.com>
> ---
>  drivers/hid/hid-sony.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index 656caa07b25f..e3e9c58887cf 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -2641,13 +2641,14 @@ static int sony_check_add(struct sony_sc *sc)
>                                 HID_REQ_GET_REPORT);
>
>                 if (ret != DS4_FEATURE_REPORT_0x81_SIZE) {
> -                       hid_err(sc->hdev, "failed to retrieve feature report 0x81 with the DualShock 4 MAC address\n");
> -                       ret = ret < 0 ? ret : -EINVAL;
> -                       goto out_free;
> +                       uint32_t hash = full_name_hash(NULL, dev_name(&sc->hdev->dev),
> +                                                      strlen(dev_name(&sc->hdev->dev)));
> +                       hid_warn(sc->hdev, "failed to retrieve feature report 0x81 with the DualShock 4 MAC address\n");
> +                       memcpy(sc->mac_address, &hash, sizeof(hash));
> +               } else {
> +                       memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
>                 }
>
> -               memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
> -
>                 snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
>                          "%pMR", sc->mac_address);
>         } else if ((sc->quirks & SIXAXIS_CONTROLLER_USB) ||
> --
> 2.20.1
>