Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 66vzhfAK91bAwIK1s/l6SX6WXd9uoqIcs+zu3/tA5OGRK4lwHe/hOStxt9GN7qGbFo+dwDqSDF
 knGMUedWtS7eQIGEHul8LL29OuwDCZX1gqMdiWb1wwM0v6mlqiRq/0xi1Vb91hoWllQOwssgUk
 HfhfxcI7yWdGOyiQDoLBkEm5XuQ67UJfa5MTwdK5zyvbiT5iMRE/Wq/jz+w1thUh4MOaOVj/nT
 sI3gs1EnJNt+VU5ta84ZDUxk3kuPHUicVyCx4u/kVucdYAiMA7Ah1zrTCfb3wJUH9suRRl4a9i
 APXjGPO533jNpHq4vQT5YblO
IronPort-SDR: vlAJfu4bLGMwo+Oin2sOWZR+GRkJWfrHRmul5FoIjiC+X90zWP55Mo3L5f1+XFjgbhwgtawivT
 saERO0Fop1iMBDuESI3wbnyZZu/FbNGaW39kp7m0ZhnaxbSagrRoXFtADuuryUDd+Wi+ObmCpu
 sKRfdDF+2s4yNqu4z+hbA+H+gP6h/if0VFtf9poGezzJ64XsLkYQ3B9K2V3p/3LaEfOO1y7ezO
 5Q3IxZ+u6nhFwMgB5iOrT7A48A3s0+zVWq6AAiow3ISmIHYimGXmGjEslnhVIHPYTkmLqINDZL
 eXg=
WDCIronportException: Internal
Message-ID: <60557988-a5e5-8c81-72f9-c0f3ab9ed573@opensource.wdc.com>
Date:   Thu, 6 Oct 2022 14:45:59 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
References: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/6/22 14:17, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
> 
> On some architecture NO_IRQ is 0, on other architectures it is -1.
> 
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> 
> So use 0 instead of using NO_IRQ.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Doesn't this need fixes and cc:stable tags ?

> ---
>  drivers/ata/pata_mpc52xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 6559b606736d..3ebd6522a1fd 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>  		udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>  
>  	ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
> -	if (ata_irq == NO_IRQ) {
> +	if (!ata_irq) {
>  		dev_err(&op->dev, "error mapping irq\n");
>  		return -EINVAL;
>  	}

-- 
Damien Le Moal
Western Digital Research