Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Oct 2022 14:03:51 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Ravi Bangoria <ravi.bangoria@amd.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH v4] perf test: Introduce script for data symbol testing
Message-ID: <Yz5vx9hyAEnB1Sfl@leoy-yangtze.lan>
References: <20220930120939.353315-1-leo.yan@linaro.org>
 <CAM9d7cibbdOb04qhKkfyRmwtHvttb6-bOu_uAN6D8ke-EJUWZw@mail.gmail.com>
 <c75ba6c3-938d-14a5-2fc8-3e846eeba23f@amd.com>
 <CAM9d7cg7dLNyH=dYuie=HF=yfxH7dNaEe5vs+r0E_PJLYs1Msw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cg7dLNyH=dYuie=HF=yfxH7dNaEe5vs+r0E_PJLYs1Msw@mail.gmail.com>
Precedence: bulk

On Tue, Oct 04, 2022 at 11:34:45AM -0700, Namhyung Kim wrote:
> On Fri, Sep 30, 2022 at 10:13 PM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> >
> > >> +# perf mem/c2c internally uses IBS PMU on AMD CPU which doesn't support
> > >> +# user/kernel filtering and per-process monitoring, spin program on
> > >> +# specific CPU and test in per-CPU mode.
> > >> +is_amd=$(egrep -c 'vendor_id.*AuthenticAMD' /proc/cpuinfo)
> > >> +if (($is_amd >= 1)); then
> > >> +       perf mem record -o ${PERF_DATA} -- -C 0 -- taskset -c 0 $TEST_PROGRAM &
> > >
> > > I'm curious why it has "--" before "-C 0"..
> >
> > IIRC, any command line options placed after -- will be carry forwarded
> > as is to perf record.
> >
> > perf mem record [options] does not support -C option. Which means -C 0
> > will be ignored if user run `perf mem record -C 0`. Ex:
> >
> >   $ sudo ./perf --debug perf-event-open mem record -C 0
> >   [...]
> >   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0 = 5
> >   sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0 = 6
> >   sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0 = 7
> >   sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0 = 8
> >
> > OTOH, if I place -C 0 after -- then perf opens event only on cpu0:
> >
> >   $ sudo ./perf --debug perf-event-open mem record -- -C 0
> >   [...]
> >   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0 = 7
> >
> > Now, perf mem [options] supports -C options but I don't know why
> > it's not working for me:
> 
> Thanks for checking this!
> 
> It seems -C works only for perf mem report and eats it for record.
> I think we need to fix the option handling.

Thanks for digging into the issue and fixing, Ravi & Namhyung.

I will send a new patch to drop "--" for CPU list.

Thanks,
Leo