Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: +oXSmFXVtIBE6+8qjMgZ6BEZDHeHzN74NH2zhVaaMsUrMMA2fbcznPgQg/a5K5B7Bynwzzq85z
 gWjKDMyZmLNYK2/qyMYGpMl10WacxrzSuPmvufTGr1dgxQnIvdKSlKoBFLC4/LkQ34QrB+5aKB
 XhhnsqjM8plV0yc35Kcbnopre9DxzjnDmuSmwlEi8MFbCXaJNSZtww0AaNAMsiSfpX8tVn9kJw
 iIIZKZyX+4YnpTBkB9zqqtpwDwgHSUMn/LagpH23ayQj0kQO8YiUqvMym0+9lTAscR/MaYsjlr
 NOwolvYK/E4NY16s0CfoieW9
IronPort-SDR: E4OjPmQwaB01+ppkRq3W01q3wrjLBd8VwlK+76H8uV0LJEJqWS0OLLxYSeSkJobi/T+HTItedR
 P1OHZrWfq+Zn56jeuQoOQge6y+E3LZnWDCUpV7UBJU4S3l9xi4Xee0Mkvz4xO0jmcdp3CDBuIN
 qM7jkcP1ZY/TOj0kbAw9U0gztsDkiZP3txzioWKh+T6HHdSmCVu7Qp0PCzr7cmImDzsd5siked
 ZeknmClDoVImmMmKOdKdIXkEvj5k9tXqRbGpvf/Q79e9/Obe0BdIHh54Ea8JTs1O42tMPYbTLC
 WBw=
WDCIronportException: Internal
Message-ID: <fcf05af6-fce0-0ac9-c4ff-7b8960bcacc6@opensource.wdc.com>
Date:   Thu, 6 Oct 2022 15:30:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
References: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
 <60557988-a5e5-8c81-72f9-c0f3ab9ed573@opensource.wdc.com>
 <14fa0e63-1a43-6c80-5ffe-1c7100ed88ba@csgroup.eu>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <14fa0e63-1a43-6c80-5ffe-1c7100ed88ba@csgroup.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 10/6/22 14:49, Christophe Leroy wrote:
>=20
>=20
> Le 06/10/2022 =C3=A0 07:45, Damien Le Moal a =C3=A9crit=C2=A0:
>> On 10/6/22 14:17, Christophe Leroy wrote:
>>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>>
>>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>>
>>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>>
>>> So use 0 instead of using NO_IRQ.
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>
>> Doesn't this need fixes and cc:stable tags ?
>=20
> I don't think so, because the only user of this driver is powerpc and=20
> powerpc has NO_IRQ set to 0.
>=20
> I'm sending this because I was to remove NO_IRQ in powerpc in a second =
step.

OK. Got it. So queuing this for 6.2 is OK ? Or do you prefer seeing this
as a "fix" in 6.1 ?

>=20
>>
>>> ---
>>>   drivers/ata/pata_mpc52xx.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
>>> index 6559b606736d..3ebd6522a1fd 100644
>>> --- a/drivers/ata/pata_mpc52xx.c
>>> +++ b/drivers/ata/pata_mpc52xx.c
>>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_devi=
ce *op)
>>>   		udma_mask =3D ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>>>  =20
>>>   	ata_irq =3D irq_of_parse_and_map(op->dev.of_node, 0);
>>> -	if (ata_irq =3D=3D NO_IRQ) {
>>> +	if (!ata_irq) {
>>>   		dev_err(&op->dev, "error mapping irq\n");
>>>   		return -EINVAL;
>>>   	}

--=20
Damien Le Moal
Western Digital Research