Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8c774c5-b274-a6f9-303b-e84c50800b5c@os.amperecomputing.com>
Date:   Thu, 6 Oct 2022 13:44:18 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v10 3/3] i2c: aspeed: Assert NAK when slave is busy
Content-Language: en-CA
To:     Wolfram Sang <wsa@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20221004093106.1653317-1-quan@os.amperecomputing.com>
 <20221004093106.1653317-4-quan@os.amperecomputing.com>
 <Yz3VmWCqdolKg5sm@shikoro>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <Yz3VmWCqdolKg5sm@shikoro>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXl4ZE93cHZtQjd4eGlQbDdTa0xJeExoNE11Z1dRNUpkTzJ0M1RYZHBDclNM?=
 =?utf-8?B?WFRwWDBIN0JCc1dPVTc2ZkxYQzJZS29DVzZaRVllRXFuNmczYnJERFVOcVB4?=
 =?utf-8?B?aUFJTDRYeHdtNDNid3NMSVJqdDhxWC9KeXFmSTNXTUNBcCtKczNQZXd0b1k0?=
 =?utf-8?B?c1dIejhiZzRzZlYzeCtoRXhPTndjWUdwUzdVRW9qYTVRUzUzZElrNlU5U1Rt?=
 =?utf-8?B?RmttZmFIV0RQeGtiWWRuYXhDRzl2N1dhNFFCQVAxdWRUT2xpZXJZMWFLNWdU?=
 =?utf-8?B?Tjl6WCtXYjI5Y2dsUUVYaWdZVWY0TjNBS1NWNEI3UWl4VnBzWmFzQVdJTjNB?=
 =?utf-8?B?Y0srdGdJUUNWZUx3RCtQMTI3Q0k3OTVBcHE2bjVuTEF0Wnc0SUNpZmk0MUpv?=
 =?utf-8?B?SzFudytLcjVCMmNtYWs4b0dRbm5yMlZGSHNEamVyd0dsY20vbWZlYnVPdXJn?=
 =?utf-8?B?L3YwTVUzUjVzcTJuTE4zeGVIUlVwQXpIRHhQMjhQUUczZCttdGNadG9Zalhi?=
 =?utf-8?B?SnZxS0ErTGY2ZDlVcDlEZ294ckNNa3JHVFRLdjlkVVdlRUgxa1ZuaHpISWIw?=
 =?utf-8?B?VGJxM1AwQUdnOHVEODF6U3FySzFZVWhrQ3NpNElqMGJZUWFPelBtQURYYjd3?=
 =?utf-8?B?cHVwZm9NRG5Hb3QxTkFkNnllN05uQi85QlROdEZXbDh0YjJUWUVOVmdiRE1a?=
 =?utf-8?B?MVpEK2pLM09NWXFYbWNEZnVJelNiSzJlTjBLQUNtcEdIaVA1QVVMeE1SZkV5?=
 =?utf-8?B?T0Z2cklPcU5tb2pxM0VONXB6MlZUTXZreUhPZTM2UDFtVy9lMUZWaTg4cEd3?=
 =?utf-8?B?RWllSUFMQmpNbTVBd2hIYjRtRGtKNjJwWjNlQmpwL3JCWGl6amJBcG1vL0U1?=
 =?utf-8?B?SW0rUGoyY3RlT3J5aE1ueXY0MXc3di9TRTl4SHYrY0x3Z2k3bHdHN1RFT0hG?=
 =?utf-8?B?K3p2UzFsSlJhMEJPWjYzdVZhWjR6MFFuaW9wR3ZYYVp3UjhGN0FEcUxvbHZR?=
 =?utf-8?B?MEZUaVFjM1BGODN1amtnNjZMWVJtNGtnRzJYWFhBbjhHMUk2Z2FsMTJOMGNN?=
 =?utf-8?B?eisrVU4yaWI0ZlgvdGt3RVVFNDJXYzdEWHpKWnZjZEdtU3EwcjhDbm5LbjFG?=
 =?utf-8?B?NVMvMGY1aWRVdElvTG9WTGdRSDdERzZwVDd0SHYzczZmSVBKNzlvNGYxc0FI?=
 =?utf-8?B?U3o4dmZGUURwYWVNV2hqVi9rZFM3SVB5V241SDNPUFpEV3JIeWgrZXNmbjNF?=
 =?utf-8?B?TW1iT29xRVJ0RDQxemFObTZYZEFVeHh5V25ITC9pTjhST2NkMXZteHB0RkZo?=
 =?utf-8?B?RXV1Nys4QmVOUkZQNlZNdEZXZmE4WGI4RkswdTVXUG82UWdZeWV4VEo1QUFZ?=
 =?utf-8?B?Ry9TQ2pNUlZOZGtlWXk1cDNHMkh3dXk5SzE3U2ROL3RUVUs0ck1MWXg2YnJ3?=
 =?utf-8?B?ZkRJbURHNjBEdHNja1FCU2t1d3FORWZHZmJ3QWV2Qmpna3lXQnJ3Nk9obW5U?=
 =?utf-8?B?M0diYkNhZ3ZXRkQzSWhCcjBwRW5EcUZ3Nkpad2ZOQXFmSTZwLzZoeVVMRDEw?=
 =?utf-8?B?M2xMRno0cmdISk5ObmdUY1hMMXpWYWM5T2JSSXpsMDVLbThkNWJSOVRxbWhK?=
 =?utf-8?B?aGI0UWhhTC8xS0NSTUxPZmJnWkJ4RFdmUitvOXczNlAvSDR1dC90a3dpN1dJ?=
 =?utf-8?B?SVhWZ0tjYnhvUXZJL2JubW45VDJNQkFRNjAyRTdUSHRNMllNK1Nlb1o2cUg3?=
 =?utf-8?B?ajJPQks5MGkzN1c5cE41dmRoZjRRck9zSkVkQ1lrWC8zclljcHBucGNCOUV1?=
 =?utf-8?B?K3JoOW9mTDZhNWVwdENvTEhWZXdPdFJWVjU5UEZqYzZWZGhaK2N4WHdNMmRo?=
 =?utf-8?B?YTNweU14T0hNYmN1UHd3YUEvYisxRWo5MHhEdkFSbnRQSlZCMXVaK2w2QUcz?=
 =?utf-8?B?cVZ3MlA1bzJ3SWJucGtXMFF4L2VGeUdXT1N6WTd5YkxIMW16cUsrNlpCZmxo?=
 =?utf-8?B?cWVsMnFvVVFpckJ3Ynh6cEpnYUp1djBzYjl6U2w1K01INkFaVFhmaFl1U1Az?=
 =?utf-8?B?dENnZEQvVlp6UVl1enBWc2pQWWpyUzg0WnFDYXlJaGRyYjA4YngzV2h0SGhi?=
 =?utf-8?B?UG8vVVRWdHNNR2xOK1hHL2RadWZpQzU4MUh5NlRndit6THlVMDJiQy84dEdV?=
 =?utf-8?Q?n1BIiSgvKUH3uWrZ4PAUmhM=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b96fa78f-f395-4858-b973-08daa7663780
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 06:44:28.9101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a5D8Z4A+5kf4W0HKWz3FYZKVfrsLdqF0G3R3ZOFXgdXEoXapsXI37OZ2UcxTaU8tHRzlxAdgarAOAM5RL5LiQ+WFMJxmTlTAMrheLKvVnUs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2608
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Wolfram,

Thank you for your patience with me through many versions.

Best regards,
- Quan


On 06/10/2022 02:06, Wolfram Sang wrote:
> On Tue, Oct 04, 2022 at 04:31:06PM +0700, Quan Nguyen wrote:
>> On I2C_SLAVE_WRITE_REQUESTED event, Slave already ACK'ed on the address
>> phase. But as the backend driver is busy and unable to process any
>> request from Master, issue RxCmdLast for Slave to auto send NACK on
>> next incoming byte.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> 
> Applied to for-current, thanks!
>