Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f49ba8f7-8968-fc2b-3cab-6c41168b0b89@nxp.com>
Date:   Thu, 6 Oct 2022 10:35:10 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] tty: evh_bytechan: Replace NO_IRQ by 0
Content-Language: en-CA
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <23f608ca57e7e19bc7060d3e563de383e0b2b337.1665033575.git.christophe.leroy@csgroup.eu>
From:   Laurentiu Tudor <laurentiu.tudor@nxp.com>
In-Reply-To: <23f608ca57e7e19bc7060d3e563de383e0b2b337.1665033575.git.christophe.leroy@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTdJTHhZOG1ZYk9wbHJDTEU2U2p2RDlDeUhLcXFSeXhQQ0J0MlNjbVdEN1c1?=
 =?utf-8?B?RzBpUXRZTmlUMStyLzEvejhCb2JGbXY4cFU3UXRZMm9uRUpVdTlVT2lYTEZQ?=
 =?utf-8?B?M0c1SzdrSUFqNFRpamVETDNlMkh4WXVQQkZjNkd6QmdXcUtyTEVmTTBJUGdK?=
 =?utf-8?B?d2NpL2dyU2xFSkZFQTMvU2k3dGtOZTFSSXl3MWtvWXRYaDYrQTVQbzBFV3c5?=
 =?utf-8?B?cE91bjVINGxBaitPa1dra0dyMjg2WWl6d0JVYW9zbGJlcHRFYy9KWUZhWjIw?=
 =?utf-8?B?ZG1mYUZJLy94QWtycDIrSUhsdUlqQTlhL3UwdEFibHQ1ZmNtZnFsamZRYUN1?=
 =?utf-8?B?T3hUS0lHbERhcDNic3dXbTRIUEt6ZnVLTFd4bDc4bXl4ZzJPS0IwSy9lMGN5?=
 =?utf-8?B?VmpZVUtoUlY4YTM0dVVhUzMzWUJRclhWdjdIU1F0YllrL0ptaHlvV2puZTdM?=
 =?utf-8?B?ZGlwaXB0QmoyclJaaEhTMjRRMXlwV0IwMFdENUNYanpXTklPMGkvcDViUVVD?=
 =?utf-8?B?ZFhJY25XM0JwdjR6L0M2dDlXd0l6U1VsS1M1blFXMGtFWno4a3lqM1Y0VGFZ?=
 =?utf-8?B?MUY2M1JjQnFkaG5VTVRDSkFUcCtTRVRnVEs4VEx0YWZsNjJDQ0l5aHZmSGtV?=
 =?utf-8?B?a1NxUHFNcUdrMXNPWTZUTUZIWjJTZUJtMlA3NXVXeWFpNVVGV2pTazZzbWZI?=
 =?utf-8?B?QkthZ3N3SHhWRU5jdUw1T1BqWko1NXVlY00yNVBtSGRQSVRUN0NlRVQycUlE?=
 =?utf-8?B?SWo3ejVuSTA5cXdsZ1FtRFdjQmZvY0d0MHpKNE1oTW56cjVJMWFMWjNXMjhK?=
 =?utf-8?B?RzBWdzh2R1V0UzBrVUNyclQvVFhEVkQvWWIrSmxteDJ6NjRrK3k0Rkwzb0l3?=
 =?utf-8?B?SkpJc0VnZmZDSXltVlo0SnpOVVVuaTRwOEd5WnhTNzd0U3A3dGxicFRRcWdi?=
 =?utf-8?B?WHFJODcxbHJPNzFSYkdVbEEyQlltdDJXVHJEczJCNmVsMHhkMEo0UVFIVEt6?=
 =?utf-8?B?T0xTOUVvTU8yWU1XQllLTVpnc2JPOU1HRzNvZXZrREh3ZHlZUXh1MzNvQm1Y?=
 =?utf-8?B?YVFMMjkxWEtGL2djU01MT3did3BNcWVRTWNIYWJsSS9VS1lrU1NvSkZpT2g5?=
 =?utf-8?B?NHl0WXFhUC8wQTRYdXByN0h1dUthTHB3TDlYSk1iTE03WXRONGtnYkJiQzRB?=
 =?utf-8?B?VHp3NGthQlhpQnNodHdIdEZCenQ5cW1NcVE3Y1BjWXJJOU1BSUQ0NWtHdkJv?=
 =?utf-8?B?Zm96bVlucFowald5dVY2MTE3SEJXTXFpdVZOcWpPd3N1RGt3Nzd0YnRuVVcw?=
 =?utf-8?B?Nk5McTBCdDBrWU55MUtMN3BhYTQzR0M5cTlIclFZbmFLZ0d5bCtOUTIycWd6?=
 =?utf-8?B?NXNiNCt6MGhtVkx4WVFIQXpURk1yeHp4RkVJM3B3NEtabXZldlVCbENweUhz?=
 =?utf-8?B?OWdOT2I5VG1Vbjd5UFY0cmV4UkVwMGF3NTRWSmZWV2FhWnAwNVZPZXdPTGtX?=
 =?utf-8?B?dUkxNzJ3VkkxWURrWFpacFRkRC9ab3Ayam5uZURMaExJSkwxZ1l4Q0s4MlBs?=
 =?utf-8?B?cFowd2s3SU90d3AyVHlsaU4rMXd6NEJvcUh3MVhKTSt5S3Z4R045cjZ6cEdH?=
 =?utf-8?B?OGNOTHR3eG0xeWVKL3Vqb3NLVTdWY0pXUms4aW92bko5VFZOR3RBbUxVSWlZ?=
 =?utf-8?B?ZGRlK3pjMldmNW1KUDlFSDVxSjZXLytwTTdldEU4d0EzU0JqQ3dPSHZWWHFo?=
 =?utf-8?B?bTA1bFZtUVZQYmpBdGhsQm5HeExHdFB2amlDekQ2ZU56aGhUL2tjQWpZK1ZJ?=
 =?utf-8?B?MG1EZXFLenMrUVRRclF4K2FoTGI0TEJVMHptWjcySGhzcG5WL2hYN1ZBNTN0?=
 =?utf-8?B?SlRCcUF0MXNZMk92NlZycklaQnFMeVJSVFBCam9uM1ROK2hCL1R4cEhYZnZH?=
 =?utf-8?B?aGY0Sy91SXoydFhjOUcxamRKcTlJelRNRWdpQmdBVzBQNnV1ZWN6ZmloaWtZ?=
 =?utf-8?B?enF2dkUrWnlCZW9DakxMZTkyb3dqZ3B6MmJ4eExYUDRRakxKSGh6VWRKM0dk?=
 =?utf-8?B?SzZ2NVRFa2UyT0xIMmRPOC92RDB6SDJlcFBGRXBMZFFhYkNKRnE5dzBwR1B5?=
 =?utf-8?B?UFlCS0F0UzB0ZkhWa2Q1ZTMvQmp0T3R3cWtPZ2FleDAxMXRvaDZFSExrTVFU?=
 =?utf-8?B?RWc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 346f9f50-1fec-4941-2d79-08daa76d4fe0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3405.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 07:35:16.1899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YMERTfOdkPlSz13WzbfeceY7O0cwDFP/axil+EbA3yIcGkbA6Lkj4fe+kEKW5V9adWRJLZs8YRljyZWvbLMocg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8207
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/6/2022 8:20 AM, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
> 
> On some architecture NO_IRQ is 0, on other architectures it is -1.
> 
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> 
> So use 0 instead of using NO_IRQ.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

> ---
>   drivers/tty/ehv_bytechan.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c
> index 19d32cb6af84..8595483f4697 100644
> --- a/drivers/tty/ehv_bytechan.c
> +++ b/drivers/tty/ehv_bytechan.c
> @@ -118,7 +118,7 @@ static int find_console_handle(void)
>   		return 0;
>   
>   	stdout_irq = irq_of_parse_and_map(np, 0);
> -	if (stdout_irq == NO_IRQ) {
> +	if (!stdout_irq) {
>   		pr_err("ehv-bc: no 'interrupts' property in %pOF node\n", np);
>   		return 0;
>   	}
> @@ -696,7 +696,7 @@ static int ehv_bc_tty_probe(struct platform_device *pdev)
>   
>   	bc->rx_irq = irq_of_parse_and_map(np, 0);
>   	bc->tx_irq = irq_of_parse_and_map(np, 1);
> -	if ((bc->rx_irq == NO_IRQ) || (bc->tx_irq == NO_IRQ)) {
> +	if (!bc->rx_irq || !bc->tx_irq) {
>   		dev_err(&pdev->dev, "no 'interrupts' property in %pOFn node\n",
>   			np);
>   		ret = -ENODEV;