Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dfeba303-9fdc-00b9-2ec6-6433041173b9@os.amperecomputing.com>
Date:   Thu, 6 Oct 2022 14:45:03 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v9 5/9] misc: smpro-misc: Add Ampere's Altra SMpro misc
 driver
Content-Language: en-CA
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     macro@orcam.me.uk, Lee Jones <lee@kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Thu Nguyen <thu@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220929094321.770125-1-quan@os.amperecomputing.com>
 <20220929094321.770125-6-quan@os.amperecomputing.com>
 <YzVrpT6BD6qmu5ZG@kroah.com>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <YzVrpT6BD6qmu5ZG@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjAydXlNeDZEK0tQeklWZ0JPWU50bHN2WGpLdTMxRW92b2FrdlFNMWlia3NJ?=
 =?utf-8?B?dXVnV21EVmU2K3ZmU1FNZ2MyOTdYNGxhQUtKMERETDdiQTBoQ3d3U1VWYjBV?=
 =?utf-8?B?ZWMyTldpTnF4bXZYUlJXeGwvNmtsU21ISWNzNC9lWmdpYzlFTE1EWjlNUEQz?=
 =?utf-8?B?eXByejlBUEZ5elFrcitwaXRiZC80SmgvSlpVbDlBU2NuZFpLOVU4Qnc1WnN1?=
 =?utf-8?B?WEZjQWQ2Y21qZHF3SXJzYTgyemJaTEMwOGUwenkyRTFWVGdsREZjck1lbzRU?=
 =?utf-8?B?UVBsa3RGMjRFRTdzbTRqME92R2d6RmRnVW5KbmJFc3ZkRWFxOFAzRmlqZ29V?=
 =?utf-8?B?bDRKQ3A0N1VqZVJQbEpMOHBtT0djVmxJaVJzelBKeTh4V1Bsbm1mTjR3MkJS?=
 =?utf-8?B?L1NIWWJ3cnZVOWs5cXR2MnNLS0kxK21qRHo3UDBEWkZ0MVRjekd5ZXQwMzF0?=
 =?utf-8?B?MnhPV1pwZlRVaHFZUXlVQWRJRWZZMHk1QmVxQ0MxRjJnWkRIaVRTUC9yOEFk?=
 =?utf-8?B?bmJFNFl5cnVCSVlvbkgzQXY4QjBZR1dJN1JDbVYyZFF6MkFHbTlJRHFINi92?=
 =?utf-8?B?dnVnZVJab3ZKUkcvRzU3SWhzQzFIbGwyMU1UeklNQ21BUFkrelNmOWdocXht?=
 =?utf-8?B?WXoxaUtFTzA3UDI0V3NCVjM4N2RtNnA4a0NWTk8ydDhmSFFXUXhPVE1PTWxa?=
 =?utf-8?B?aENHL1VpWisyMWMxbHlmYWluL1QzZk9FTzhQcERsdVBVK2lWb1oyU0NpY0Zw?=
 =?utf-8?B?UmxCbVBubE9iY1RwRm5zNmNWSWRRYjY2d29qUFUwdE9UdlNZeldDSE5xWGZr?=
 =?utf-8?B?OTBsb2VhT2N4ZkthaFpDUnNtRWdVUHBzV3p2STN2SWpwdWxaQVNJSWVYSXVu?=
 =?utf-8?B?a1g1R1UvSUZtR2srSFFTWmpIcWlOb0h4c0tFNmQ1MWpvMU0yUzZ4VFdNRnY1?=
 =?utf-8?B?KzU3eDdDeWVtRml0YXo2VFMwQWx1NnB2WEs5WFVLNkZYamF4Y0REUXRlYjNa?=
 =?utf-8?B?UWhhRnN2cUFDN0Vwb0lhZkx2QkQ2dExwL2RJQ0F1MERIZ0lsU002WCt1VlNr?=
 =?utf-8?B?NFVLeDJqWXkzd2xZK1JqSkMrbGhsQ2dwMXFiNWNDbkFzVGY3dnVZaWNkSHFE?=
 =?utf-8?B?eVpzOVI1OEN0TmozREZKRVFtbXBYNUNPV1F2bFBUOWxOcDNNWUk2N3lubzND?=
 =?utf-8?B?TzZrL1JWQlZnaGl2clMyeGphNjlHbFcvU2RhcGtRNWp6WWhZOWJCNnd4amUw?=
 =?utf-8?B?eFhwVVExSUFQREI4SE8yeFIvVm5Ia25PYUhrd2dPalNFb1VxK1U4di9Gc1Jr?=
 =?utf-8?B?SGw4enlDRFBpRDRvNmNJbG94UWhLUGxSd1VPb1FMSkRhWC91NFRBMDBwa1Vn?=
 =?utf-8?B?bkhxbTdiTDhKSU9WM05YNnRQcWVjd1R5V1M1ZThVU0JUNTBIeUdnZjlWaDQ0?=
 =?utf-8?B?T0wzNm5RaHV0TU5ha3VPY0NmUGZhVmhPdHR1ZlNiU0ZOdk5YN0RWZlRKRXFV?=
 =?utf-8?B?TE1MdXNLaVI4UkNvSDYxNmMxTHhhWlFTRnVaakdZSTE1aHpGMVhKTmRCYXJ0?=
 =?utf-8?B?MU5Nb2IvTkZ4ZVVaQ3h0a1hXNTJlMmkxbXpBYkFwTGpJZWQ4QjI5Vm03WFN2?=
 =?utf-8?B?NnF2TGN0OS9aTUdGQnhBTDhaM0FkZVcvd2pDeHI2UHlSamZQdWtkQjdDOWYw?=
 =?utf-8?B?TWkrenFhellnZ1RoUFpaNjd3YlBSVDN1bktxUXdhOU8zRXJVdVNWc2JVL3hD?=
 =?utf-8?B?cGZWcUlReENpZ0l3em85R05saWdJejVPelExVlVvYmNGQ0l1Y0VSZjFPT0tJ?=
 =?utf-8?B?ak9NVFVLb2dNZFVqU0pUamNTNE5kZWFLQXVTS0pWaDdQakM5QjV1YzM0MHNU?=
 =?utf-8?B?Wk9DRXE0K0liQ0Y4M3RiNER0VURpUzhIWTQ4VGFmWGM3STJOcENOM29kSHN0?=
 =?utf-8?B?dnJObW5sZ1JYNEgycFBSQzFKZExyTHFkUnFxMlN2RVhEbnFobmFMZ3p6eWtO?=
 =?utf-8?B?THBXSE5kazRHU3k5OHRoQ3J5bStYSVd2S0oxcjNZUCtFcVRVNWtpSG1wWTJh?=
 =?utf-8?B?alpFeW1CQUVKd2xHWklZZUJTYzd5Y2pIa0Z3YWQ4NGZ3VElCTjRQVnlQeXIw?=
 =?utf-8?B?bnBHYk1PS29ZQkgzQWd3UFRnbHNZYTJmY3RheTJCaUlKQjk1ODE5bHh0cWw0?=
 =?utf-8?Q?8cfguZRHL1uuVc3oRC3oX7Y=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bba1fd7-2ba9-468b-faf3-08daa76eb525
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 07:45:15.7658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CR4WeNyf8nLq1XSs+g54z3G49isKmWow0AQcgzgtPdM5U+IPENgssofOLoq0Y991e1ElCG0SaIaoQfQH9hcHEhMduH8MpVqzdimFT6uHnpI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR01MB7190
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29/09/2022 16:55, Greg Kroah-Hartman wrote:
> On Thu, Sep 29, 2022 at 04:43:17PM +0700, Quan Nguyen wrote:
>> This commit adds driver support for accessing various information
>> reported by Ampere's SMpro co-processor such as Boot Progress and
>> other miscellaneous data.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> Changes in v9:
>>    + Update SPDX licence                                     [Greg]
>>    + Use ATTRIBUTE_GROUPS()                                  [Greg]
>>    + Use dev_groups instead of sysfs_create_group() to avoid
>>    racing issue with user space                              [Greg]
>>    + Refactor code to avoid clever encoding issue            [Quan]
>>
>> Changes in v8:
>>    + Update wording for SMPRO_MISC in Kconfig file           [Quan]
>>    + Switch to use sysfs_emit()                              [Quan]
>>
>> Changes in v7:
>>    + Fix wrong return type of *_show/store()
>>    functions                                    [kernel robot test]
>>    + Adjust patch order to remove dependence with
>>    smpro-mfd                                            [Lee Jones]
>>
>> Changes in v6:
>>    + First introduced in v6 [Quan]
>>
>>   drivers/misc/Kconfig      |  10 +++
>>   drivers/misc/Makefile     |   1 +
>>   drivers/misc/smpro-misc.c | 145 ++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 156 insertions(+)
>>   create mode 100644 drivers/misc/smpro-misc.c
>>
>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>> index b9ceee949dab..9947b7892bd5 100644
>> --- a/drivers/misc/Kconfig
>> +++ b/drivers/misc/Kconfig
>> @@ -188,6 +188,16 @@ config SMPRO_ERRMON
>>   	  To compile this driver as a module, say M here. The driver will be
>>   	  called smpro-errmon.
>>   
>> +config SMPRO_MISC
>> +	tristate "Ampere Computing SMPro miscellaneous driver"
>> +	depends on MFD_SMPRO || COMPILE_TEST
>> +	help
>> +	  Say Y here to get support for the SMpro error miscellalenous function
>> +	  provided by Ampere Computing's Altra and Altra Max SoCs.
>> +
>> +	  To compile this driver as a module, say M here. The driver will be
>> +	  called smpro-misc.
>> +
>>   config CS5535_MFGPT
>>   	tristate "CS5535/CS5536 Geode Multi-Function General Purpose Timer (MFGPT) support"
>>   	depends on MFD_CS5535
>> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
>> index bbe24d4511a3..87b54a4a4422 100644
>> --- a/drivers/misc/Makefile
>> +++ b/drivers/misc/Makefile
>> @@ -24,6 +24,7 @@ obj-$(CONFIG_KGDB_TESTS)	+= kgdbts.o
>>   obj-$(CONFIG_SGI_XP)		+= sgi-xp/
>>   obj-$(CONFIG_SGI_GRU)		+= sgi-gru/
>>   obj-$(CONFIG_SMPRO_ERRMON)	+= smpro-errmon.o
>> +obj-$(CONFIG_SMPRO_MISC)	+= smpro-misc.o
>>   obj-$(CONFIG_CS5535_MFGPT)	+= cs5535-mfgpt.o
>>   obj-$(CONFIG_GEHC_ACHC)		+= gehc-achc.o
>>   obj-$(CONFIG_HP_ILO)		+= hpilo.o
>> diff --git a/drivers/misc/smpro-misc.c b/drivers/misc/smpro-misc.c
>> new file mode 100644
>> index 000000000000..6c427141e51b
>> --- /dev/null
>> +++ b/drivers/misc/smpro-misc.c
>> @@ -0,0 +1,145 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Ampere Computing SoC's SMpro Misc Driver
>> + *
>> + * Copyright (c) 2022, Ampere Computing LLC
>> + */
>> +#include <linux/mod_devicetable.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>> +
>> +/* Boot Stage/Progress Registers */
>> +#define BOOTSTAGE	0xB0
>> +#define BOOTSTAGE_LO	0xB1
>> +#define CUR_BOOTSTAGE	0xB2
>> +#define BOOTSTAGE_HI	0xB3
>> +
>> +/* SOC State Registers */
>> +#define SOC_POWER_LIMIT		0xE5
>> +
>> +struct smpro_misc {
>> +	struct regmap *regmap;
>> +};
>> +
>> +static ssize_t boot_progress_show(struct device *dev, struct device_attribute *da, char *buf)
>> +{
>> +	struct smpro_misc *misc = dev_get_drvdata(dev);
>> +	u16 boot_progress[3] = { 0 };
>> +	u32 bootstage;
>> +	u8 boot_stage;
>> +	u8 cur_stage;
>> +	u32 reg_lo;
>> +	u32 reg;
>> +	int ret;
>> +
>> +	/* Read current boot stage */
>> +	ret = regmap_read(misc->regmap, CUR_BOOTSTAGE, &reg);
>> +	if (ret)
>> +		return ret;
>> +
>> +	cur_stage = reg & 0xff;
>> +
>> +	ret = regmap_read(misc->regmap, BOOTSTAGE, &bootstage);
>> +	if (ret)
>> +		return ret;
>> +
>> +	boot_stage = (bootstage >> 8) & 0xff;
>> +
>> +	if (boot_stage > cur_stage)
>> +		return -EINVAL;
>> +
>> +	ret = regmap_read(misc->regmap,	BOOTSTAGE_LO, &reg_lo);
>> +	if (!ret)
>> +		ret = regmap_read(misc->regmap, BOOTSTAGE_HI, &reg);
>> +	if (ret)
>> +		return ret;
>> +
>> +	/* Firmware to report new boot stage next time */
>> +	if (boot_stage < cur_stage) {
>> +		ret = regmap_write(misc->regmap, BOOTSTAGE, ((bootstage & 0xff00) | 0x1));
>> +		if (ret)
>> +			return ret;
>> +	}
>> +
>> +	boot_progress[0] = bootstage;
>> +	boot_progress[1] = swab16(reg);
>> +	boot_progress[2] = swab16(reg_lo);
>> +
>> +	return sysfs_emit(buf, "%*phN\n", (int)sizeof(boot_progress), boot_progress);
>> +}
> 
> Again, please put the Documentation/ABI/ entries in this commit so that
> we can verify they are all correct.  Putting them at the end of the
> series makes it pretty impossible to review.  Would you want to have to
> match them all up the way you sent them?
> 
Will do in next version.

Thanks,
- Quan