Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71c965a2-dea8-6681-3032-0adff805202b@os.amperecomputing.com>
Date:   Thu, 6 Oct 2022 14:46:47 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v9 4/9] docs: misc-devices: (smpro-errmon) Add
 documentation
Content-Language: en-CA
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     macro@orcam.me.uk, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thu Nguyen <thu@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220929094321.770125-1-quan@os.amperecomputing.com>
 <20220929094321.770125-5-quan@os.amperecomputing.com>
 <YzbrgSE0958gjjgj@debian.me>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <YzbrgSE0958gjjgj@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2tLTC9FaU55WjdyVWV6anlYK2tRdHE0WVJEY1VjRTZTd1lDVXF0RjZXVHpt?=
 =?utf-8?B?TXV1azIzUitWL3BPbkxDcDVOT3F2Mjg4RlM2SUVhYUVHdlRqaUZFancySXBr?=
 =?utf-8?B?T0MwYzBDYmNiSWpZaW1NQXlhNGlFM1czc3VBSk4xRFNyWEVlOEpmbGtUOFdO?=
 =?utf-8?B?K01BWkdxVUFqaGkxQXB3N2hKV2VDcCtDUks0UFZCMDVRUEsvVkQrMkYrdHIz?=
 =?utf-8?B?V3VBZ21ILy9XbThmKzBuWUlJdlhXaGlMeEdUOUprR2tBdE1VZC9hWnA4Sis0?=
 =?utf-8?B?RXBUWTZKNFFVWlVBVUZwczJXVi9DT3pNZWw3MlRxT2IxUjF0a0NCSXh0TkhS?=
 =?utf-8?B?ZUszejE4eHhidXl5eXhXL0JuME5INDZ3ZzRhTzhTVXkyckVPUlpFZ3VJUkhB?=
 =?utf-8?B?ZHBTRzloMkRrc05hNnZVenpobWtZdFRocjVlTHV5blZpMk1MMVB4UTRvSHpO?=
 =?utf-8?B?SUxNK2NXdnBjTmcrTkxWUUdudFVJUmdraElmdTlHZnV4SXkyU0hhbUNVSEc0?=
 =?utf-8?B?b29tQ2REM2tYQis0eThsdHRMTTBPNlhMcm5JekVxL3k3Y2JnazRVNVAvcG5z?=
 =?utf-8?B?SzY5c1YwV2k5WVEvbzViQWFrb3hoN3FQdFo3WHlhSTFzVm9iOEEyMXU4Z3NK?=
 =?utf-8?B?YjFqVnorcDZUcGFzTElzRGlvb2NPSkF5RTFta2xWQURhblBLWjk1eWk1SHA3?=
 =?utf-8?B?S1VNaVFiWTlGUHo5QlZzbW51eWF1eUtmN1V3eHhDVm5JK2Q5MUJTK3BaaFlh?=
 =?utf-8?B?aU5Dd0F6NXdkOFcwNitXeDNONjM0L3VMY1dvQXZuci9LK255ZG5JLzBnTGdN?=
 =?utf-8?B?d2F2RE8wVjYwZ0ptNm5hNU1iUEdITTE0TmRXaEJGeVkwY3luTnd2VjBvR2kr?=
 =?utf-8?B?WEQwdVcyZzZUM3A2YjRZRWRsVmdXblZHZmRONWF3cWIrUFo0QkQxOGNPUXJC?=
 =?utf-8?B?UEJCWHhjZGFVdWZjMmFvenNyZ1dhZEN6RnplMkFUeXZMcFNqR1B2VkZsa0l0?=
 =?utf-8?B?UElrVkIrTWYwWjJnTDRjcXlpVGtidTVoSGxVbmhtdTl3ekt5cFJTcVFJSnVk?=
 =?utf-8?B?NEpFMis2cnE2TXlzUDgwSVVuaDBTK2p4V0hmVEgxZVcrR3paNTBSaTBYTDN4?=
 =?utf-8?B?MEloYkxIaEMwM3J4eDViUXVQWkFkaklGTDU4RzVsb0RSejJEWnAzT2hjUXJt?=
 =?utf-8?B?a2J3RlRZVnhnc090TjZIS0NERDlobnpjc3Bqejl3dWRxUlJOZmFOaUx3aWZm?=
 =?utf-8?B?UWVFZC95bTZsT0Z5SGFGNG5DQld4dEZvdnV4dWt5eVpYdnMrcjRPd1JFenhz?=
 =?utf-8?B?Q09BYmZOZVQxQUE1REI0MzAzVGFSWTluQjJLcHkwYUgrYW1USDJtZHdyQUFQ?=
 =?utf-8?B?S3M3NHQ5bzRNdzFBN05xVXQ3aTNlVXpzbTZIS2J5c1lWeWFPV3FFMTBXZFR6?=
 =?utf-8?B?TEJtVkNrWjRIQVIrakM4MFY3cy93ZkI3N2w2TXlybTVRZDFNNkprVlpEVVFm?=
 =?utf-8?B?cGZaL0RLYkRSM0xpQnBjRW5QQTlhME9SZXREK1ZMZG9zcERDTUErWURrc0RX?=
 =?utf-8?B?bTJMN05nVmRFSVJWNUVQcUkvQXh5aFVaWWZyUTkrWkdsWmI1dno1MjRIOE5K?=
 =?utf-8?B?UjJwb0EvZUtjMEN1WERseHcvRDhjM0h5dWdTSHpUcmw3ZWY1N0JHNkU3V3R5?=
 =?utf-8?B?WG55NlUwNGJwTVROdUJ1ZUZjbGI1NGtrUk9ZanFuZkhJTGZ5dncranNFVWN6?=
 =?utf-8?B?WHovZExVOTZyNHQrazREUGJFYmVxUk5kRkpkUDBLTzJMdkNrV1dCYlMwNkd0?=
 =?utf-8?B?VXVvKzVza0tlQ2RXSkdHaEMveFdZai81UGFlOE8yMzFWNHQ4R2dreWJ3ZjhC?=
 =?utf-8?B?UC9UVXR3d1h2MjBiZzdBYnRYNHhIUUkxc0FqVEZjaXRIdXQrWWxYbWRNek5y?=
 =?utf-8?B?dE9WKzlMeE5GT2hZY1ZYUlc5T0tHU1hSZzhXNWNOWjZmdjVzYXEwS0phaE1q?=
 =?utf-8?B?US9FTzFrNDBQRElJTUtZVy92K1V6SE9lWHhFbm55LzB1aSs5ZTM2RmNQM2cv?=
 =?utf-8?B?NEQwZ0E5NENJL1RPZWxOSStSNElPalRVazBmREhUR0pSN0h6aXMyVVZEWWNW?=
 =?utf-8?B?VHBUZVJjajZ1UUZkN1VFMDdhMFRyTWpzazRqTlJxN0xmUW1hb2RDUlZpNGQw?=
 =?utf-8?Q?buL1KIrOhZ17lf3zlRNyEWo=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4e45656-87ac-458b-6853-08daa76ef2dd
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 07:46:59.2761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EgBjwOir9/DePpyrFVy9XiUYgzjcyWTxozUQy6py1749B5bgBcQ2Y8WGIU3Bz34IvAD0/QL+qlOoiXa0e6bbfYQF4GaQlBYXAcnpbpjyaq4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR01MB5796
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30/09/2022 20:13, Bagas Sanjaya wrote:
> On Thu, Sep 29, 2022 at 04:43:16PM +0700, Quan Nguyen wrote:
>> Adds documentation for Ampere(R)'s Altra(R) SMpro errmon driver.
> 
> s/Adds/Add/
> 
>> diff --git a/Documentation/misc-devices/index.rst b/Documentation/misc-devices/index.rst
>> index 756be15a49a4..b74b3b34a235 100644
>> --- a/Documentation/misc-devices/index.rst
>> +++ b/Documentation/misc-devices/index.rst
>> @@ -27,6 +27,7 @@ fit into other categories.
>>      max6875
>>      oxsemi-tornado
>>      pci-endpoint-test
>> +   smpro-errmon
>>      spear-pcie-gadget
>>      uacce
>>      xilinx_sdfec
>> diff --git a/Documentation/misc-devices/smpro-errmon.rst b/Documentation/misc-devices/smpro-errmon.rst
>> new file mode 100644
>> index 000000000000..b17f30a6cafd
>> --- /dev/null
>> +++ b/Documentation/misc-devices/smpro-errmon.rst
>> @@ -0,0 +1,193 @@
>> +.. SPDX-License-Identifier: GPL-2.0-only
>> +
>> +Kernel driver Ampere(R)'s Altra(R) SMpro errmon
>> +===============================================
>> +
>> +Supported chips:
>> +
>> +  * Ampere(R) Altra(R)
>> +
>> +    Prefix: 'smpro'
>> +
>> +    Preference: Altra SoC BMC Interface Specification
>> +
>> +Author: Thu Nguyen <thu@os.amperecomputing.com>
>> +
>> +Description
>> +-----------
>> +
>> +This driver supports hardware monitoring for Ampere(R) Altra(R) SoC's based on the
>> +SMpro co-processor (SMpro).
>> +The following SoC alert/event types are supported by the errmon driver:
>> +
>> +* Core CE/UE error
>> +* Memory CE/UE error
>> +* PCIe CE/UE error
>> +* Other CE/UE error
>> +* Internal SMpro/PMpro error
>> +* VRD hot
>> +* VRD warn/fault
>> +* DIMM Hot
>> +
>> +The SMpro interface provides the registers to query the status of the SoC alerts/events
>> +and their data and export to userspace by this driver.
>> +
>> +The SoC alerts/events will be referenced as error below.
>> +
>> +Usage Notes
>> +-----------
>> +
>> +SMpro errmon driver creates the sysfs files for each error type.
>> +Example: ``error_core_ce`` to get Core CE error type.
>> +
>> +* If the error is absented, the sysfs file returns empty.
>> +* If the errors are presented, one each read to the sysfs, the oldest error will be returned and clear, the next read will be returned with the next error until all the errors are read out.
>> +
>> +For each host error type, SMpro keeps a latest max number of errors. All the oldest errors that were not read out will be dropped. In that case, the read to the corresponding overflow sysfs will return 1, otherwise, return 0.
>> +Example: ``overflow_core_ce`` to report the overflow status of Core CE error type.
>> +
>> +The format of the error is depended on the error type.
>> +
>> +1) For Core/Memory/PCIe/Other CE/UE error types::
>> +
>> +The return 48-byte in hex format in table below:
>> +
>> +    =======   =============   ===========   ==========================================
>> +    OFFSET    FIELD           SIZE (BYTE)   DESCRIPTION
>> +    =======   =============   ===========   ==========================================
>> +    00        Error Type      1             See Table below for details
>> +    01        Subtype         1             See Table below for details
>> +    02        Instance        2             See Table below for details
>> +    04        Error status    4             See ARM RAS specification for details
>> +    08        Error Address   8             See ARM RAS specification for details
>> +    16        Error Misc 0    8             See ARM RAS specification for details
>> +    24        Error Misc 1    8             See ARM RAS specification for details
>> +    32        Error Misc 2    8             See ARM RAS specification for details
>> +    40        Error Misc 3    8             See ARM RAS specification for details
>> +    =======   =============   ===========   ==========================================
>> +
>> +Below table defines the value of Error types, Sub Types, Sub component and instance:
>> +
>> +    ============    ==========    =========   ===============  ====================================
>> +    Error Group     Error Type    Sub type    Sub component    Instance
>> +    ============    ==========    =========   ===============  ====================================
>> +    CPM (core)      0             0           Snoop-Logic      CPM #
>> +    CPM (core)      0             2           Armv8 Core 1     CPM #
>> +    MCU (mem)       1             1           ERR1             MCU # | SLOT << 11
>> +    MCU (mem)       1             2           ERR2             MCU # | SLOT << 11
>> +    MCU (mem)       1             3           ERR3             MCU #
>> +    MCU (mem)       1             4           ERR4             MCU #
>> +    MCU (mem)       1             5           ERR5             MCU #
>> +    MCU (mem)       1             6           ERR6             MCU #
>> +    MCU (mem)       1             7           Link Error       MCU #
>> +    Mesh (other)    2             0           Cross Point      X | (Y << 5) | NS <<11
>> +    Mesh (other)    2             1           Home Node(IO)    X | (Y << 5) | NS <<11
>> +    Mesh (other)    2             2           Home Node(Mem)   X | (Y << 5) | NS <<11 | device<<12
>> +    Mesh (other)    2             4           CCIX Node        X | (Y << 5) | NS <<11
>> +    2P Link (other) 3             0           N/A              Altra 2P Link #
>> +    GIC (other)     5             0           ERR0             0
>> +    GIC (other)     5             1           ERR1             0
>> +    GIC (other)     5             2           ERR2             0
>> +    GIC (other)     5             3           ERR3             0
>> +    GIC (other)     5             4           ERR4             0
>> +    GIC (other)     5             5           ERR5             0
>> +    GIC (other)     5             6           ERR6             0
>> +    GIC (other)     5             7           ERR7             0
>> +    GIC (other)     5             8           ERR8             0
>> +    GIC (other)     5             9           ERR9             0
>> +    GIC (other)     5             10          ERR10            0
>> +    GIC (other)     5             11          ERR11            0
>> +    GIC (other)     5             12          ERR12            0
>> +    GIC (other)     5             13-21       ERR13            RC# + 1
>> +    SMMU (other)    6             TCU         100              RC #
>> +    SMMU (other)    6             TBU0        0                RC #
>> +    SMMU (other)    6             TBU1        1                RC #
>> +    SMMU (other)    6             TBU2        2                RC #
>> +    SMMU (other)    6             TBU3        3                RC #
>> +    SMMU (other)    6             TBU4        4                RC #
>> +    SMMU (other)    6             TBU5        5                RC #
>> +    SMMU (other)    6             TBU6        6                RC #
>> +    SMMU (other)    6             TBU7        7                RC #
>> +    SMMU (other)    6             TBU8        8                RC #
>> +    SMMU (other)    6             TBU9        9                RC #
>> +    PCIe AER (pcie) 7             Root        0                RC #
>> +    PCIe AER (pcie) 7             Device      1                RC #
>> +    PCIe RC (pcie)  8             RCA HB      0                RC #
>> +    PCIe RC (pcie)  8             RCB HB      1                RC #
>> +    PCIe RC (pcie)  8             RASDP       8                RC #
>> +    OCM (other)     9             ERR0        0                0
>> +    OCM (other)     9             ERR1        1                0
>> +    OCM (other)     9             ERR2        2                0
>> +    SMpro (other)   10            ERR0        0                0
>> +    SMpro (other)   10            ERR1        1                0
>> +    SMpro (other)   10            MPA_ERR     2                0
>> +    PMpro (other)   11            ERR0        0                0
>> +    PMpro (other)   11            ERR1        1                0
>> +    PMpro (other)   11            MPA_ERR     2                0
>> +    ============    ==========    =========   ===============  ====================================
>> +
>> +    For example:
>> +    # cat error_other_ue
>> +    880807001e004010401040101500000001004010401040100c0000000000000000000000000000000000000000000000
>> +
>> +2) For the Internal SMpro/PMpro error types::
>> +
>> +The error_[smpro|pmro] sysfs returns string of 8-byte hex value:
>> +    <4-byte hex value of Error info><4-byte hex value of Error extensive data>
>> +
>> +The warn_[smpro|pmro] sysfs returns string of 4-byte hex value:
>> +    <4-byte hex value of Warning info>
>> +
>> +Reference to Altra SoC BMC Interface Specification for the details.
>> +
>> +3) For the VRD hot, VRD /warn/fault, DIMM Hot event::
>> +
>> +The return string is 2-byte hex string value. Reference to section 5.7 GPI status register in Altra SoC BMC Interface Specification for the details.
>> +
>> +    Example:
>> +    #cat event_vrd_hot
>> +    0000
>> +
>> +Sysfs entries
>> +-------------
>> +
>> +The following sysfs files are supported:
>> +
>> +* Ampere(R) Altra(R):
>> +
>> +Alert Types:
>> +
>> +    ========================  =================  ==================================================
>> +    Alert Type                Sysfs name         Description
>> +    ========================  =================  ==================================================
>> +    Core CE Error             error_core_ce      Trigger when Core has CE error
>> +    Core CE Error overflow    overflow_core_ce   Trigger when Core CE error overflow
>> +    Core UE Error             error_core_ue      Trigger when Core has UE error
>> +    Core UE Error overflow    overflow_core_ue   Trigger when Core UE error overflow
>> +    Memory CE Error           error_mem_ce       Trigger when Memory has CE error
>> +    Memory CE Error overflow  overflow_mem_ce    Trigger when Memory CE error overflow
>> +    Memory UE Error           error_mem_ue       Trigger when Memory has UE error
>> +    Memory UE Error overflow  overflow_mem_ue    Trigger when Memory UE error overflow
>> +    PCIe CE Error             error_pcie_ce      Trigger when any PCIe controller has CE error
>> +    PCIe CE Error overflow    overflow_pcie_ce   Trigger when any PCIe controller CE error overflow
>> +    PCIe UE Error             error_pcie_ue      Trigger when any PCIe controller has UE error
>> +    PCIe UE Error overflow    overflow_pcie_ue   Trigger when any PCIe controller UE error overflow
>> +    Other CE Error            error_other_ce     Trigger when any Others CE error
>> +    Other CE Error overflow   overflow_other_ce  Trigger when any Others CE error overflow
>> +    Other UE Error            error_other_ue     Trigger when any Others UE error
>> +    Other UE Error overflow   overflow_other_ue  Trigger when Others UE error overflow
>> +    SMpro Error               error_smpro        Trigger when system have SMpro error
>> +    SMpro Warning             warn_smpro         Trigger when system have SMpro warning
>> +    PMpro Error               error_pmpro        Trigger when system have PMpro error
>> +    PMpro Warning             warn_pmpro         Trigger when system have PMpro warning
>> +    ========================  =================  ==================================================
>> +
>> +Event Type:
>> +
>> +    ============================ ==========================
>> +    Event Type                   Sysfs name
>> +    ============================ ==========================
>> +    VRD HOT                      event_vrd_hot
>> +    VR Warn/Fault                event_vrd_warn_fault
>> +    DIMM Hot                     event_dimm_hot
>> +    ============================ ==========================
> 
> The documentation above produces htmldocs warnings:
> Documentation/misc-devices/smpro-errmon.rst:53: WARNING: Literal block expected; none found.
> Documentation/misc-devices/smpro-errmon.rst:87: WARNING: Malformed table.
> Text in column margin in table line 17.
> <snipped>...
> Documentation/misc-devices/smpro-errmon.rst:135: WARNING: Literal block expected; none found.
> Documentation/misc-devices/smpro-errmon.rst:145: WARNING: Literal block expected; none found.
> 
> I have applied the fixup (with grammatical and formatting fixes):
> 
> ---- >8 ----
> 
> diff --git a/Documentation/misc-devices/smpro-errmon.rst b/Documentation/misc-devices/smpro-errmon.rst
> index b17f30a6cafdab..de8719cc47fd3c 100644
> --- a/Documentation/misc-devices/smpro-errmon.rst
> +++ b/Documentation/misc-devices/smpro-errmon.rst
> @@ -7,18 +7,18 @@ Supported chips:
>   
>     * Ampere(R) Altra(R)
>   
> -    Prefix: 'smpro'
> +    Prefix: `smpro`
>   
> -    Preference: Altra SoC BMC Interface Specification
> +    Reference: `Altra SoC BMC Interface Specification`
>   
>   Author: Thu Nguyen <thu@os.amperecomputing.com>
>   
>   Description
>   -----------
>   
> -This driver supports hardware monitoring for Ampere(R) Altra(R) SoC's based on the
> -SMpro co-processor (SMpro).
> -The following SoC alert/event types are supported by the errmon driver:
> +The smpro-errmon driver supports hardware monitoring for Ampere(R) Altra(R)
> +SoCs based on the SMpro co-processor (SMpro). The following SoC alert/event
> +types are supported by the driver:
>   
>   * Core CE/UE error
>   * Memory CE/UE error
> @@ -29,165 +29,178 @@ The following SoC alert/event types are supported by the errmon driver:
>   * VRD warn/fault
>   * DIMM Hot
>   
> -The SMpro interface provides the registers to query the status of the SoC alerts/events
> -and their data and export to userspace by this driver.
> +The SMpro interface provides the registers to query the status of the SoC
> +alerts/events and their data and export to userspace by this driver.
>   
> -The SoC alerts/events will be referenced as error below.
> +The rest of this document will refer SoC alerts/events as errors.
>   
>   Usage Notes
>   -----------
>   
>   SMpro errmon driver creates the sysfs files for each error type.
> -Example: ``error_core_ce`` to get Core CE error type.
> +See :ref:`smpro_sysfs` for the list of errors and the corresponding
> +sysfs files.
>   
> -* If the error is absented, the sysfs file returns empty.
> -* If the errors are presented, one each read to the sysfs, the oldest error will be returned and clear, the next read will be returned with the next error until all the errors are read out.
> +* If there is no errors, the sysfs file is empty.
> +* Otherwise, when errors occur, the oldest error
> +  will be returned on sysfs file reading and cleared. The next read will
> +  return the next error until all the errors are read out.
>   
> -For each host error type, SMpro keeps a latest max number of errors. All the oldest errors that were not read out will be dropped. In that case, the read to the corresponding overflow sysfs will return 1, otherwise, return 0.
> -Example: ``overflow_core_ce`` to report the overflow status of Core CE error type.
> +For each host error type, SMpro keeps a latest max number of errors. All the
> +oldest errors that were not read will be dropped. In that case, the read
> +to the corresponding sysfs will return 1, otherwise return 0.
>   
> -The format of the error is depended on the error type.
> +The error format depends on its type.
>   
> -1) For Core/Memory/PCIe/Other CE/UE error types::
> +1) For Core/Memory/PCIe/Other CE/UE error types
>   
> -The return 48-byte in hex format in table below:
> +   These errors return 48-byte in hex format according to the table below:
>   
> -    =======   =============   ===========   ==========================================
> -    OFFSET    FIELD           SIZE (BYTE)   DESCRIPTION
> -    =======   =============   ===========   ==========================================
> -    00        Error Type      1             See Table below for details
> -    01        Subtype         1             See Table below for details
> -    02        Instance        2             See Table below for details
> -    04        Error status    4             See ARM RAS specification for details
> -    08        Error Address   8             See ARM RAS specification for details
> -    16        Error Misc 0    8             See ARM RAS specification for details
> -    24        Error Misc 1    8             See ARM RAS specification for details
> -    32        Error Misc 2    8             See ARM RAS specification for details
> -    40        Error Misc 3    8             See ARM RAS specification for details
> -    =======   =============   ===========   ==========================================
> +   =======   =============   ===========   ==========================================================
> +   OFFSET    FIELD           SIZE (BYTE)   DESCRIPTION
> +   =======   =============   ===========   ==========================================================
> +   00        Error Type      1             See :ref:`the table below <smpro-error-types>` for details
> +   01        Subtype         1             See :ref:`the table below <smpro-error-types>` for details
> +   02        Instance        2             See :ref:`the table below <smpro-error-types>` for details
> +   04        Error status    4             See ARM RAS specification for details
> +   08        Error Address   8             See ARM RAS specification for details
> +   16        Error Misc 0    8             See ARM RAS specification for details
> +   24        Error Misc 1    8             See ARM RAS specification for details
> +   32        Error Misc 2    8             See ARM RAS specification for details
> +   40        Error Misc 3    8             See ARM RAS specification for details
> +   =======   =============   ===========   ==========================================================
>   
> -Below table defines the value of Error types, Sub Types, Sub component and instance:
> +   The table below defines the value of error types, their subtype, subcomponent and instance:
>   
> -    ============    ==========    =========   ===============  ====================================
> -    Error Group     Error Type    Sub type    Sub component    Instance
> -    ============    ==========    =========   ===============  ====================================
> -    CPM (core)      0             0           Snoop-Logic      CPM #
> -    CPM (core)      0             2           Armv8 Core 1     CPM #
> -    MCU (mem)       1             1           ERR1             MCU # | SLOT << 11
> -    MCU (mem)       1             2           ERR2             MCU # | SLOT << 11
> -    MCU (mem)       1             3           ERR3             MCU #
> -    MCU (mem)       1             4           ERR4             MCU #
> -    MCU (mem)       1             5           ERR5             MCU #
> -    MCU (mem)       1             6           ERR6             MCU #
> -    MCU (mem)       1             7           Link Error       MCU #
> -    Mesh (other)    2             0           Cross Point      X | (Y << 5) | NS <<11
> -    Mesh (other)    2             1           Home Node(IO)    X | (Y << 5) | NS <<11
> -    Mesh (other)    2             2           Home Node(Mem)   X | (Y << 5) | NS <<11 | device<<12
> -    Mesh (other)    2             4           CCIX Node        X | (Y << 5) | NS <<11
> -    2P Link (other) 3             0           N/A              Altra 2P Link #
> -    GIC (other)     5             0           ERR0             0
> -    GIC (other)     5             1           ERR1             0
> -    GIC (other)     5             2           ERR2             0
> -    GIC (other)     5             3           ERR3             0
> -    GIC (other)     5             4           ERR4             0
> -    GIC (other)     5             5           ERR5             0
> -    GIC (other)     5             6           ERR6             0
> -    GIC (other)     5             7           ERR7             0
> -    GIC (other)     5             8           ERR8             0
> -    GIC (other)     5             9           ERR9             0
> -    GIC (other)     5             10          ERR10            0
> -    GIC (other)     5             11          ERR11            0
> -    GIC (other)     5             12          ERR12            0
> -    GIC (other)     5             13-21       ERR13            RC# + 1
> -    SMMU (other)    6             TCU         100              RC #
> -    SMMU (other)    6             TBU0        0                RC #
> -    SMMU (other)    6             TBU1        1                RC #
> -    SMMU (other)    6             TBU2        2                RC #
> -    SMMU (other)    6             TBU3        3                RC #
> -    SMMU (other)    6             TBU4        4                RC #
> -    SMMU (other)    6             TBU5        5                RC #
> -    SMMU (other)    6             TBU6        6                RC #
> -    SMMU (other)    6             TBU7        7                RC #
> -    SMMU (other)    6             TBU8        8                RC #
> -    SMMU (other)    6             TBU9        9                RC #
> -    PCIe AER (pcie) 7             Root        0                RC #
> -    PCIe AER (pcie) 7             Device      1                RC #
> -    PCIe RC (pcie)  8             RCA HB      0                RC #
> -    PCIe RC (pcie)  8             RCB HB      1                RC #
> -    PCIe RC (pcie)  8             RASDP       8                RC #
> -    OCM (other)     9             ERR0        0                0
> -    OCM (other)     9             ERR1        1                0
> -    OCM (other)     9             ERR2        2                0
> -    SMpro (other)   10            ERR0        0                0
> -    SMpro (other)   10            ERR1        1                0
> -    SMpro (other)   10            MPA_ERR     2                0
> -    PMpro (other)   11            ERR0        0                0
> -    PMpro (other)   11            ERR1        1                0
> -    PMpro (other)   11            MPA_ERR     2                0
> -    ============    ==========    =========   ===============  ====================================
> +   .. _smpro-error-types:
>   
> -    For example:
> -    # cat error_other_ue
> -    880807001e004010401040101500000001004010401040100c0000000000000000000000000000000000000000000000
> +   =============== ==========    =========   ===============  ====================================
> +   Error Group     Error Type    Sub type    Sub component    Instance
> +   =============== ==========    =========   ===============  ====================================
> +   CPM (core)      0             0           Snoop-Logic      CPM #
> +   CPM (core)      0             2           Armv8 Core 1     CPM #
> +   MCU (mem)       1             1           ERR1             MCU # | SLOT << 11
> +   MCU (mem)       1             2           ERR2             MCU # | SLOT << 11
> +   MCU (mem)       1             3           ERR3             MCU #
> +   MCU (mem)       1             4           ERR4             MCU #
> +   MCU (mem)       1             5           ERR5             MCU #
> +   MCU (mem)       1             6           ERR6             MCU #
> +   MCU (mem)       1             7           Link Error       MCU #
> +   Mesh (other)    2             0           Cross Point      X | (Y << 5) | NS <<11
> +   Mesh (other)    2             1           Home Node(IO)    X | (Y << 5) | NS <<11
> +   Mesh (other)    2             2           Home Node(Mem)   X | (Y << 5) | NS <<11 | device<<12
> +   Mesh (other)    2             4           CCIX Node        X | (Y << 5) | NS <<11
> +   2P Link (other) 3             0           N/A              Altra 2P Link #
> +   GIC (other)     5             0           ERR0             0
> +   GIC (other)     5             1           ERR1             0
> +   GIC (other)     5             2           ERR2             0
> +   GIC (other)     5             3           ERR3             0
> +   GIC (other)     5             4           ERR4             0
> +   GIC (other)     5             5           ERR5             0
> +   GIC (other)     5             6           ERR6             0
> +   GIC (other)     5             7           ERR7             0
> +   GIC (other)     5             8           ERR8             0
> +   GIC (other)     5             9           ERR9             0
> +   GIC (other)     5             10          ERR10            0
> +   GIC (other)     5             11          ERR11            0
> +   GIC (other)     5             12          ERR12            0
> +   GIC (other)     5             13-21       ERR13            RC# + 1
> +   SMMU (other)    6             TCU         100              RC #
> +   SMMU (other)    6             TBU0        0                RC #
> +   SMMU (other)    6             TBU1        1                RC #
> +   SMMU (other)    6             TBU2        2                RC #
> +   SMMU (other)    6             TBU3        3                RC #
> +   SMMU (other)    6             TBU4        4                RC #
> +   SMMU (other)    6             TBU5        5                RC #
> +   SMMU (other)    6             TBU6        6                RC #
> +   SMMU (other)    6             TBU7        7                RC #
> +   SMMU (other)    6             TBU8        8                RC #
> +   SMMU (other)    6             TBU9        9                RC #
> +   PCIe AER (pcie) 7             Root        0                RC #
> +   PCIe AER (pcie) 7             Device      1                RC #
> +   PCIe RC (pcie)  8             RCA HB      0                RC #
> +   PCIe RC (pcie)  8             RCB HB      1                RC #
> +   PCIe RC (pcie)  8             RASDP       8                RC #
> +   OCM (other)     9             ERR0        0                0
> +   OCM (other)     9             ERR1        1                0
> +   OCM (other)     9             ERR2        2                0
> +   SMpro (other)   10            ERR0        0                0
> +   SMpro (other)   10            ERR1        1                0
> +   SMpro (other)   10            MPA_ERR     2                0
> +   PMpro (other)   11            ERR0        0                0
> +   PMpro (other)   11            ERR1        1                0
> +   PMpro (other)   11            MPA_ERR     2                0
> +   =============== ==========    =========   ===============  ====================================
>   
> -2) For the Internal SMpro/PMpro error types::
> +   Example::
>   
> -The error_[smpro|pmro] sysfs returns string of 8-byte hex value:
> -    <4-byte hex value of Error info><4-byte hex value of Error extensive data>
> +     # cat error_other_ue
> +     880807001e004010401040101500000001004010401040100c0000000000000000000000000000000000000000000000
>   
> -The warn_[smpro|pmro] sysfs returns string of 4-byte hex value:
> -    <4-byte hex value of Warning info>
> +2) For the internal SMpro/PMpro error types
>   
> -Reference to Altra SoC BMC Interface Specification for the details.
> +   The ``error_[smpro|pmro]`` sysfs returns string of 8-byte hex value::
>   
> -3) For the VRD hot, VRD /warn/fault, DIMM Hot event::
> +     <4-byte hex value of Error info><4-byte hex value of Error extensive data>
>   
> -The return string is 2-byte hex string value. Reference to section 5.7 GPI status register in Altra SoC BMC Interface Specification for the details.
> +   The ``warn_[smpro|pmro]`` sysfs returns string of 4-byte hex value::
>   
> -    Example:
> -    #cat event_vrd_hot
> -    0000
> +     <4-byte hex value of Warning info>
> +
> +   Refer to `Altra SoC BMC Interface Specification` for details.
> +
> +3) For the VRD hot, VRD warn/fault, DIMM Hot event
> +
> +   The return string is 2-byte hex string value. Refer to section `5.7 GPI
> +   status register` in `Altra SoC BMC Interface Specification` for details.
> +
> +   Example::
> +
> +      #cat event_vrd_hot
> +      0000
> +
> +.. _smpro_sysfs:
>   
>   Sysfs entries
>   -------------
>   
>   The following sysfs files are supported:
>   
> -* Ampere(R) Altra(R):
> +* Ampere(R) Altra(R)
>   
> -Alert Types:
> +  Alert types:
>   
> -    ========================  =================  ==================================================
> -    Alert Type                Sysfs name         Description
> -    ========================  =================  ==================================================
> -    Core CE Error             error_core_ce      Trigger when Core has CE error
> -    Core CE Error overflow    overflow_core_ce   Trigger when Core CE error overflow
> -    Core UE Error             error_core_ue      Trigger when Core has UE error
> -    Core UE Error overflow    overflow_core_ue   Trigger when Core UE error overflow
> -    Memory CE Error           error_mem_ce       Trigger when Memory has CE error
> -    Memory CE Error overflow  overflow_mem_ce    Trigger when Memory CE error overflow
> -    Memory UE Error           error_mem_ue       Trigger when Memory has UE error
> -    Memory UE Error overflow  overflow_mem_ue    Trigger when Memory UE error overflow
> -    PCIe CE Error             error_pcie_ce      Trigger when any PCIe controller has CE error
> -    PCIe CE Error overflow    overflow_pcie_ce   Trigger when any PCIe controller CE error overflow
> -    PCIe UE Error             error_pcie_ue      Trigger when any PCIe controller has UE error
> -    PCIe UE Error overflow    overflow_pcie_ue   Trigger when any PCIe controller UE error overflow
> -    Other CE Error            error_other_ce     Trigger when any Others CE error
> -    Other CE Error overflow   overflow_other_ce  Trigger when any Others CE error overflow
> -    Other UE Error            error_other_ue     Trigger when any Others UE error
> -    Other UE Error overflow   overflow_other_ue  Trigger when Others UE error overflow
> -    SMpro Error               error_smpro        Trigger when system have SMpro error
> -    SMpro Warning             warn_smpro         Trigger when system have SMpro warning
> -    PMpro Error               error_pmpro        Trigger when system have PMpro error
> -    PMpro Warning             warn_pmpro         Trigger when system have PMpro warning
> -    ========================  =================  ==================================================
> +    ========================  =====================  ==================================================
> +    Alert type                Sysfs name             Description (when the error is triggered)
> +    ========================  =====================  ==================================================
> +    Core CE Error             ``error_core_ce``      Core has CE error
> +    Core CE Error overflow    ``overflow_core_ce``   Core CE error overflow
> +    Core UE Error             ``error_core_ue``      Core has UE error
> +    Core UE Error overflow    ``overflow_core_ue``   Core UE error overflow
> +    Memory CE Error           ``error_mem_ce``       Memory has CE error
> +    Memory CE Error overflow  ``overflow_mem_ce``    Memory CE error overflow
> +    Memory UE Error           ``error_mem_ue``       Memory has UE error
> +    Memory UE Error overflow  ``overflow_mem_ue``    Memory UE error overflow
> +    PCIe CE Error             ``error_pcie_ce``      any PCIe controller has CE error
> +    PCIe CE Error overflow    ``overflow_pcie_ce``   any PCIe controller CE error overflow
> +    PCIe UE Error             ``error_pcie_ue``      any PCIe controller has UE error
> +    PCIe UE Error overflow    ``overflow_pcie_ue``   any PCIe controller UE error overflow
> +    Other CE Error            ``error_other_ce``     any other CE error
> +    Other CE Error overflow   ``overflow_other_ce``  any other CE error overflow
> +    Other UE Error            ``error_other_ue``     any other UE error
> +    Other UE Error overflow   ``overflow_other_ue``  other UE error overflow
> +    SMpro Error               ``error_smpro``        system have SMpro error
> +    SMpro Warning             ``warn_smpro``         system have SMpro warning
> +    PMpro Error               ``error_pmpro``        system have PMpro error
> +    PMpro Warning             ``warn_pmpro``         system have PMpro warning
> +    ========================  =====================  ==================================================
>   
> -Event Type:
> +  Event types:
>   
>       ============================ ==========================
> -    Event Type                   Sysfs name
> +    Event type                   Sysfs name
>       ============================ ==========================
> -    VRD HOT                      event_vrd_hot
> -    VR Warn/Fault                event_vrd_warn_fault
> -    DIMM Hot                     event_dimm_hot
> +    VRD HOT                      ``event_vrd_hot``
> +    VR Warn/Fault                ``event_vrd_warn_fault``
> +    DIMM Hot                     ``event_dimm_hot``
>       ============================ ==========================
> 

Thanks Bagas and will apply in next version but it may be moved to 
Documentation/ABI as per Greg's suggestion.

- Quan