Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8addc83702f41e1afb2ded341da0fd797539ffc.camel@mediatek.com>
Subject: Re: [PATCH 8/8] soc: mtk-svs: mt8192: fix bank data
From:   Roger Lu <roger.lu@mediatek.com>
To:     <matthias.bgg@kernel.org>, <jia-wei.chang@mediatek.com>
CC:     <nfraprado@collabora.com>, <khilman@baylibre.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <angelogioacchino.delregno@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Date:   Thu, 6 Oct 2022 19:43:30 +0800
In-Reply-To: <20220928155519.31977-9-matthias.bgg@kernel.org>
References: <20220928155519.31977-1-matthias.bgg@kernel.org>
         <20220928155519.31977-9-matthias.bgg@kernel.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Matthias Sir,

This addition is for indicating vmax value is increased by dvt_fixed.
Please keep this information to make it be seen. Many thanks.

Sincerely,
Roger Lu.

On Wed, 2022-09-28 at 17:55 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> Values vmax and dvt_fixed are not changed at runtime, set them as needed
> in the svs_banks struct.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
>  drivers/soc/mediatek/mt8192-svs.h     | 4 ++--
>  drivers/soc/mediatek/mtk-svs-mt8192.c | 2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mt8192-svs.h b/drivers/soc/mediatek/mt8192-
> svs.h
> index 6571ebcb2c0f..bf8c6030428f 100644
> --- a/drivers/soc/mediatek/mt8192-svs.h
> +++ b/drivers/soc/mediatek/mt8192-svs.h
> @@ -16,7 +16,7 @@ static struct svs_bank svs_mt8192_banks[] = {
>  		.turn_freq_base		= 688000000,
>  		.volt_step		= 6250,
>  		.volt_base		= 400000,
> -		.vmax			= 0x60,
> +		.vmax			= 0x61,
>  		.vmin			= 0x1a,
>  		.age_config		= 0x555555,
>  		.dc_config		= 0x1,
> @@ -41,7 +41,7 @@ static struct svs_bank svs_mt8192_banks[] = {
>  		.turn_freq_base		= 688000000,
>  		.volt_step		= 6250,
>  		.volt_base		= 400000,
> -		.vmax			= 0x60,
> +		.vmax			= 0x66,
>  		.vmin			= 0x1a,
>  		.age_config		= 0x555555,
>  		.dc_config		= 0x1,
> diff --git a/drivers/soc/mediatek/mtk-svs-mt8192.c b/drivers/soc/mediatek/mtk-
> svs-mt8192.c
> index 838a94834741..183acf2829f0 100644
> --- a/drivers/soc/mediatek/mtk-svs-mt8192.c
> +++ b/drivers/soc/mediatek/mtk-svs-mt8192.c
> @@ -40,8 +40,6 @@ bool svs_mt8192_efuse_parsing(struct svs_platform *svsp)
>  			svsb->dcbdet = (svsp->efuse[17] >> 16) & GENMASK(7, 0);
>  			svsb->dcmdet = (svsp->efuse[17] >> 24) & GENMASK(7, 0);
>  		}
> -
> -		svsb->vmax += svsb->dvt_fixed;
>  	}
>  
>  	ret = svs_thermal_efuse_get_data(svsp);